Fix push down failure for min/max on derived field - #4572

Merged
yuancu merged 3 commits into
opensearch-project:mainfrom
qianheng-aws:fix4571
Oct 17, 2025
Merged

Fix push down failure for min/max on derived field#4572
yuancu merged 3 commits into
opensearch-project:mainfrom
qianheng-aws:fix4571

Conversation

@qianheng-aws

@qianheng-awsqianheng-aws commented Oct 15, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Fix push down failure for min/max on derived field

#4281 introduced below code for MIN/MAX in AggregateAnalyzer::createRegularAggregation

 String fieldName = helper.inferNamedField(args.getFirst()).getRootName();
ExprType fieldType = helper.fieldTypes.get(fieldName);

which will throw NPE for derived fields, and then fails to push dow the agg.

Related Issues

Resolves#4571, #4460

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@qianheng-aws
Fix push down failure for min/max on derived field
15dbd78
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws added the bug Something isn't working label Oct 15, 2025
@qianheng-aws
Revert unnecessary change
92bf993
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
LantaoJin previously approved these changes Oct 16, 2025
View reviewed changes
@qianheng-aws
Merge remote-tracking branch 'refs/remotes/origin/main' into fix4571
c51a5a4
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
@yuancu
yuancu merged commit 0257aa5 into opensearch-project:mainOct 17, 2025
33 checks passed
@opensearch-trigger-bot

opensearch-trigger-botBot commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

The backport to 2.19-dev failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4572-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0257aa5d51f044f3287bbaffc83aa72f8960c57c
# Push it to GitHub
git push --set-upstream origin backport/backport-4572-to-2.19-dev
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev

Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4572-to-2.19-dev.

qianheng-aws added a commit to qianheng-aws/sql that referenced this pull request Oct 20, 2025
@qianheng-aws
Fix push down failure for min/max on derived field (opensearch-projec…
1cb8874
…t#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws mentioned this pull request Oct 20, 2025
Merged
qianheng-aws added a commit that referenced this pull request Oct 20, 2025
@qianheng-aws
[Backport 2.19-dev] Fix push down failure for min/max on derived field (
e7caf59
#4572) (#4601)
* Fix push down failure for min/max on derived field (#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* fix IT
Signed-off-by: Heng Qian <qianheng@amazon.com>
---------
Signed-off-by: Heng Qian <qianheng@amazon.com>
@LantaoJinLantaoJin added the backport-manually Filed a PR to backport manually. label Oct 22, 2025
sandeshkr419 added a commit to sandeshkr419/sql that referenced this pull request Dec 3, 2025
@sandeshkr419@github-actions
@Swiddis@manasvinibs@opensearch-ci-bot@noCharger@dai-chen@cnoramut@yuancu@opensearch-trigger-bot@ahkcs@penghuo@alexey-temnikov@RileyJergerAmazon@ykmr1224@LantaoJin@songkant-aws@qianheng-aws@xinyual@RyanL1997@peterzhuamazon@vinaykpud@expani@vamsimanohar@ritvibhatt@ishaoxy@mch2
Data fusion changes
6f7fd68
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Co-authored-by: Manasvini B S <manasvis@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Mebsina <cnoramut@gmail.com>
Co-authored-by: Yuanchun Shen <yuanchu@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kai Huang <105710027+ahkcs@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Co-authored-by: Riley Jerger <214163063+RileyJergerAmazon@users.noreply.github.com>
Co-authored-by: Tomoyuki MORITA <moritato@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
Co-authored-by: qianheng <qianheng@amazon.com>
Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
Co-authored-by: Xinyuan Lu <xinyual@amazon.com>
Co-authored-by: Jialiang Liang <jiallian@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Co-authored-by: expani <anijainc@amazon.com>
Co-authored-by: expani1729 <110471048+expani@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Co-authored-by: Xinyu Hao <75524174+ishaoxy@users.noreply.github.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Fix join type ambiguous issue when specify the join type with sql-like join criteria (opensearch-project#4474)
Fix issue 4441 (opensearch-project#4449)
Fix missing keywordsCanBeId (opensearch-project#4491)
Fix the bug of explicit makeNullLiteral for UDT fields (opensearch-project#4475)
Fix mapping after aggregation push down (opensearch-project#4500)
Fix percentile bug (opensearch-project#4539)
Fix JsonExtractAllFunctionIT failure (opensearch-project#4556)
Fix sort push down into agg after project already pushed (opensearch-project#4546)
Fix push down failure for min/max on derived field (opensearch-project#4572)
Fix compile issue in main (opensearch-project#4608)
Fix filter parsing failure on date fields with non-default format (opensearch-project#4616)
Fix bin nested fields issue (opensearch-project#4606)
Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
fix rename issue (opensearch-project#4670)
Fixes for `Multisearch` and `Append` command (opensearch-project#4512)
Fix asc/desc keyword behavior for sort command (opensearch-project#4651)
Fix] Fix unexpected shift of extraction for `rex` with nested capture groups in named groups (opensearch-project#4641)
Fix CVE-2025-48924 (opensearch-project#4665)
Fix sub-fields accessing of generated structs (opensearch-project#4683)
Fix] Incorrect Field Index Mapping in AVG to SUM/COUNT Conversion (opensearch-project#15)
@qianheng-aws
qianheng-aws deleted the fix4571 branch March 26, 2026 10:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LantaoJinLantaoJinLantaoJin approved these changes
@yuancuyuancuyuancu approved these changes
@ps48ps48Awaiting requested review from ps48ps48 is a code owner
@kavithacmkavithacmAwaiting requested review from kavithacm
@derek-hoderek-hoAwaiting requested review from derek-ho
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen is a code owner
@YANG-DBYANG-DBAwaiting requested review from YANG-DB
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo is a code owner
@seankao-azseankao-azAwaiting requested review from seankao-az
@MaxKsyunzMaxKsyunzAwaiting requested review from MaxKsyunz
@Yury-FridlyandYury-FridlyandAwaiting requested review from Yury-Fridlyand
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha is a code owner
@forestmveyforestmveyAwaiting requested review from forestmvey
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto is a code owner
@GumpacGGumpacGAwaiting requested review from GumpacG
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 is a code owner

Assignees

No one assigned

Labels

backport 2.19-devbackport-failedbackport-manuallyFiled a PR to backport manually.bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Min/Max on derived fields cannot be pushed down

3 participants

@qianheng-aws@LantaoJin@yuancu
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix push down failure for min/max on derived field - #4572
Merged
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Oct 17, 2025
Merged
Fix push down failure for min/max on derived field#4572
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Conversation
@qianheng-aws
@qianheng-awsqianheng-aws
commented
Oct 15, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
Fix push down failure for min/max on derived field
#4281 introduced below code for MIN/MAX in AggregateAnalyzer::createRegularAggregation
 String fieldName = helper.inferNamedField(args.getFirst()).getRootName();
ExprType fieldType = helper.fieldTypes.get(fieldName);

which will throw NPE for derived fields, and then fails to push dow the agg.
Related Issues
Resolves#4571, #4460
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@qianheng-aws
Fix push down failure for min/max on derived field
15dbd78
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
added
the 
bug
Something isn't working
label
Oct 15, 2025
@qianheng-aws
Revert unnecessary change
92bf993
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
LantaoJin
previously approved these changes
Oct 16, 2025
View reviewed changes
@qianheng-aws
Merge remote-tracking branch 'refs/remotes/origin/main' into fix4571
c51a5a4
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
@yuancu
yuancu
merged commit 0257aa5
into
opensearch-project:mainOct 17, 2025

33 checks passed

@opensearch-trigger-bot
opensearch-trigger-botBot
commented
Oct 20, 2025

Copy link


Copy Markdown

Contributor
The backport to 2.19-dev failed:
The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:
# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4572-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0257aa5d51f044f3287bbaffc83aa72f8960c57c
# Push it to GitHub
git push --set-upstream origin backport/backport-4572-to-2.19-dev
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev
Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4572-to-2.19-dev.
qianheng-aws added a commit
to qianheng-aws/sql
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
Fix push down failure for min/max on derived field (opensearch-projec…
1cb8874
…t#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
mentioned this pull request
Oct 20, 2025
 Merged

qianheng-aws added a commit
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
[Backport 2.19-dev] Fix push down failure for min/max on derived field (
e7caf59
#4572) (#4601)
* Fix push down failure for min/max on derived field (#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* fix IT
Signed-off-by: Heng Qian <qianheng@amazon.com>
---------
Signed-off-by: Heng Qian <qianheng@amazon.com>
@LantaoJinLantaoJin
added
the 
backport-manually
Filed a PR to backport manually.
label
Oct 22, 2025
sandeshkr419 added a commit
to sandeshkr419/sql
that referenced
this pull request
Dec 3, 2025
@sandeshkr419@github-actions
@Swiddis@manasvinibs@opensearch-ci-bot@noCharger@dai-chen@cnoramut@yuancu@opensearch-trigger-bot@ahkcs@penghuo@alexey-temnikov@RileyJergerAmazon@ykmr1224@LantaoJin@songkant-aws@qianheng-aws@xinyual@RyanL1997@peterzhuamazon@vinaykpud@expani@vamsimanohar@ritvibhatt@ishaoxy@mch2
Data fusion changes
6f7fd68
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Co-authored-by: Manasvini B S <manasvis@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Mebsina <cnoramut@gmail.com>
Co-authored-by: Yuanchun Shen <yuanchu@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kai Huang <105710027+ahkcs@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Co-authored-by: Riley Jerger <214163063+RileyJergerAmazon@users.noreply.github.com>
Co-authored-by: Tomoyuki MORITA <moritato@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
Co-authored-by: qianheng <qianheng@amazon.com>
Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
Co-authored-by: Xinyuan Lu <xinyual@amazon.com>
Co-authored-by: Jialiang Liang <jiallian@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Co-authored-by: expani <anijainc@amazon.com>
Co-authored-by: expani1729 <110471048+expani@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Co-authored-by: Xinyu Hao <75524174+ishaoxy@users.noreply.github.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Fix join type ambiguous issue when specify the join type with sql-like join criteria (opensearch-project#4474)
Fix issue 4441 (opensearch-project#4449)
Fix missing keywordsCanBeId (opensearch-project#4491)
Fix the bug of explicit makeNullLiteral for UDT fields (opensearch-project#4475)
Fix mapping after aggregation push down (opensearch-project#4500)
Fix percentile bug (opensearch-project#4539)
Fix JsonExtractAllFunctionIT failure (opensearch-project#4556)
Fix sort push down into agg after project already pushed (opensearch-project#4546)
Fix push down failure for min/max on derived field (opensearch-project#4572)
Fix compile issue in main (opensearch-project#4608)
Fix filter parsing failure on date fields with non-default format (opensearch-project#4616)
Fix bin nested fields issue (opensearch-project#4606)
Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
fix rename issue (opensearch-project#4670)
Fixes for `Multisearch` and `Append` command (opensearch-project#4512)
Fix asc/desc keyword behavior for sort command (opensearch-project#4651)
Fix] Fix unexpected shift of extraction for `rex` with nested capture groups in named groups (opensearch-project#4641)
Fix CVE-2025-48924 (opensearch-project#4665)
Fix sub-fields accessing of generated structs (opensearch-project#4683)
Fix] Incorrect Field Index Mapping in AVG to SUM/COUNT Conversion (opensearch-project#15)
@qianheng-aws
qianheng-aws
deleted the

fix4571

branch
March 26, 2026 10:06
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@LantaoJinLantaoJinLantaoJin approved these changes
@yuancuyuancuyuancu approved these changes
@ps48ps48Awaiting requested review from ps48ps48 is a code owner
@kavithacmkavithacmAwaiting requested review from kavithacm
@derek-hoderek-hoAwaiting requested review from derek-ho
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen is a code owner
@YANG-DBYANG-DBAwaiting requested review from YANG-DB
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo is a code owner
@seankao-azseankao-azAwaiting requested review from seankao-az
@MaxKsyunzMaxKsyunzAwaiting requested review from MaxKsyunz
@Yury-FridlyandYury-FridlyandAwaiting requested review from Yury-Fridlyand
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha is a code owner
@forestmveyforestmveyAwaiting requested review from forestmvey
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto is a code owner
@GumpacGGumpacGAwaiting requested review from GumpacG
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 is a code owner

Assignees


No one assigned


Labels

backport 2.19-devbackport-failedbackport-manuallyFiled a PR to backport manually.bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Min/Max on derived fields cannot be pushed down


3 participants

@qianheng-aws@LantaoJin@yuancu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix push down failure for min/max on derived field - #4572
Merged
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Oct 17, 2025
Merged
Fix push down failure for min/max on derived field#4572
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Conversation
@qianheng-aws
@qianheng-awsqianheng-aws
commented
Oct 15, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
Fix push down failure for min/max on derived field
#4281 introduced below code for MIN/MAX in AggregateAnalyzer::createRegularAggregation
 String fieldName = helper.inferNamedField(args.getFirst()).getRootName();
ExprType fieldType = helper.fieldTypes.get(fieldName);

which will throw NPE for derived fields, and then fails to push dow the agg.
Related Issues
Resolves#4571, #4460
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@qianheng-aws
Fix push down failure for min/max on derived field
15dbd78
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
added
the 
bug
Something isn't working
label
Oct 15, 2025
@qianheng-aws
Revert unnecessary change
92bf993
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
LantaoJin
previously approved these changes
Oct 16, 2025
View reviewed changes
@qianheng-aws
Merge remote-tracking branch 'refs/remotes/origin/main' into fix4571
c51a5a4
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
@yuancu
yuancu
merged commit 0257aa5
into
opensearch-project:mainOct 17, 2025

33 checks passed

@opensearch-trigger-bot
opensearch-trigger-botBot
commented
Oct 20, 2025

Copy link


Copy Markdown

Contributor
The backport to 2.19-dev failed:
The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:
# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4572-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0257aa5d51f044f3287bbaffc83aa72f8960c57c
# Push it to GitHub
git push --set-upstream origin backport/backport-4572-to-2.19-dev
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev
Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4572-to-2.19-dev.
qianheng-aws added a commit
to qianheng-aws/sql
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
Fix push down failure for min/max on derived field (opensearch-projec…
1cb8874
…t#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
mentioned this pull request
Oct 20, 2025
 Merged

qianheng-aws added a commit
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
[Backport 2.19-dev] Fix push down failure for min/max on derived field (
e7caf59
#4572) (#4601)
* Fix push down failure for min/max on derived field (#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* fix IT
Signed-off-by: Heng Qian <qianheng@amazon.com>
---------
Signed-off-by: Heng Qian <qianheng@amazon.com>
@LantaoJinLantaoJin
added
the 
backport-manually
Filed a PR to backport manually.
label
Oct 22, 2025
sandeshkr419 added a commit
to sandeshkr419/sql
that referenced
this pull request
Dec 3, 2025
@sandeshkr419@github-actions
@Swiddis@manasvinibs@opensearch-ci-bot@noCharger@dai-chen@cnoramut@yuancu@opensearch-trigger-bot@ahkcs@penghuo@alexey-temnikov@RileyJergerAmazon@ykmr1224@LantaoJin@songkant-aws@qianheng-aws@xinyual@RyanL1997@peterzhuamazon@vinaykpud@expani@vamsimanohar@ritvibhatt@ishaoxy@mch2
Data fusion changes
6f7fd68
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Co-authored-by: Manasvini B S <manasvis@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Mebsina <cnoramut@gmail.com>
Co-authored-by: Yuanchun Shen <yuanchu@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kai Huang <105710027+ahkcs@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Co-authored-by: Riley Jerger <214163063+RileyJergerAmazon@users.noreply.github.com>
Co-authored-by: Tomoyuki MORITA <moritato@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
Co-authored-by: qianheng <qianheng@amazon.com>
Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
Co-authored-by: Xinyuan Lu <xinyual@amazon.com>
Co-authored-by: Jialiang Liang <jiallian@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Co-authored-by: expani <anijainc@amazon.com>
Co-authored-by: expani1729 <110471048+expani@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Co-authored-by: Xinyu Hao <75524174+ishaoxy@users.noreply.github.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Fix join type ambiguous issue when specify the join type with sql-like join criteria (opensearch-project#4474)
Fix issue 4441 (opensearch-project#4449)
Fix missing keywordsCanBeId (opensearch-project#4491)
Fix the bug of explicit makeNullLiteral for UDT fields (opensearch-project#4475)
Fix mapping after aggregation push down (opensearch-project#4500)
Fix percentile bug (opensearch-project#4539)
Fix JsonExtractAllFunctionIT failure (opensearch-project#4556)
Fix sort push down into agg after project already pushed (opensearch-project#4546)
Fix push down failure for min/max on derived field (opensearch-project#4572)
Fix compile issue in main (opensearch-project#4608)
Fix filter parsing failure on date fields with non-default format (opensearch-project#4616)
Fix bin nested fields issue (opensearch-project#4606)
Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
fix rename issue (opensearch-project#4670)
Fixes for `Multisearch` and `Append` command (opensearch-project#4512)
Fix asc/desc keyword behavior for sort command (opensearch-project#4651)
Fix] Fix unexpected shift of extraction for `rex` with nested capture groups in named groups (opensearch-project#4641)
Fix CVE-2025-48924 (opensearch-project#4665)
Fix sub-fields accessing of generated structs (opensearch-project#4683)
Fix] Incorrect Field Index Mapping in AVG to SUM/COUNT Conversion (opensearch-project#15)
@qianheng-aws
qianheng-aws
deleted the

fix4571

branch
March 26, 2026 10:06
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@LantaoJinLantaoJinLantaoJin approved these changes
@yuancuyuancuyuancu approved these changes
@ps48ps48Awaiting requested review from ps48ps48 is a code owner
@kavithacmkavithacmAwaiting requested review from kavithacm
@derek-hoderek-hoAwaiting requested review from derek-ho
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen is a code owner
@YANG-DBYANG-DBAwaiting requested review from YANG-DB
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo is a code owner
@seankao-azseankao-azAwaiting requested review from seankao-az
@MaxKsyunzMaxKsyunzAwaiting requested review from MaxKsyunz
@Yury-FridlyandYury-FridlyandAwaiting requested review from Yury-Fridlyand
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha is a code owner
@forestmveyforestmveyAwaiting requested review from forestmvey
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto is a code owner
@GumpacGGumpacGAwaiting requested review from GumpacG
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 is a code owner

Assignees


No one assigned


Labels

backport 2.19-devbackport-failedbackport-manuallyFiled a PR to backport manually.bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Min/Max on derived fields cannot be pushed down


3 participants

@qianheng-aws@LantaoJin@yuancu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix push down failure for min/max on derived field - #4572
Merged
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Oct 17, 2025
Merged
Fix push down failure for min/max on derived field#4572
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Conversation
@qianheng-aws
@qianheng-awsqianheng-aws
commented
Oct 15, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
Fix push down failure for min/max on derived field
#4281 introduced below code for MIN/MAX in AggregateAnalyzer::createRegularAggregation
 String fieldName = helper.inferNamedField(args.getFirst()).getRootName();
ExprType fieldType = helper.fieldTypes.get(fieldName);

which will throw NPE for derived fields, and then fails to push dow the agg.
Related Issues
Resolves#4571, #4460
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@qianheng-aws
Fix push down failure for min/max on derived field
15dbd78
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
added
the 
bug
Something isn't working
label
Oct 15, 2025
@qianheng-aws
Revert unnecessary change
92bf993
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
LantaoJin
previously approved these changes
Oct 16, 2025
View reviewed changes
@qianheng-aws
Merge remote-tracking branch 'refs/remotes/origin/main' into fix4571
c51a5a4
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
@yuancu
yuancu
merged commit 0257aa5
into
opensearch-project:mainOct 17, 2025

33 checks passed

@opensearch-trigger-bot
opensearch-trigger-botBot
commented
Oct 20, 2025

Copy link


Copy Markdown

Contributor
The backport to 2.19-dev failed:
The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:
# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4572-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0257aa5d51f044f3287bbaffc83aa72f8960c57c
# Push it to GitHub
git push --set-upstream origin backport/backport-4572-to-2.19-dev
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev
Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4572-to-2.19-dev.
qianheng-aws added a commit
to qianheng-aws/sql
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
Fix push down failure for min/max on derived field (opensearch-projec…
1cb8874
…t#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
mentioned this pull request
Oct 20, 2025
 Merged

qianheng-aws added a commit
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
[Backport 2.19-dev] Fix push down failure for min/max on derived field (
e7caf59
#4572) (#4601)
* Fix push down failure for min/max on derived field (#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* fix IT
Signed-off-by: Heng Qian <qianheng@amazon.com>
---------
Signed-off-by: Heng Qian <qianheng@amazon.com>
@LantaoJinLantaoJin
added
the 
backport-manually
Filed a PR to backport manually.
label
Oct 22, 2025
sandeshkr419 added a commit
to sandeshkr419/sql
that referenced
this pull request
Dec 3, 2025
@sandeshkr419@github-actions
@Swiddis@manasvinibs@opensearch-ci-bot@noCharger@dai-chen@cnoramut@yuancu@opensearch-trigger-bot@ahkcs@penghuo@alexey-temnikov@RileyJergerAmazon@ykmr1224@LantaoJin@songkant-aws@qianheng-aws@xinyual@RyanL1997@peterzhuamazon@vinaykpud@expani@vamsimanohar@ritvibhatt@ishaoxy@mch2
Data fusion changes
6f7fd68
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Co-authored-by: Manasvini B S <manasvis@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Mebsina <cnoramut@gmail.com>
Co-authored-by: Yuanchun Shen <yuanchu@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kai Huang <105710027+ahkcs@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Co-authored-by: Riley Jerger <214163063+RileyJergerAmazon@users.noreply.github.com>
Co-authored-by: Tomoyuki MORITA <moritato@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
Co-authored-by: qianheng <qianheng@amazon.com>
Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
Co-authored-by: Xinyuan Lu <xinyual@amazon.com>
Co-authored-by: Jialiang Liang <jiallian@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Co-authored-by: expani <anijainc@amazon.com>
Co-authored-by: expani1729 <110471048+expani@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Co-authored-by: Xinyu Hao <75524174+ishaoxy@users.noreply.github.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Fix join type ambiguous issue when specify the join type with sql-like join criteria (opensearch-project#4474)
Fix issue 4441 (opensearch-project#4449)
Fix missing keywordsCanBeId (opensearch-project#4491)
Fix the bug of explicit makeNullLiteral for UDT fields (opensearch-project#4475)
Fix mapping after aggregation push down (opensearch-project#4500)
Fix percentile bug (opensearch-project#4539)
Fix JsonExtractAllFunctionIT failure (opensearch-project#4556)
Fix sort push down into agg after project already pushed (opensearch-project#4546)
Fix push down failure for min/max on derived field (opensearch-project#4572)
Fix compile issue in main (opensearch-project#4608)
Fix filter parsing failure on date fields with non-default format (opensearch-project#4616)
Fix bin nested fields issue (opensearch-project#4606)
Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
fix rename issue (opensearch-project#4670)
Fixes for `Multisearch` and `Append` command (opensearch-project#4512)
Fix asc/desc keyword behavior for sort command (opensearch-project#4651)
Fix] Fix unexpected shift of extraction for `rex` with nested capture groups in named groups (opensearch-project#4641)
Fix CVE-2025-48924 (opensearch-project#4665)
Fix sub-fields accessing of generated structs (opensearch-project#4683)
Fix] Incorrect Field Index Mapping in AVG to SUM/COUNT Conversion (opensearch-project#15)
@qianheng-aws
qianheng-aws
deleted the

fix4571

branch
March 26, 2026 10:06
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@LantaoJinLantaoJinLantaoJin approved these changes
@yuancuyuancuyuancu approved these changes
@ps48ps48Awaiting requested review from ps48ps48 is a code owner
@kavithacmkavithacmAwaiting requested review from kavithacm
@derek-hoderek-hoAwaiting requested review from derek-ho
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen is a code owner
@YANG-DBYANG-DBAwaiting requested review from YANG-DB
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo is a code owner
@seankao-azseankao-azAwaiting requested review from seankao-az
@MaxKsyunzMaxKsyunzAwaiting requested review from MaxKsyunz
@Yury-FridlyandYury-FridlyandAwaiting requested review from Yury-Fridlyand
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha is a code owner
@forestmveyforestmveyAwaiting requested review from forestmvey
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto is a code owner
@GumpacGGumpacGAwaiting requested review from GumpacG
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 is a code owner

Assignees


No one assigned


Labels

backport 2.19-devbackport-failedbackport-manuallyFiled a PR to backport manually.bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Min/Max on derived fields cannot be pushed down


3 participants

@qianheng-aws@LantaoJin@yuancu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix push down failure for min/max on derived field - #4572
Merged
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Oct 17, 2025
Merged
Fix push down failure for min/max on derived field#4572
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Conversation
@qianheng-aws
@qianheng-awsqianheng-aws
commented
Oct 15, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
Fix push down failure for min/max on derived field
#4281 introduced below code for MIN/MAX in AggregateAnalyzer::createRegularAggregation
 String fieldName = helper.inferNamedField(args.getFirst()).getRootName();
ExprType fieldType = helper.fieldTypes.get(fieldName);

which will throw NPE for derived fields, and then fails to push dow the agg.
Related Issues
Resolves#4571, #4460
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@qianheng-aws
Fix push down failure for min/max on derived field
15dbd78
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
added
the 
bug
Something isn't working
label
Oct 15, 2025
@qianheng-aws
Revert unnecessary change
92bf993
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
LantaoJin
previously approved these changes
Oct 16, 2025
View reviewed changes
@qianheng-aws
Merge remote-tracking branch 'refs/remotes/origin/main' into fix4571
c51a5a4
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
@yuancu
yuancu
merged commit 0257aa5
into
opensearch-project:mainOct 17, 2025

33 checks passed

@opensearch-trigger-bot
opensearch-trigger-botBot
commented
Oct 20, 2025

Copy link


Copy Markdown

Contributor
The backport to 2.19-dev failed:
The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:
# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4572-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0257aa5d51f044f3287bbaffc83aa72f8960c57c
# Push it to GitHub
git push --set-upstream origin backport/backport-4572-to-2.19-dev
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev
Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4572-to-2.19-dev.
qianheng-aws added a commit
to qianheng-aws/sql
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
Fix push down failure for min/max on derived field (opensearch-projec…
1cb8874
…t#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
mentioned this pull request
Oct 20, 2025
 Merged

qianheng-aws added a commit
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
[Backport 2.19-dev] Fix push down failure for min/max on derived field (
e7caf59
#4572) (#4601)
* Fix push down failure for min/max on derived field (#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* fix IT
Signed-off-by: Heng Qian <qianheng@amazon.com>
---------
Signed-off-by: Heng Qian <qianheng@amazon.com>
@LantaoJinLantaoJin
added
the 
backport-manually
Filed a PR to backport manually.
label
Oct 22, 2025
sandeshkr419 added a commit
to sandeshkr419/sql
that referenced
this pull request
Dec 3, 2025
@sandeshkr419@github-actions
@Swiddis@manasvinibs@opensearch-ci-bot@noCharger@dai-chen@cnoramut@yuancu@opensearch-trigger-bot@ahkcs@penghuo@alexey-temnikov@RileyJergerAmazon@ykmr1224@LantaoJin@songkant-aws@qianheng-aws@xinyual@RyanL1997@peterzhuamazon@vinaykpud@expani@vamsimanohar@ritvibhatt@ishaoxy@mch2
Data fusion changes
6f7fd68
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Co-authored-by: Manasvini B S <manasvis@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Mebsina <cnoramut@gmail.com>
Co-authored-by: Yuanchun Shen <yuanchu@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kai Huang <105710027+ahkcs@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Co-authored-by: Riley Jerger <214163063+RileyJergerAmazon@users.noreply.github.com>
Co-authored-by: Tomoyuki MORITA <moritato@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
Co-authored-by: qianheng <qianheng@amazon.com>
Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
Co-authored-by: Xinyuan Lu <xinyual@amazon.com>
Co-authored-by: Jialiang Liang <jiallian@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Co-authored-by: expani <anijainc@amazon.com>
Co-authored-by: expani1729 <110471048+expani@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Co-authored-by: Xinyu Hao <75524174+ishaoxy@users.noreply.github.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Fix join type ambiguous issue when specify the join type with sql-like join criteria (opensearch-project#4474)
Fix issue 4441 (opensearch-project#4449)
Fix missing keywordsCanBeId (opensearch-project#4491)
Fix the bug of explicit makeNullLiteral for UDT fields (opensearch-project#4475)
Fix mapping after aggregation push down (opensearch-project#4500)
Fix percentile bug (opensearch-project#4539)
Fix JsonExtractAllFunctionIT failure (opensearch-project#4556)
Fix sort push down into agg after project already pushed (opensearch-project#4546)
Fix push down failure for min/max on derived field (opensearch-project#4572)
Fix compile issue in main (opensearch-project#4608)
Fix filter parsing failure on date fields with non-default format (opensearch-project#4616)
Fix bin nested fields issue (opensearch-project#4606)
Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
fix rename issue (opensearch-project#4670)
Fixes for `Multisearch` and `Append` command (opensearch-project#4512)
Fix asc/desc keyword behavior for sort command (opensearch-project#4651)
Fix] Fix unexpected shift of extraction for `rex` with nested capture groups in named groups (opensearch-project#4641)
Fix CVE-2025-48924 (opensearch-project#4665)
Fix sub-fields accessing of generated structs (opensearch-project#4683)
Fix] Incorrect Field Index Mapping in AVG to SUM/COUNT Conversion (opensearch-project#15)
@qianheng-aws
qianheng-aws
deleted the

fix4571

branch
March 26, 2026 10:06
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@LantaoJinLantaoJinLantaoJin approved these changes
@yuancuyuancuyuancu approved these changes
@ps48ps48Awaiting requested review from ps48ps48 is a code owner
@kavithacmkavithacmAwaiting requested review from kavithacm
@derek-hoderek-hoAwaiting requested review from derek-ho
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen is a code owner
@YANG-DBYANG-DBAwaiting requested review from YANG-DB
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo is a code owner
@seankao-azseankao-azAwaiting requested review from seankao-az
@MaxKsyunzMaxKsyunzAwaiting requested review from MaxKsyunz
@Yury-FridlyandYury-FridlyandAwaiting requested review from Yury-Fridlyand
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha is a code owner
@forestmveyforestmveyAwaiting requested review from forestmvey
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto is a code owner
@GumpacGGumpacGAwaiting requested review from GumpacG
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 is a code owner

Assignees


No one assigned


Labels

backport 2.19-devbackport-failedbackport-manuallyFiled a PR to backport manually.bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Min/Max on derived fields cannot be pushed down


3 participants

@qianheng-aws@LantaoJin@yuancu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix push down failure for min/max on derived field - #4572
Merged
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Oct 17, 2025
Merged
Fix push down failure for min/max on derived field#4572
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Conversation
@qianheng-aws
@qianheng-awsqianheng-aws
commented
Oct 15, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
Fix push down failure for min/max on derived field
#4281 introduced below code for MIN/MAX in AggregateAnalyzer::createRegularAggregation
 String fieldName = helper.inferNamedField(args.getFirst()).getRootName();
ExprType fieldType = helper.fieldTypes.get(fieldName);

which will throw NPE for derived fields, and then fails to push dow the agg.
Related Issues
Resolves#4571, #4460
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@qianheng-aws
Fix push down failure for min/max on derived field
15dbd78
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
added
the 
bug
Something isn't working
label
Oct 15, 2025
@qianheng-aws
Revert unnecessary change
92bf993
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
LantaoJin
previously approved these changes
Oct 16, 2025
View reviewed changes
@qianheng-aws
Merge remote-tracking branch 'refs/remotes/origin/main' into fix4571
c51a5a4
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
@yuancu
yuancu
merged commit 0257aa5
into
opensearch-project:mainOct 17, 2025

33 checks passed

@opensearch-trigger-bot
opensearch-trigger-botBot
commented
Oct 20, 2025

Copy link


Copy Markdown

Contributor
The backport to 2.19-dev failed:
The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:
# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4572-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0257aa5d51f044f3287bbaffc83aa72f8960c57c
# Push it to GitHub
git push --set-upstream origin backport/backport-4572-to-2.19-dev
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev
Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4572-to-2.19-dev.
qianheng-aws added a commit
to qianheng-aws/sql
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
Fix push down failure for min/max on derived field (opensearch-projec…
1cb8874
…t#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
mentioned this pull request
Oct 20, 2025
 Merged

qianheng-aws added a commit
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
[Backport 2.19-dev] Fix push down failure for min/max on derived field (
e7caf59
#4572) (#4601)
* Fix push down failure for min/max on derived field (#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* fix IT
Signed-off-by: Heng Qian <qianheng@amazon.com>
---------
Signed-off-by: Heng Qian <qianheng@amazon.com>
@LantaoJinLantaoJin
added
the 
backport-manually
Filed a PR to backport manually.
label
Oct 22, 2025
sandeshkr419 added a commit
to sandeshkr419/sql
that referenced
this pull request
Dec 3, 2025
@sandeshkr419@github-actions
@Swiddis@manasvinibs@opensearch-ci-bot@noCharger@dai-chen@cnoramut@yuancu@opensearch-trigger-bot@ahkcs@penghuo@alexey-temnikov@RileyJergerAmazon@ykmr1224@LantaoJin@songkant-aws@qianheng-aws@xinyual@RyanL1997@peterzhuamazon@vinaykpud@expani@vamsimanohar@ritvibhatt@ishaoxy@mch2
Data fusion changes
6f7fd68
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Co-authored-by: Manasvini B S <manasvis@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Mebsina <cnoramut@gmail.com>
Co-authored-by: Yuanchun Shen <yuanchu@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kai Huang <105710027+ahkcs@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Co-authored-by: Riley Jerger <214163063+RileyJergerAmazon@users.noreply.github.com>
Co-authored-by: Tomoyuki MORITA <moritato@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
Co-authored-by: qianheng <qianheng@amazon.com>
Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
Co-authored-by: Xinyuan Lu <xinyual@amazon.com>
Co-authored-by: Jialiang Liang <jiallian@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Co-authored-by: expani <anijainc@amazon.com>
Co-authored-by: expani1729 <110471048+expani@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Co-authored-by: Xinyu Hao <75524174+ishaoxy@users.noreply.github.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Fix join type ambiguous issue when specify the join type with sql-like join criteria (opensearch-project#4474)
Fix issue 4441 (opensearch-project#4449)
Fix missing keywordsCanBeId (opensearch-project#4491)
Fix the bug of explicit makeNullLiteral for UDT fields (opensearch-project#4475)
Fix mapping after aggregation push down (opensearch-project#4500)
Fix percentile bug (opensearch-project#4539)
Fix JsonExtractAllFunctionIT failure (opensearch-project#4556)
Fix sort push down into agg after project already pushed (opensearch-project#4546)
Fix push down failure for min/max on derived field (opensearch-project#4572)
Fix compile issue in main (opensearch-project#4608)
Fix filter parsing failure on date fields with non-default format (opensearch-project#4616)
Fix bin nested fields issue (opensearch-project#4606)
Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
fix rename issue (opensearch-project#4670)
Fixes for `Multisearch` and `Append` command (opensearch-project#4512)
Fix asc/desc keyword behavior for sort command (opensearch-project#4651)
Fix] Fix unexpected shift of extraction for `rex` with nested capture groups in named groups (opensearch-project#4641)
Fix CVE-2025-48924 (opensearch-project#4665)
Fix sub-fields accessing of generated structs (opensearch-project#4683)
Fix] Incorrect Field Index Mapping in AVG to SUM/COUNT Conversion (opensearch-project#15)
@qianheng-aws
qianheng-aws
deleted the

fix4571

branch
March 26, 2026 10:06
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@LantaoJinLantaoJinLantaoJin approved these changes
@yuancuyuancuyuancu approved these changes
@ps48ps48Awaiting requested review from ps48ps48 is a code owner
@kavithacmkavithacmAwaiting requested review from kavithacm
@derek-hoderek-hoAwaiting requested review from derek-ho
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen is a code owner
@YANG-DBYANG-DBAwaiting requested review from YANG-DB
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo is a code owner
@seankao-azseankao-azAwaiting requested review from seankao-az
@MaxKsyunzMaxKsyunzAwaiting requested review from MaxKsyunz
@Yury-FridlyandYury-FridlyandAwaiting requested review from Yury-Fridlyand
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha is a code owner
@forestmveyforestmveyAwaiting requested review from forestmvey
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto is a code owner
@GumpacGGumpacGAwaiting requested review from GumpacG
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 is a code owner

Assignees


No one assigned


Labels

backport 2.19-devbackport-failedbackport-manuallyFiled a PR to backport manually.bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Min/Max on derived fields cannot be pushed down


3 participants

@qianheng-aws@LantaoJin@yuancu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix push down failure for min/max on derived field - #4572
Merged
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Oct 17, 2025
Merged
Fix push down failure for min/max on derived field#4572
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Conversation
@qianheng-aws
@qianheng-awsqianheng-aws
commented
Oct 15, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
Fix push down failure for min/max on derived field
#4281 introduced below code for MIN/MAX in AggregateAnalyzer::createRegularAggregation
 String fieldName = helper.inferNamedField(args.getFirst()).getRootName();
ExprType fieldType = helper.fieldTypes.get(fieldName);

which will throw NPE for derived fields, and then fails to push dow the agg.
Related Issues
Resolves#4571, #4460
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@qianheng-aws
Fix push down failure for min/max on derived field
15dbd78
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
added
the 
bug
Something isn't working
label
Oct 15, 2025
@qianheng-aws
Revert unnecessary change
92bf993
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
LantaoJin
previously approved these changes
Oct 16, 2025
View reviewed changes
@qianheng-aws
Merge remote-tracking branch 'refs/remotes/origin/main' into fix4571
c51a5a4
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
@yuancu
yuancu
merged commit 0257aa5
into
opensearch-project:mainOct 17, 2025

33 checks passed

@opensearch-trigger-bot
opensearch-trigger-botBot
commented
Oct 20, 2025

Copy link


Copy Markdown

Contributor
The backport to 2.19-dev failed:
The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:
# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4572-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0257aa5d51f044f3287bbaffc83aa72f8960c57c
# Push it to GitHub
git push --set-upstream origin backport/backport-4572-to-2.19-dev
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev
Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4572-to-2.19-dev.
qianheng-aws added a commit
to qianheng-aws/sql
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
Fix push down failure for min/max on derived field (opensearch-projec…
1cb8874
…t#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
mentioned this pull request
Oct 20, 2025
 Merged

qianheng-aws added a commit
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
[Backport 2.19-dev] Fix push down failure for min/max on derived field (
e7caf59
#4572) (#4601)
* Fix push down failure for min/max on derived field (#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* fix IT
Signed-off-by: Heng Qian <qianheng@amazon.com>
---------
Signed-off-by: Heng Qian <qianheng@amazon.com>
@LantaoJinLantaoJin
added
the 
backport-manually
Filed a PR to backport manually.
label
Oct 22, 2025
sandeshkr419 added a commit
to sandeshkr419/sql
that referenced
this pull request
Dec 3, 2025
@sandeshkr419@github-actions
@Swiddis@manasvinibs@opensearch-ci-bot@noCharger@dai-chen@cnoramut@yuancu@opensearch-trigger-bot@ahkcs@penghuo@alexey-temnikov@RileyJergerAmazon@ykmr1224@LantaoJin@songkant-aws@qianheng-aws@xinyual@RyanL1997@peterzhuamazon@vinaykpud@expani@vamsimanohar@ritvibhatt@ishaoxy@mch2
Data fusion changes
6f7fd68
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Co-authored-by: Manasvini B S <manasvis@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Mebsina <cnoramut@gmail.com>
Co-authored-by: Yuanchun Shen <yuanchu@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kai Huang <105710027+ahkcs@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Co-authored-by: Riley Jerger <214163063+RileyJergerAmazon@users.noreply.github.com>
Co-authored-by: Tomoyuki MORITA <moritato@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
Co-authored-by: qianheng <qianheng@amazon.com>
Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
Co-authored-by: Xinyuan Lu <xinyual@amazon.com>
Co-authored-by: Jialiang Liang <jiallian@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Co-authored-by: expani <anijainc@amazon.com>
Co-authored-by: expani1729 <110471048+expani@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Co-authored-by: Xinyu Hao <75524174+ishaoxy@users.noreply.github.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Fix join type ambiguous issue when specify the join type with sql-like join criteria (opensearch-project#4474)
Fix issue 4441 (opensearch-project#4449)
Fix missing keywordsCanBeId (opensearch-project#4491)
Fix the bug of explicit makeNullLiteral for UDT fields (opensearch-project#4475)
Fix mapping after aggregation push down (opensearch-project#4500)
Fix percentile bug (opensearch-project#4539)
Fix JsonExtractAllFunctionIT failure (opensearch-project#4556)
Fix sort push down into agg after project already pushed (opensearch-project#4546)
Fix push down failure for min/max on derived field (opensearch-project#4572)
Fix compile issue in main (opensearch-project#4608)
Fix filter parsing failure on date fields with non-default format (opensearch-project#4616)
Fix bin nested fields issue (opensearch-project#4606)
Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
fix rename issue (opensearch-project#4670)
Fixes for `Multisearch` and `Append` command (opensearch-project#4512)
Fix asc/desc keyword behavior for sort command (opensearch-project#4651)
Fix] Fix unexpected shift of extraction for `rex` with nested capture groups in named groups (opensearch-project#4641)
Fix CVE-2025-48924 (opensearch-project#4665)
Fix sub-fields accessing of generated structs (opensearch-project#4683)
Fix] Incorrect Field Index Mapping in AVG to SUM/COUNT Conversion (opensearch-project#15)
@qianheng-aws
qianheng-aws
deleted the

fix4571

branch
March 26, 2026 10:06
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@LantaoJinLantaoJinLantaoJin approved these changes
@yuancuyuancuyuancu approved these changes
@ps48ps48Awaiting requested review from ps48ps48 is a code owner
@kavithacmkavithacmAwaiting requested review from kavithacm
@derek-hoderek-hoAwaiting requested review from derek-ho
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen is a code owner
@YANG-DBYANG-DBAwaiting requested review from YANG-DB
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo is a code owner
@seankao-azseankao-azAwaiting requested review from seankao-az
@MaxKsyunzMaxKsyunzAwaiting requested review from MaxKsyunz
@Yury-FridlyandYury-FridlyandAwaiting requested review from Yury-Fridlyand
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha is a code owner
@forestmveyforestmveyAwaiting requested review from forestmvey
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto is a code owner
@GumpacGGumpacGAwaiting requested review from GumpacG
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 is a code owner

Assignees


No one assigned


Labels

backport 2.19-devbackport-failedbackport-manuallyFiled a PR to backport manually.bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Min/Max on derived fields cannot be pushed down


3 participants

@qianheng-aws@LantaoJin@yuancu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix push down failure for min/max on derived field - #4572
Merged
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Oct 17, 2025
Merged
Fix push down failure for min/max on derived field#4572
yuancu merged 3 commits into
opensearch-project:mainfrom 
qianheng-aws:fix4571
Conversation
@qianheng-aws
@qianheng-awsqianheng-aws
commented
Oct 15, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
Fix push down failure for min/max on derived field
#4281 introduced below code for MIN/MAX in AggregateAnalyzer::createRegularAggregation
 String fieldName = helper.inferNamedField(args.getFirst()).getRootName();
ExprType fieldType = helper.fieldTypes.get(fieldName);

which will throw NPE for derived fields, and then fails to push dow the agg.
Related Issues
Resolves#4571, #4460
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@qianheng-aws
Fix push down failure for min/max on derived field
15dbd78
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
added
the 
bug
Something isn't working
label
Oct 15, 2025
@qianheng-aws
Revert unnecessary change
92bf993
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
LantaoJin
previously approved these changes
Oct 16, 2025
View reviewed changes
@qianheng-aws
Merge remote-tracking branch 'refs/remotes/origin/main' into fix4571
c51a5a4
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
@yuancu
yuancu
merged commit 0257aa5
into
opensearch-project:mainOct 17, 2025

33 checks passed

@opensearch-trigger-bot
opensearch-trigger-botBot
commented
Oct 20, 2025

Copy link


Copy Markdown

Contributor
The backport to 2.19-dev failed:
The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:
# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4572-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0257aa5d51f044f3287bbaffc83aa72f8960c57c
# Push it to GitHub
git push --set-upstream origin backport/backport-4572-to-2.19-dev
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev
Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4572-to-2.19-dev.
qianheng-aws added a commit
to qianheng-aws/sql
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
Fix push down failure for min/max on derived field (opensearch-projec…
1cb8874
…t#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-awsqianheng-aws
mentioned this pull request
Oct 20, 2025
 Merged

qianheng-aws added a commit
that referenced
this pull request
Oct 20, 2025
@qianheng-aws
[Backport 2.19-dev] Fix push down failure for min/max on derived field (
e7caf59
#4572) (#4601)
* Fix push down failure for min/max on derived field (#4572)
(cherry picked from commit 0257aa5)
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Fix compiling
Signed-off-by: Heng Qian <qianheng@amazon.com>
* fix IT
Signed-off-by: Heng Qian <qianheng@amazon.com>
---------
Signed-off-by: Heng Qian <qianheng@amazon.com>
@LantaoJinLantaoJin
added
the 
backport-manually
Filed a PR to backport manually.
label
Oct 22, 2025
sandeshkr419 added a commit
to sandeshkr419/sql
that referenced
this pull request
Dec 3, 2025
@sandeshkr419@github-actions
@Swiddis@manasvinibs@opensearch-ci-bot@noCharger@dai-chen@cnoramut@yuancu@opensearch-trigger-bot@ahkcs@penghuo@alexey-temnikov@RileyJergerAmazon@ykmr1224@LantaoJin@songkant-aws@qianheng-aws@xinyual@RyanL1997@peterzhuamazon@vinaykpud@expani@vamsimanohar@ritvibhatt@ishaoxy@mch2
Data fusion changes
6f7fd68
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Co-authored-by: Manasvini B S <manasvis@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Mebsina <cnoramut@gmail.com>
Co-authored-by: Yuanchun Shen <yuanchu@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kai Huang <105710027+ahkcs@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Co-authored-by: Riley Jerger <214163063+RileyJergerAmazon@users.noreply.github.com>
Co-authored-by: Tomoyuki MORITA <moritato@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
Co-authored-by: qianheng <qianheng@amazon.com>
Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
Co-authored-by: Xinyuan Lu <xinyual@amazon.com>
Co-authored-by: Jialiang Liang <jiallian@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Co-authored-by: expani <anijainc@amazon.com>
Co-authored-by: expani1729 <110471048+expani@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Co-authored-by: Xinyu Hao <75524174+ishaoxy@users.noreply.github.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Fix join type ambiguous issue when specify the join type with sql-like join criteria (opensearch-project#4474)
Fix issue 4441 (opensearch-project#4449)
Fix missing keywordsCanBeId (opensearch-project#4491)
Fix the bug of explicit makeNullLiteral for UDT fields (opensearch-project#4475)
Fix mapping after aggregation push down (opensearch-project#4500)
Fix percentile bug (opensearch-project#4539)
Fix JsonExtractAllFunctionIT failure (opensearch-project#4556)
Fix sort push down into agg after project already pushed (opensearch-project#4546)
Fix push down failure for min/max on derived field (opensearch-project#4572)
Fix compile issue in main (opensearch-project#4608)
Fix filter parsing failure on date fields with non-default format (opensearch-project#4616)
Fix bin nested fields issue (opensearch-project#4606)
Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
fix rename issue (opensearch-project#4670)
Fixes for `Multisearch` and `Append` command (opensearch-project#4512)
Fix asc/desc keyword behavior for sort command (opensearch-project#4651)
Fix] Fix unexpected shift of extraction for `rex` with nested capture groups in named groups (opensearch-project#4641)
Fix CVE-2025-48924 (opensearch-project#4665)
Fix sub-fields accessing of generated structs (opensearch-project#4683)
Fix] Incorrect Field Index Mapping in AVG to SUM/COUNT Conversion (opensearch-project#15)
@qianheng-aws
qianheng-aws
deleted the

fix4571

branch
March 26, 2026 10:06
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@LantaoJinLantaoJinLantaoJin approved these changes
@yuancuyuancuyuancu approved these changes
@ps48ps48Awaiting requested review from ps48ps48 is a code owner
@kavithacmkavithacmAwaiting requested review from kavithacm
@derek-hoderek-hoAwaiting requested review from derek-ho
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen is a code owner
@YANG-DBYANG-DBAwaiting requested review from YANG-DB
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo is a code owner
@seankao-azseankao-azAwaiting requested review from seankao-az
@MaxKsyunzMaxKsyunzAwaiting requested review from MaxKsyunz
@Yury-FridlyandYury-FridlyandAwaiting requested review from Yury-Fridlyand
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha is a code owner
@forestmveyforestmveyAwaiting requested review from forestmvey
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto is a code owner
@GumpacGGumpacGAwaiting requested review from GumpacG
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 is a code owner

Assignees


No one assigned


Labels

backport 2.19-devbackport-failedbackport-manuallyFiled a PR to backport manually.bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Min/Max on derived fields cannot be pushed down


3 participants

@qianheng-aws@LantaoJin@yuancu