Uh oh!
There was an error while loading. Please reload this page.
Support appendpipecommand in PPL - #4602
Merged
Merged
Conversation
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
xinyual
marked this pull request as ready for review
October 23, 2025 05:28
xinyual
requested review from
YANG-DB, dai-chen, derek-ho, joshuali925, kavithacm and ps48
as code ownersOctober 23, 2025 05:28
xinyual
requested review from
RyanL1997, noCharger, qianheng-aws and yuancu
as code ownersOctober 23, 2025 05:28
appendpipecommand in PPLappendpipecommand in PPLSwiddis
previously approved these changes
Oct 31, 2025
yuancu
reviewed
Nov 3, 2025
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: xinyual <xinyual@amazon.com>
xinyual
commented
Nov 5, 2025
ContributorAuthor
@Swiddis could you please approve again? |
| while (childNode.getChild() != null | ||
| && !childNode.getChild().isEmpty() | ||
| && !(childNode.getChild().getFirst() instanceof Values)) { | ||
| childNode = (UnresolvedPlan) childNode.getChild().getFirst(); |
Collaborator
There was a problem hiding this comment.
Will there be more than 1 children in the subquery? Maybe adding assertion and throw exception to avoid this case if we don't support.
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
qianheng-aws
approved these changes
Nov 12, 2025
yuancu
approved these changes
Nov 12, 2025
Uh oh!
There was an error while loading. Please reload this page.
opensearch-trigger-botBot
pushed a commit
that referenced
this pull request
Nov 12, 2025
* add demos Signed-off-by: xinyual <xinyual@amazon.com> * add missing column Signed-off-by: xinyual <xinyual@amazon.com> * add appendpipe poc Signed-off-by: xinyual <xinyual@amazon.com> * slighty change syntax Signed-off-by: xinyual <xinyual@amazon.com> * add unresolved plan Signed-off-by: xinyual <xinyual@amazon.com> * add IT Signed-off-by: xinyual <xinyual@amazon.com> * add tests Signed-off-by: xinyual <xinyual@amazon.com> * remove useless ut Signed-off-by: xinyual <xinyual@amazon.com> * fix conflict Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * remove useless chaneg Signed-off-by: xinyual <xinyual@amazon.com> * add explain IT Signed-off-by: xinyual <xinyual@amazon.com> * fix IT Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * add doc Signed-off-by: xinyual <xinyual@amazon.com> * optimize doc Signed-off-by: xinyual <xinyual@amazon.com> * add UT Signed-off-by: xinyual <xinyual@amazon.com> * fix IT due to performance change Signed-off-by: xinyual <xinyual@amazon.com> * add multiply children check Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com> (cherry picked from commit 3a3c8c8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 tasks
LantaoJin pushed a commit
that referenced
this pull request
Nov 12, 2025
* Support `appendpipe`command in PPL (#4602) * add demos Signed-off-by: xinyual <xinyual@amazon.com> * add missing column Signed-off-by: xinyual <xinyual@amazon.com> * add appendpipe poc Signed-off-by: xinyual <xinyual@amazon.com> * slighty change syntax Signed-off-by: xinyual <xinyual@amazon.com> * add unresolved plan Signed-off-by: xinyual <xinyual@amazon.com> * add IT Signed-off-by: xinyual <xinyual@amazon.com> * add tests Signed-off-by: xinyual <xinyual@amazon.com> * remove useless ut Signed-off-by: xinyual <xinyual@amazon.com> * fix conflict Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * remove useless chaneg Signed-off-by: xinyual <xinyual@amazon.com> * add explain IT Signed-off-by: xinyual <xinyual@amazon.com> * fix IT Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * add doc Signed-off-by: xinyual <xinyual@amazon.com> * optimize doc Signed-off-by: xinyual <xinyual@amazon.com> * add UT Signed-off-by: xinyual <xinyual@amazon.com> * fix IT due to performance change Signed-off-by: xinyual <xinyual@amazon.com> * add multiply children check Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com> * avoid to use get first Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com>
asifabashar pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
* add demos Signed-off-by: xinyual <xinyual@amazon.com> * add missing column Signed-off-by: xinyual <xinyual@amazon.com> * add appendpipe poc Signed-off-by: xinyual <xinyual@amazon.com> * slighty change syntax Signed-off-by: xinyual <xinyual@amazon.com> * add unresolved plan Signed-off-by: xinyual <xinyual@amazon.com> * add IT Signed-off-by: xinyual <xinyual@amazon.com> * add tests Signed-off-by: xinyual <xinyual@amazon.com> * remove useless ut Signed-off-by: xinyual <xinyual@amazon.com> * fix conflict Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * remove useless chaneg Signed-off-by: xinyual <xinyual@amazon.com> * add explain IT Signed-off-by: xinyual <xinyual@amazon.com> * fix IT Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * add doc Signed-off-by: xinyual <xinyual@amazon.com> * optimize doc Signed-off-by: xinyual <xinyual@amazon.com> * add UT Signed-off-by: xinyual <xinyual@amazon.com> * fix IT due to performance change Signed-off-by: xinyual <xinyual@amazon.com> * add multiply children check Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add appendpipe command.
Appendpipeappends the result of the subpipeline to the search results. Unlike a subsearch, the subpipeline is not run first. The subpipeline is run when the search reaches the appendpipe command.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.