OCPNODE-3121: Make FeatureGateImageVolume TechPreview by bitoku · Pull Request #2403 · openshift/api

bitoku · 2025-07-15T10:55:50Z

This PR graduates ImageVolume featuregate to TechPreview.

upstream:

VolumeSource: OCI Artifact and/or Image kubernetes/enhancements#4639

downstream:

OCPNODE-2929: proposal of OCI image volume enhancements#1792

openshift-ci-robot · 2025-07-15T10:55:54Z

@bitoku: This pull request references OCPNODE-3121 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This PR graduates ImageVolume featuregate to GA.
upstream:
VolumeSource: OCI Artifact and/or Image kubernetes/enhancements#4639
downstream:
OCPNODE-2929: proposal of OCI image volume enhancements#1792

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-07-15T10:55:55Z

Hello @bitoku! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

JoelSpeed · 2025-07-15T11:26:35Z

This PR graduates ImageVolume featuregate to GA.

Since this is an upstream gate, can you confirm the lifecycle of the gate? When did it get enabled by default in upstream?

bitoku · 2025-07-15T11:33:33Z

@JoelSpeed It's beta and disabled by default right now.
https://github.com/kubernetes/kubernetes/pull/130135/files#diff-530f68e01a51f788bd0ad558bde87a4a378bd3e40e3811d097029f6aa109c7a7

However, our team decided to graduate this feature to GA in 4.20.
https://github.com/openshift/enhancements/blob/master/enhancements/kubelet/oci-image-volume.md#risks-and-mitigations

For OCP, there is a risk to enable the feature gate which is off by default in Kubernetes. The mitigation is:
CRI API is easier to change if needed since it's internal to the implementation
The Kubernetes API for this feature is unlikely to change as it's already in beta and is built on a very stable volume API

JoelSpeed · 2025-07-15T11:45:57Z

I think the first step of getting this feature promoted to GA would be to get it enabled and running in CI in TechPreview clusters. This will allow us to see how it behaves in OpenShift and I assume, run upstream E2E tests to build a baseline for feature regression.

Can we start with tech preview?

Also, you'll need to run the update-payload-featuregates script in the hack directory to have any effect on the payload (this is why verify is failing)

openshift-ci-robot · 2025-07-15T12:02:33Z

@bitoku: This pull request references OCPNODE-3121 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This PR graduates ImageVolume featuregate to TechPreview.
upstream:
VolumeSource: OCI Artifact and/or Image kubernetes/enhancements#4639
downstream:
OCPNODE-2929: proposal of OCI image volume enhancements#1792

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

JoelSpeed

/approve

/assign @haircommander

Peter, are you happy with the plan suggested above of enabling this in TP and gathering test data before we promote?

Also, wanted to check you're ok with the gate being tagged to your handle?

bitoku · 2025-07-15T12:08:56Z

I put Peter because https://github.com/openshift/api?tab=readme-ov-file#adding-new-techpreview-featuregate-to-all-clusterprofiles-hypershift-and-selfmanaged says "my-team-lead".
If it's ok, I don't mind putting myself.

bitoku · 2025-07-15T12:58:33Z

@JoelSpeed

I think the first step of getting this feature promoted to GA would be to get it enabled and running in CI in TechPreview clusters.

You mean make it TechPreview internally and then once we run enough CI to graduate, make it GA for 4.20, right?

haircommander · 2025-07-15T12:59:51Z

TP to gather feedback works for me

/lgtm

openshift-ci · 2025-07-15T13:02:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, haircommander, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bitoku · 2025-07-15T13:16:06Z

/retest

haircommander · 2025-07-16T20:29:36Z

/retest-required

openshift-ci-robot · 2025-07-16T23:46:46Z

/retest-required

Remaining retests: 0 against base HEAD e375905 and 2 for PR HEAD affbfc1 in total

openshift-ci-robot · 2025-07-17T00:40:03Z

/retest-required

Remaining retests: 0 against base HEAD e375905 and 2 for PR HEAD affbfc1 in total

openshift-ci-robot · 2025-07-17T02:34:54Z

/retest-required

Remaining retests: 0 against base HEAD e375905 and 2 for PR HEAD affbfc1 in total

openshift-ci-robot · 2025-07-17T04:31:49Z

/retest-required

Remaining retests: 0 against base HEAD e375905 and 2 for PR HEAD affbfc1 in total

JoelSpeed · 2025-07-17T11:04:19Z

/override ci/prow/minor-e2e-upgrade-minor

Known issue with KAS on upgrades at the moment

/test e2e-aws-serial-techpreview-2of2

openshift-ci · 2025-07-17T11:05:09Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/minor-e2e-upgrade-minor

Details

In response to this:

/override ci/prow/minor-e2e-upgrade-minor
Known issue with KAS on upgrades at the moment
/test e2e-aws-serial-techpreview-2of2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-07-17T15:22:37Z

/retest-required

Remaining retests: 0 against base HEAD 933316e and 2 for PR HEAD affbfc1 in total

openshift-ci-robot · 2025-07-17T23:32:13Z

/retest-required

Remaining retests: 0 against base HEAD ba53b2a and 2 for PR HEAD affbfc1 in total

saschagrunert · 2025-07-18T07:06:31Z

/test e2e-aws-serial-techpreview-2of2

saschagrunert · 2025-07-18T07:06:58Z

/override ci/prow/minor-e2e-upgrade-minor

openshift-ci · 2025-07-18T07:07:10Z

@saschagrunert: saschagrunert unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

Details

In response to this:

/override ci/prow/minor-e2e-upgrade-minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoelSpeed · 2025-07-18T08:46:26Z

/override ci/prow/minor-e2e-upgrade-minor

openshift-ci · 2025-07-18T08:47:21Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/minor-e2e-upgrade-minor

Details

In response to this:

/override ci/prow/minor-e2e-upgrade-minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-07-18T12:32:21Z

/retest-required

Remaining retests: 0 against base HEAD 87ff3fc and 1 for PR HEAD affbfc1 in total

openshift-ci-robot · 2025-07-18T17:32:38Z

/retest-required

Remaining retests: 0 against base HEAD 2562429 and 0 for PR HEAD affbfc1 in total

openshift-ci-robot · 2025-07-18T20:32:20Z

/hold

Revision affbfc1 was retested 3 times: holding

saschagrunert · 2025-07-21T08:11:16Z

/test e2e-aws-serial-techpreview-1of2

Test failures seem not related.

saschagrunert · 2025-07-21T12:04:54Z

/unhold

openshift-ci-robot · 2025-07-21T15:17:35Z

/retest-required

Remaining retests: 0 against base HEAD fed56f2 and 2 for PR HEAD affbfc1 in total

openshift-ci-robot · 2025-07-21T18:17:31Z

/retest-required

Remaining retests: 0 against base HEAD 5205e27 and 1 for PR HEAD affbfc1 in total

openshift-ci-robot · 2025-07-22T00:25:32Z

/retest-required

Remaining retests: 0 against base HEAD 5205e27 and 2 for PR HEAD affbfc1 in total

openshift-ci-robot · 2025-07-22T06:25:35Z

/retest-required

Remaining retests: 0 against base HEAD bc3bc48 and 1 for PR HEAD affbfc1 in total

haircommander · 2025-07-22T13:38:32Z

/retest

openshift-ci · 2025-07-23T03:03:06Z

@bitoku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`affbfc1`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-07-23T03:25:28Z

/retest-required

Remaining retests: 0 against base HEAD 0528f2f and 0 for PR HEAD affbfc1 in total

openshift-bot · 2025-07-23T13:44:58Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202507230546.p0.gc368740.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2025

openshift-ciBot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2025

openshift-ciBot requested review from JoelSpeed and deads2k July 15, 2025 10:56

bitoku changed the title ~~OCPNODE-3121: Enable FeatureGateImageVolume by default.~~WIP: OCPNODE-3121: Enable FeatureGateImageVolume by default.Jul 15, 2025

openshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2025

bitoku force-pushed the image-volume branch from 1b86fef to e9806c5Compare July 15, 2025 11:11

bitoku force-pushed the image-volume branch from e9806c5 to cb1c4f4Compare July 15, 2025 11:52

Enable FeatureGateImageVolume by default.
affbfc1

bitoku force-pushed the image-volume branch from cb1c4f4 to affbfc1Compare July 15, 2025 12:00

bitoku changed the title ~~WIP: OCPNODE-3121: Enable FeatureGateImageVolume by default.~~OCPNODE-3121: Enable FeatureGateImageVolume by default.Jul 15, 2025

openshift-ciBot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2025

bitoku changed the title ~~OCPNODE-3121: Enable FeatureGateImageVolume by default.~~OCPNODE-3121: Make FeatureGateImageVolume TechPreviewJul 15, 2025

JoelSpeed reviewed Jul 15, 2025
View reviewed changes

openshift-ciBot assigned haircommander Jul 15, 2025

openshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2025

openshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025

openshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2025

openshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2025

openshift-merge-botBot merged commit c368740 into openshift:masterJul 23, 2025
27 checks passed

Uh oh!

Conversation

bitoku commented Jul 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 15, 2025• edited by openshift-ci BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ciBot commented Jul 15, 2025

Uh oh!

JoelSpeed commented Jul 15, 2025

Uh oh!

bitoku commented Jul 15, 2025

Uh oh!

JoelSpeed commented Jul 15, 2025

Uh oh!

openshift-ci-robot commented Jul 15, 2025• edited by openshift-ci BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

bitoku commented Jul 15, 2025

Uh oh!

bitoku commented Jul 15, 2025

Uh oh!

haircommander commented Jul 15, 2025

Uh oh!

openshift-ciBot commented Jul 15, 2025

Uh oh!

bitoku commented Jul 15, 2025

Uh oh!

haircommander commented Jul 16, 2025

Uh oh!

openshift-ci-robot commented Jul 16, 2025

Uh oh!

openshift-ci-robot commented Jul 17, 2025

Uh oh!

openshift-ci-robot commented Jul 17, 2025

Uh oh!

openshift-ci-robot commented Jul 17, 2025

Uh oh!

JoelSpeed commented Jul 17, 2025

Uh oh!

openshift-ciBot commented Jul 17, 2025

Uh oh!

openshift-ci-robot commented Jul 17, 2025

Uh oh!

openshift-ci-robot commented Jul 17, 2025

Uh oh!

saschagrunert commented Jul 18, 2025

Uh oh!

saschagrunert commented Jul 18, 2025

Uh oh!

openshift-ciBot commented Jul 18, 2025

Uh oh!

JoelSpeed commented Jul 18, 2025

Uh oh!

openshift-ciBot commented Jul 18, 2025

Uh oh!

openshift-ci-robot commented Jul 18, 2025

Uh oh!

openshift-ci-robot commented Jul 18, 2025

Uh oh!

openshift-ci-robot commented Jul 18, 2025

Uh oh!

saschagrunert commented Jul 21, 2025

Uh oh!

saschagrunert commented Jul 21, 2025

Uh oh!

openshift-ci-robot commented Jul 21, 2025

Uh oh!

openshift-ci-robot commented Jul 21, 2025

Uh oh!

openshift-ci-robot commented Jul 22, 2025

Uh oh!

openshift-ci-robot commented Jul 22, 2025

Uh oh!

haircommander commented Jul 22, 2025

Uh oh!

bitoku commented Jul 15, 2025•
edited
Loading

openshift-ci-robot commented Jul 15, 2025•
edited by openshift-ci Bot
Loading

openshift-ci-robot commented Jul 15, 2025•
edited by openshift-ci Bot
Loading

openshift-ciBot commented Jul 23, 2025•
edited
Loading