OCPNODE-3863: Add CRIOCredentialProviderConfig API by QiWang19 · Pull Request #2557 · openshift/api

QiWang19 · 2025-11-01T03:26:22Z

enhancement: OCPNODE-3753: CRIOCredentialProviderConfig for Namespace-Scoped Mirror Authentication enhancements#1861
Add CRIOCredentialProviderConfig API setting configs https://github.com/cri-o/crio-credential-provider for retrieving mirror pull secrets
Add feature gate for CRIOCredentialProviderConfig feature gate.

openshift-ci · 2025-11-01T03:26:26Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2025-11-01T03:26:27Z

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

QiWang19 · 2025-11-01T04:48:44Z

/retest-required

QiWang19 · 2025-11-03T22:50:14Z

/test integration

QiWang19 · 2025-11-03T23:28:42Z

PR has been reviewed by claude code /api-review. It helped run make lint and correct the failures.

openshift-ci-robot · 2025-11-04T20:33:12Z

@QiWang19: This pull request references OCPNODE-3863 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Add CRIOCredentialProviderConfig API setting configs https://github.com/cri-o/crio-credential-provider for retrieving mirror pull secrets
Add feature gate for CRIOCredentialProviderConfig feature gate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-04T21:15:25Z

@QiWang19: This pull request references OCPNODE-3863 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

enhancement: OCPNODE-3753: CRIOCredentialProviderConfig for Namespace-Scoped Mirror Authentication enhancements#1861
Add CRIOCredentialProviderConfig API setting configs https://github.com/cri-o/crio-credential-provider for retrieving mirror pull secrets
Add feature gate for CRIOCredentialProviderConfig feature gate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

saschagrunert

Two nits, otherwise LGTM

QiWang19 · 2025-11-12T15:41:46Z

/assign @everettraven

openshift-ci-robot · 2026-01-30T11:33:04Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

openshift-ci · 2026-01-30T11:33:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-01-30T12:33:51Z

/retest-required

Remaining retests: 0 against base HEAD c16ec2b and 2 for PR HEAD e73ed72 in total

openshift-ci-robot · 2026-01-30T14:33:15Z

/retest-required

Remaining retests: 0 against base HEAD 71e91db and 1 for PR HEAD e73ed72 in total

QiWang19 · 2026-01-30T18:22:03Z

/retest-required

QiWang19 · 2026-02-02T15:21:53Z

/retest-required

QiWang19 · 2026-02-02T15:22:38Z

/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2

qodo-code-review · 2026-02-02T15:22:44Z

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

QiWang19 · 2026-02-02T18:00:58Z

/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2

qodo-code-review · 2026-02-02T18:01:03Z

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

everettraven · 2026-02-02T18:22:24Z

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-serial-techpreview

openshift-ci · 2026-02-02T18:22:34Z

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/e2e-aws-serial, ci/prow/e2e-aws-serial-techpreview

Details

In response to this:

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-serial-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

QiWang19 · 2026-02-02T22:19:57Z

/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2

qodo-code-review · 2026-02-02T22:20:02Z

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

QiWang19 · 2026-02-03T03:48:26Z

/test e2e-aws-serial-1of2

qodo-code-review · 2026-02-03T03:48:31Z

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

JoelSpeed · 2026-02-03T10:17:04Z

/retest

QiWang19 · 2026-02-03T15:31:59Z

/retest-required

QiWang19 · 2026-02-03T15:44:07Z

/test images

qodo-code-review · 2026-02-03T15:44:13Z

PR-Agent: could not fine a component named images in a supported language in this PR.

QiWang19 · 2026-02-03T15:44:16Z

/test minor-e2e-upgrade-minor

qodo-code-review · 2026-02-03T15:44:22Z

PR-Agent: could not fine a component named minor-e2e-upgrade-minor in a supported language in this PR.

QiWang19 · 2026-02-03T15:44:25Z

/test minor-images

qodo-code-review · 2026-02-03T15:44:38Z

PR-Agent: could not fine a component named minor-images in a supported language in this PR.

openshift-ci-robot · 2026-02-03T16:50:56Z

/retest-required

Remaining retests: 0 against base HEAD 6186972 and 0 for PR HEAD e73ed72 in total

openshift-ci-robot · 2026-02-03T17:50:57Z

/hold

Revision e73ed72 was retested 3 times: holding

QiWang19 · 2026-02-03T20:23:57Z

/hold cancel

openshift-ci-robot · 2026-02-03T20:50:38Z

/retest-required

Remaining retests: 0 against base HEAD 6186972 and 2 for PR HEAD e73ed72 in total

openshift-ci · 2026-02-03T23:24:08Z

@QiWang19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`cc9c041`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-02-04T10:50:47Z

/retest-required

Remaining retests: 0 against base HEAD e09e5a4 and 1 for PR HEAD e73ed72 in total

openshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2025

openshift-ciBot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 1, 2025

QiWang19 changed the title ~~Add CRIOCredentialProviderConfig API and related functionality~~Add CRIOCredentialProviderConfig APINov 1, 2025

QiWang19 force-pushed the creds-provider branch from c00c122 to 1db4267Compare November 1, 2025 04:46

QiWang19 force-pushed the creds-provider branch 2 times, most recently from 8805169 to 108219fCompare November 3, 2025 22:49

QiWang19 force-pushed the creds-provider branch from 108219f to 066bf58Compare November 3, 2025 23:26

QiWang19 marked this pull request as ready for review November 3, 2025 23:26

openshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025

openshift-ciBot requested review from JoelSpeed and everettraven November 3, 2025 23:26

QiWang19 commented Nov 3, 2025
View reviewed changes

Comment threadconfig/v1alpha1/types_crio_credential_provider_config.go

saschagrunert reviewed Nov 4, 2025
View reviewed changes

QiWang19 force-pushed the creds-provider branch 2 times, most recently from d2a191b to 41bd600Compare November 4, 2025 20:10

openshift-ciBot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2025

QiWang19 changed the title ~~Add CRIOCredentialProviderConfig API~~OCPNODE-3863: Add CRIOCredentialProviderConfig APINov 4, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025

saschagrunert reviewed Nov 5, 2025
View reviewed changes

Comment threadconfig/v1alpha1/types_image_credential_provider_config.go Outdated

QiWang19 force-pushed the creds-provider branch from 41bd600 to e7df906Compare November 11, 2025 22:43

saschagrunert approved these changes Nov 12, 2025
View reviewed changes

Comment threadconfig/v1alpha1/types_crio_credential_provider_config.go
Comment threadconfig/v1alpha1/types_crio_credential_provider_config.go Outdated

Uh oh!

Conversation

QiWang19 commented Nov 1, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ciBot commented Nov 1, 2025

Uh oh!

openshift-ciBot commented Nov 1, 2025

Uh oh!

QiWang19 commented Nov 1, 2025

Uh oh!

QiWang19 commented Nov 3, 2025

Uh oh!

QiWang19 commented Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 4, 2025• edited by openshift-ci BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 4, 2025• edited by openshift-ci BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

QiWang19 commented Nov 12, 2025

Uh oh!

openshift-ci-robot commented Jan 30, 2026

Uh oh!

openshift-ciBot commented Jan 30, 2026

Uh oh!

openshift-ci-robot commented Jan 30, 2026

Uh oh!

openshift-ci-robot commented Jan 30, 2026

Uh oh!

QiWang19 commented Jan 30, 2026

Uh oh!

QiWang19 commented Feb 2, 2026

Uh oh!

QiWang19 commented Feb 2, 2026

Uh oh!

qodo-code-reviewBot commented Feb 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QiWang19 commented Feb 2, 2026

Uh oh!

qodo-code-reviewBot commented Feb 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

everettraven commented Feb 2, 2026

Uh oh!

openshift-ciBot commented Feb 2, 2026

Uh oh!

QiWang19 commented Feb 2, 2026

Uh oh!

qodo-code-reviewBot commented Feb 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QiWang19 commented Feb 3, 2026

Uh oh!

qodo-code-reviewBot commented Feb 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoelSpeed commented Feb 3, 2026

Uh oh!

QiWang19 commented Feb 3, 2026

Uh oh!

QiWang19 commented Feb 3, 2026

Uh oh!

qodo-code-reviewBot commented Feb 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

QiWang19 commented Nov 1, 2025•
edited
Loading

openshift-ci-robot commented Nov 4, 2025•
edited by openshift-ci Bot
Loading

openshift-ci-robot commented Nov 4, 2025•
edited by openshift-ci Bot
Loading

qodo-code-reviewBot commented Feb 2, 2026•
edited
Loading

qodo-code-reviewBot commented Feb 2, 2026•
edited
Loading

qodo-code-reviewBot commented Feb 2, 2026•
edited
Loading

qodo-code-reviewBot commented Feb 3, 2026•
edited
Loading

qodo-code-reviewBot commented Feb 3, 2026•
edited
Loading

qodo-code-reviewBot commented Feb 3, 2026•
edited
Loading

qodo-code-reviewBot commented Feb 3, 2026•
edited
Loading

openshift-ciBot commented Feb 3, 2026•
edited
Loading