Skip to content

OCPBUGS-74511: remove RouteExternalCertificate feature gate - #2693

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
jcmoraisjr:OCPBUGS-74511-remove-featuregate
May 13, 2026
Merged

OCPBUGS-74511: remove RouteExternalCertificate feature gate#2693
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
jcmoraisjr:OCPBUGS-74511-remove-featuregate

Conversation

@jcmoraisjr

Copy link
Copy Markdown
Member

RouteExternalCertificate is enabled by default, this is the second half of the changes to remove it and should be merged only after openshift/cluster-ingress-operator#1355 being merged.

Jira: https://issues.redhat.com/browse/OCPBUGS-74511

@openshift-ci-robot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

Copy link
Copy Markdown
Contributor

Hello @jcmoraisjr! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robotopenshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 5, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-74511, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

RouteExternalCertificate is enabled by default, this is the second half of the changes to remove it and should be merged only after openshift/cluster-ingress-operator#1355 being merged.

Jira: https://issues.redhat.com/browse/OCPBUGS-74511

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ciopenshift-ciBot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2026
@coderabbitai

coderabbitaiBot commented Feb 5, 2026

Copy link
Copy Markdown

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This pull request removes the RouteExternalCertificate feature gate from the codebase. Changes include deletion of the feature gate definition in features/features.go, removal of entries from legacy feature gate sets, and removal of RouteExternalCertificate from multiple feature gate configuration files across different deployment profiles. The validation on the externalCertificate field is migrated from OpenShift FeatureGateAwareXValidation annotations to standard kubebuilder XValidation rules, with the validation logic remaining functionally equivalent. CRD manifests are updated to reflect the empty FeatureGates list.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Title check✅ PassedThe title 'OCPBUGS-74511: remove RouteExternalCertificate feature gate' clearly and specifically describes the main change: removing the RouteExternalCertificate feature gate throughout the codebase.
Description check✅ PassedThe description relates to the changeset by explaining that RouteExternalCertificate is enabled by default and this PR removes the feature gate as part of a larger effort, with appropriate context about dependency on another PR.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Remove RouteExternalCertificate feature gate from all profiles

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Remove RouteExternalCertificate feature gate completely
• Update feature gate definitions across all deployment profiles
• Clean up generated OpenAPI and feature documentation
• Simplify feature flag configuration by removing deprecated gate
Diagram
flowchart LR
A["RouteExternalCertificate<br/>Feature Gate"] -->|Remove| B["Feature Definitions"]
B -->|Update| C["All Deployment Profiles"]
C -->|Regenerate| D["OpenAPI & Docs"]
Loading

Grey Divider

File Changes

1. features/features.go ✨ Enhancement +0/-8

Remove RouteExternalCertificate gate definition

features/features.go


2. features.md 📝 Documentation +0/-1

Update feature documentation

features.md


3. openapi/generated_openapi/zz_generated.openapi.go Miscellaneous +345/-69428

Regenerate OpenAPI definitions

openapi/generated_openapi/zz_generated.openapi.go


View more (8)
4. payload-manifests/featuregates/featureGate-SelfManagedHA-OKD.yaml ⚙️ Configuration changes +0/-3

Remove gate from OKD profile

payload-manifests/featuregates/featureGate-SelfManagedHA-OKD.yaml


5. payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml ⚙️ Configuration changes +0/-3

Remove gate from default profile

payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml


6. payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +0/-3

Remove gate from Hypershift preview

payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml


7. payload-manifests/featuregates/featureGate-Hypershift-OKD.yaml ⚙️ Configuration changes +0/-3

Remove gate from Hypershift OKD

payload-manifests/featuregates/featureGate-Hypershift-OKD.yaml


8. payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +0/-3

Remove gate from self-managed preview

payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml


9. payload-manifests/featuregates/featureGate-Hypershift-Default.yaml ⚙️ Configuration changes +0/-3

Remove gate from Hypershift default

payload-manifests/featuregates/featureGate-Hypershift-Default.yaml


10. payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +0/-3

Remove gate from Hypershift tech preview

payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml


11. payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +0/-3

Remove gate from self-managed tech preview

payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml


Grey Divider

Qodo Logo

@jcmoraisjr

Copy link
Copy Markdown
MemberAuthor

/hold

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2026
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (2)📘 Rule violations (0)📎 Requirement gaps (0)

Grey Divider


Action required

1. Gate removal inconsistent 🐞 Bug✓ Correctness
Description
• RouteExternalCertificate was removed from the FeatureGate payload manifests (and the features
registry), but the route API still declares fields/validations behind RouteExternalCertificate and
the repo still carries generated featuregated CRD metadata and integration tests for it.
• This inconsistency makes the feature’s actual enablement unclear: clusters can no longer enable
the gate via FeatureSet manifests, yet API schema/tests/docs still treat it as a live feature gate.
• Result is high risk of confusing behavior (feature appears supported in API artifacts but is not
enable-able via cluster FeatureGates), and ongoing maintenance burden (stale tests/docs).
Code

payload-manifests/featuregates/featureGate-Hypershift-Default.yaml[L320-322]

- {- "name": "RouteExternalCertificate"- },
Evidence
The FeatureGate payload manifests no longer list RouteExternalCertificate as enabled/disabled, but
the route API and generated/test artifacts still reference it as an active feature gate. That
mismatch strongly suggests the repo is only partially updated: configuration-level enablement was
removed, but API gating and associated generated/test/doc artifacts weren’t cleaned up or migrated.

payload-manifests/featuregates/featureGate-Hypershift-Default.yaml[317-323]
payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml[315-323]
route/v1/types.go[422-480]
route/v1/zz_generated.featuregated-crd-manifests.yaml[1-10]
route/v1/tests/routes.route.openshift.io/RouteExternalCertificate.yaml[1-6]
README.md[55-82]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
`RouteExternalCertificate` is removed from FeatureGate payload manifests / registration, but the route API and generated/test/doc artifacts still treat it as an active feature gate. This leaves the repo in an inconsistent state where the gate appears to exist for API gating/tests/docs, but is not enable-able via FeatureSet manifests.
## Issue Context
Evidence shows:
- FeatureGate manifests no longer include `RouteExternalCertificate`.
- Route API types still declare `ExternalCertificate` behind `+openshift:enable:FeatureGate=RouteExternalCertificate` and have FeatureGate-aware validation for it.
- Generated featuregated CRD metadata and integration tests still reference `RouteExternalCertificate`.
- README still uses it as the canonical example.
Decide intended outcome:
- **If the feature gate is being retired**: remove/ungate the API markers and delete/regenerate featuregated CRD/test/doc references.
- **If the feature gate is still intended to be supported**: restore FeatureGate registration + payload-manifest entries.
## Fix Focus Areas
- payload-manifests/featuregates/featureGate-Hypershift-Default.yaml[317-323]
- payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml[315-323]
- route/v1/types.go[422-480]
- route/v1/zz_generated.featuregated-crd-manifests.yaml[1-10]
- route/v1/tests/routes.route.openshift.io/RouteExternalCertificate.yaml[1-6]
- README.md[55-82]
- features/features.go[150-170]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Stale legacy allowlist 🐞 Bug⛯ Reliability
Description
• RouteExternalCertificate remains in legacyFeatureGates allowlists used to bypass enhancement-PR
enforcement for ‘legacy’ gates.
• After removing the gate from the FeatureGate catalog/FeatureSets, keeping it in the allowlist
makes it easier to accidentally reintroduce the gate without an enhancement link and obscures which
gates are actually supported.
• This is a maintainability/process risk: it weakens the guardrail intended to prevent new,
undocumented feature gates.
Code

features/features.go[L158-164]

-	FeatureGateRouteExternalCertificate = newFeatureGate("RouteExternalCertificate").- reportProblemsToJiraComponent("router").- contactPerson("chiragkyal").- productScope(ocpSpecific).- enhancementPR(legacyFeatureGateWithoutEnhancement).- enableIn(configv1.Default, configv1.OKD, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).- mustRegister()
Evidence
The repo still treats RouteExternalCertificate as a legacy gate in two different allowlists. Those
allowlists are explicitly used as a bypass when a feature gate registers with the
legacy/no-enhancement marker. Once the gate is removed elsewhere, leaving it in the allowlist is
inconsistent and reduces protection against accidental reintroduction.

features/legacyfeaturegates.go[84-90]
payload-command/render/legacyfeaturegates.go[88-95]
features/util.go[128-133]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
`RouteExternalCertificate` remains on the legacy feature gate allowlists even though the PR removes the gate from the FeatureGate catalog/FeatureSets. These allowlists are used to bypass enhancement PR enforcement, so keeping a removed gate there weakens the guardrail and increases risk of accidental reintroduction.
## Issue Context
`legacyFeatureGates` is explicitly used when `enhancementPRURL == legacyFeatureGateWithoutEnhancement` to decide whether a gate may bypass the enhancement requirement.
## Fix Focus Areas
- features/legacyfeaturegates.go[84-90]
- payload-command/render/legacyfeaturegates.go[88-95]
- features/util.go[128-133]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@jcmoraisjr
jcmoraisjrforce-pushed the OCPBUGS-74511-remove-featuregate branch from 6d76650 to f294df5CompareFebruary 5, 2026 20:39
@JoelSpeed

Copy link
Copy Markdown
Contributor

Looks like the codegen is in need of update here

@jcmoraisjr
jcmoraisjrforce-pushed the OCPBUGS-74511-remove-featuregate branch from f294df5 to 3b561e7CompareFebruary 6, 2026 13:10
@openshift-ciopenshift-ciBot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2026
@jcmoraisjr

Copy link
Copy Markdown
MemberAuthor

Thanks Joel. I couldn't reproduce the same failure locally via make verify-codegen-crds, so just removed the generated file reported in the error. When trying make verify, it failed with Prerelease lifecycle generation is out of date. Please run hack/update-prerelease-lifecycle-gen.sh even after successfully running the mentioned script. I hope it succeeds now, otherwise any hints to fully test locally is appreciated <3

@JoelSpeed

Copy link
Copy Markdown
Contributor

@jcmoraisjr Make sure you have pulled and rebased onto the latest master commit.
Then you want to try PROTO_OPTIONAL=1 make update to run the full suite of generators

If it's not putting the openapi generated content back, please try setting a $GOPATH and checking the repo out at $GOPATH/src/github.com/openshift/api before then running that command again

@jcmoraisjr
jcmoraisjrforce-pushed the OCPBUGS-74511-remove-featuregate branch from 3b561e7 to abf7f18CompareFebruary 6, 2026 16:31
@Miciah

Copy link
Copy Markdown
Contributor

/cc @chiragkyal

FYI that we're removing the "RouteExternalCertificate" featuregate for which you were the owner.

@melvinjoseph86

Copy link
Copy Markdown

Marking this PR as verified as this openshift/cluster-ingress-operator#1355 (comment)
/verified by @mjoseph

@openshift-ci-robotopenshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@melvinjoseph86: This PR has been marked as verified by @mjoseph.

Details

In response to this:

Marking this PR as verified as this openshift/cluster-ingress-operator#1355 (comment)
/verified by @mjoseph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcmoraisjr
jcmoraisjrforce-pushed the OCPBUGS-74511-remove-featuregate branch from abf7f18 to 6043181CompareFebruary 24, 2026 14:00
@openshift-ci-robotopenshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Feb 24, 2026
@JoelSpeed

Copy link
Copy Markdown
Contributor

Could we get this PR rebased please?

@openshift-ciopenshift-ciBot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2026
RouteExternalCertificate is enabled by default, this update is removing
its declaration from the legacy featuregates list, from CRD
declarations and from type annotations.
@jcmoraisjr
jcmoraisjrforce-pushed the OCPBUGS-74511-remove-featuregate branch from 6043181 to d1b1bd5CompareMay 12, 2026 13:52
@openshift-ciopenshift-ciBot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2026
@JoelSpeed

Copy link
Copy Markdown
Contributor

/lgtm
/verified by CI

@openshift-ci-robotopenshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@JoelSpeed: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2026
@JoelSpeed

Copy link
Copy Markdown
Contributor

/hold cancel
/retest

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9b69e5f and 2 for PR HEAD d1b1bd5 in total

@jcmoraisjr

Copy link
Copy Markdown
MemberAuthor

/test e2e-aws-ovn-hypershift

@jcmoraisjr

Copy link
Copy Markdown
MemberAuthor

/test e2e-aws-ovn-hypershift-conformance

@openshift-ci

Copy link
Copy Markdown
Contributor

@jcmoraisjr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-botBot merged commit 73d7ca9 into openshift:masterMay 13, 2026
29 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@jcmoraisjr: Jira Issue OCPBUGS-74511: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-74511 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

RouteExternalCertificate is enabled by default, this is the second half of the changes to remove it and should be merged only after openshift/cluster-ingress-operator#1355 being merged.

Jira: https://issues.redhat.com/browse/OCPBUGS-74511

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.0.0-0.nightly-2026-05-27-134409

openshift-merge-botBot pushed a commit that referenced this pull request May 28, 2026
…-featuregate"
This reverts commit 73d7ca9, reversing
changes made to 9b69e5f.
openshift-merge-botBot added a commit that referenced this pull request May 28, 2026
Revert "Merge pull request #2693 from jcmoraisjr/OCPBUGS-74511-remove…
@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.0.0-0.nightly-2026-08-06-014706

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.jira/valid-bugIndicates that a referenced Jira bug is valid for the branch this PR is targeting.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.lgtmIndicates that a PR is ready to be merged.size/XLDenotes a PR that changes 500-999 lines, ignoring generated files.verifiedSignifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jcmoraisjr@openshift-ci-robot@JoelSpeed@Miciah@melvinjoseph86@rikatz@openshift-merge-robot