Uh oh!
There was an error while loading. Please reload this page.
OCPBUGS-74511: remove RouteExternalCertificate feature gate - #2693
Conversation
openshift-ci-robot
commented
Feb 5, 2026
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
Hello @jcmoraisjr! Some important instructions when contributing to openshift/api: |
openshift-ci-robot
commented
Feb 5, 2026
@jcmoraisjr: This pull request references Jira Issue OCPBUGS-74511, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis pull request removes the RouteExternalCertificate feature gate from the codebase. Changes include deletion of the feature gate definition in features/features.go, removal of entries from legacy feature gate sets, and removal of RouteExternalCertificate from multiple feature gate configuration files across different deployment profiles. The validation on the externalCertificate field is migrated from OpenShift FeatureGateAwareXValidation annotations to standard kubebuilder XValidation rules, with the validation logic remaining functionally equivalent. CRD manifests are updated to reflect the empty FeatureGates list. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review Summary by QodoRemove RouteExternalCertificate feature gate from all profiles
WalkthroughsDescription• Remove RouteExternalCertificate feature gate completely • Update feature gate definitions across all deployment profiles • Clean up generated OpenAPI and feature documentation • Simplify feature flag configuration by removing deprecated gate Diagramflowchart LR
A["RouteExternalCertificate<br/>Feature Gate"] -->|Remove| B["Feature Definitions"]
B -->|Update| C["All Deployment Profiles"]
C -->|Regenerate| D["OpenAPI & Docs"]
File Changes1. features/features.go
|
jcmoraisjr
commented
Feb 5, 2026
/hold |
Code Review by Qodo
1. Gate removal inconsistent |
6d76650 to
f294df5CompareJoelSpeed
commented
Feb 6, 2026
Looks like the codegen is in need of update here |
f294df5 to
3b561e7Comparejcmoraisjr
commented
Feb 6, 2026
Thanks Joel. I couldn't reproduce the same failure locally via |
JoelSpeed
commented
Feb 6, 2026
@jcmoraisjr Make sure you have pulled and rebased onto the latest If it's not putting the openapi generated content back, please try setting a |
3b561e7 to
abf7f18CompareMiciah
commented
Feb 10, 2026
/cc @chiragkyal FYI that we're removing the "RouteExternalCertificate" featuregate for which you were the owner. |
melvinjoseph86
commented
Feb 10, 2026
Marking this PR as verified as this openshift/cluster-ingress-operator#1355 (comment) |
openshift-ci-robot
commented
Feb 10, 2026
@melvinjoseph86: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
abf7f18 to
6043181CompareJoelSpeed
commented
May 12, 2026
Could we get this PR rebased please? |
RouteExternalCertificate is enabled by default, this update is removing its declaration from the legacy featuregates list, from CRD declarations and from type annotations.
6043181 to
d1b1bd5CompareJoelSpeed
commented
May 12, 2026
/lgtm |
openshift-ci-robot
commented
May 12, 2026
@JoelSpeed: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Scheduling tests matching the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JoelSpeed
commented
May 13, 2026
/hold cancel |
jcmoraisjr
commented
May 13, 2026
/test e2e-aws-ovn-hypershift |
jcmoraisjr
commented
May 13, 2026
/test e2e-aws-ovn-hypershift-conformance |
@jcmoraisjr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Uh oh!
There was an error while loading. Please reload this page.
openshift-ci-robot
commented
May 13, 2026
@jcmoraisjr: Jira Issue OCPBUGS-74511: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-74511 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
commented
May 27, 2026
Fix included in release 5.0.0-0.nightly-2026-05-27-134409 |
Revert "Merge pull request #2693 from jcmoraisjr/OCPBUGS-74511-remove…
openshift-merge-robot
commented
Aug 6, 2026
Fix included in release 5.0.0-0.nightly-2026-08-06-014706 |
RouteExternalCertificate is enabled by default, this is the second half of the changes to remove it and should be merged only after openshift/cluster-ingress-operator#1355 being merged.
Jira: https://issues.redhat.com/browse/OCPBUGS-74511