SPLAT-2793: Promoted VSphereMultiVCenterDay2 feature gate to TP

[vr4manta]

SPLAT-2793

Changes

• Promoted VSphereMultiVCenterDay2 feature gate to TP

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2793 which is a valid jira issue.

Details

In response to this:

SPLAT-2793

Changes

• Promoted VSphereMultiVCenterDay2 feature gate to TP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[vr4manta]

/hold
Forgot to update the CRD test for day 2

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0075dbcf-d681-49fe-8960-c8941216c2f7

📥 Commits

Reviewing files that changed from the base of the PR and between 1e670eb and 936a2b0.

⛔ Files ignored due to path filters (3)

• config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• openapi/openapi.json is excluded by !openapi/**

📒 Files selected for processing (6)

• features.md
• features/features.go
• payload-manifests/crds/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

✅ Files skipped from review due to trivial changes (2)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• features.md

🚧 Files skipped from review as they are similar to previous changes (4)

• features/features.go
• payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/crds/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml

---

📝 Walkthrough

Walkthrough

This PR enables the VSphereMultiVCenterDay2 feature gate for the TechPreviewNoUpgrade scope. The feature gate definition is updated to enable for both inTechPreviewNoUpgrade() and inDevPreviewNoUpgrade() conditions, and two cluster feature gate manifests transition the gate from disabled to enabled. Supporting this enablement, the infrastructure and machine-config CRD schemas are updated with new validation rules that prevent a single update from simultaneously adding and removing vCenter entries, while replacing prior post-install constraints with rules that enforce immutability of the vcenters field once set.

Suggested reviewers

• JoelSpeed
• everettraven

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	ControllerConfig test has only 12 onUpdate tests vs 40 in Infrastructure file; multiple Expect assertions lack diagnostic failure messages as required.	Add missing onUpdate tests to ControllerConfig VSPhereMultiVCenterDay2.yaml and add descriptive failure messages to all Expect calls per requirement.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: promoting the VSphereMultiVCenterDay2 feature gate to Tech Preview (TP), which aligns with all modifications across feature gate definitions, configurations, and CRD validations.
Description check	✅ Passed	The description is directly related to the changeset, referencing the Jira ticket SPLAT-2793 and clearly stating the change of promoting VSphereMultiVCenterDay2 feature gate to Tech Preview, which matches the pull request objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names in the repository are static and deterministic. Test names come from YAML files and contain no dynamic information like pod names, timestamps, UUIDs, or IP addresses.
Microshift Test Compatibility	✅ Passed	PR contains no new Ginkgo e2e tests—only feature gate definitions, CRD schemas, and manifests. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests (It, Describe, Context, When) were added in this PR—only configuration and documentation files were modified.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only promotes feature gate and updates CRD validation rules; introduces no deployment manifests, pod scheduling constraints, or topology-unaware scheduling patterns.
Ote Binary Stdout Contract	✅ Passed	PR contains no process-level code changes that could violate OTE stdout contract; changes are feature gate configuration and YAML manifests only, with no stdout-writing functions introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. All changes are to feature definitions, CRD schemas, and feature gate manifests—no test code modifications present.
No-Weak-Crypto	✅ Passed	No weak cryptography detected. PR promotes VSphereMultiVCenterDay2 feature gate; changes are configuration and validation rules only, with no crypto implementations or weak algorithms.
Container-Privileges	✅ Passed	PR contains no container specs or workload manifests. Comprehensive search for privileged container settings across all YAML/JSON files returned zero results.
No-Sensitive-Data-In-Logs	✅ Passed	No logging statements with sensitive data found. PR only updates feature gate configuration and CRD validation rules with no new logging code.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vr4manta]

/unhold

[JoelSpeed]

/lgtm
/verified by E2Es

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by E2Es.

Details

In response to this:

/lgtm
/verified by E2Es

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 5d68333 and 2 for PR HEAD 936a2b0 in total

[openshift-ci]

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.