[release-4.22] SPLAT-2718: Promote FeatureGateVSphereMixedNodeEnv to GA

[vr4manta]

SPLAT-2718

Changes

• Promote VSphereMixedNodeEnv feature gate to GA

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2718 which is a valid jira issue.

Details

In response to this:

SPLAT-2718

Changes

• Promote VSphereMixedNodeEnv feature gate to GA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1d99b5fe-edc7-4308-ad5a-9bb587719936

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[qodo-for-rh-openshift]

PR Summary by Qodo

Promote VSphereMixedNodeEnv feature gate to GA

✨ Enhancement📝 Documentation⚙️ Configuration changes🕐 20-40 Minutes

AI Description

• Promote VSphereMixedNodeEnv from preview-only to default/OKD enabled (GA).
• Update published feature gate matrix to reflect GA enablement.
• Adjust 4.10 payload featuregate manifests so VSphereMixedNodeEnv is in the GA-enabled section.

Diagram

graph TD
A["FeatureGate registry\n(features/features.go)"] --> B["FeatureGate docs\n(features.md)"] --> C["Payload FeatureGate manifests\n(4.10 profiles)"] --> D["Clusters using payload\n(Default/OKD)"]
A --> C
subgraph Legend
direction LR
_code["Code"] ~~~ _doc["Documentation"] ~~~ _man["Manifests"] ~~~ _run["Runtime"]
end

Loading

High-Level Assessment

This PR’s approach (promote in the feature gate registry and mirror the change in docs and payload manifests) is the correct and lowest-risk way to GA a feature gate in this repo. No materially better alternative was identified beyond ensuring any manifest/doc updates remain in sync with the registry going forward.

Files changed (6) +21 / -21

Enhancement (1) +8 / -8

features.goEnable VSphereMixedNodeEnv in default and OKD feature sets (GA)+8/-8

Enable VSphereMixedNodeEnv in default and OKD feature sets (GA)

• Promotes FeatureGateVSphereMixedNodeEnv by adding inDefault() and inOKD() to its enablement sets (in addition to existing preview sets). Also includes a formatting-only indentation adjustment for the ConfidentialCluster feature gate block.

features/features.go

Documentation (1) +1 / -1

features.mdMove VSphereMixedNodeEnv to GA/default enabled section in feature matrix+1/-1

Move VSphereMixedNodeEnv to GA/default enabled section in feature matrix

• Updates the feature gate documentation table by relocating the VSphereMixedNodeEnv row to the GA/default-enabled portion of the matrix, reflecting promotion to GA.

features.md

Other (4) +12 / -12

featureGate-4-10-Hypershift-Default.yamlPlace VSphereMixedNodeEnv into GA-enabled list for Hypershift Default+3/-3

Place VSphereMixedNodeEnv into GA-enabled list for Hypershift Default

• Moves VSphereMixedNodeEnv from the earlier list location into the GA-enabled section alongside other vSphere GA feature gates for the 4.10 Hypershift Default payload manifest.

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

featureGate-4-10-Hypershift-OKD.yamlPlace VSphereMixedNodeEnv into GA-enabled list for Hypershift OKD+3/-3

Place VSphereMixedNodeEnv into GA-enabled list for Hypershift OKD

• Moves VSphereMixedNodeEnv into the GA-enabled section in the 4.10 Hypershift OKD payload manifest to match the feature’s GA promotion.

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

featureGate-4-10-SelfManagedHA-Default.yamlPlace VSphereMixedNodeEnv into GA-enabled list for SelfManagedHA Default+3/-3

Place VSphereMixedNodeEnv into GA-enabled list for SelfManagedHA Default

• Reorders the feature gate entry so VSphereMixedNodeEnv appears in the GA-enabled section for the 4.10 SelfManagedHA Default payload manifest.

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

featureGate-4-10-SelfManagedHA-OKD.yamlPlace VSphereMixedNodeEnv into GA-enabled list for SelfManagedHA OKD+3/-3

Place VSphereMixedNodeEnv into GA-enabled list for SelfManagedHA OKD

• Reorders the feature gate entry so VSphereMixedNodeEnv is in the GA-enabled section for the 4.10 SelfManagedHA OKD payload manifest, aligning OKD with GA enablement.

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

[qodo-for-rh-openshift]

Code Review by Qodo

🐞 Bugs (0)📘 Rule violations (0)📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

[vr4manta]

promotion presubmit is failing with:

Insufficient results in last 7 days, increasing lookback to 2 weeks...Insufficient results in last 7 days, increasing lookback to 2 weeks...Insufficient results in last 7 days, increasing lookback to 2 weeks...Insufficient results in last 7 days, increasing lookback to 2 weeks...INSUFFICIENT CI testing for "VSphereMixedNodeEnv".
F0723 20:12:24.557014 10781 root.go:64] Error running codegen: error: only 4 tests found, need at least 5 for "VSphereMixedNodeEnv" on {vsphere amd64 ha false}

We only had 4 tests in 5.0. We had gotten approval with those 4.

[JoelSpeed]

Is there anything we can do to get more data on that test with only 7 passing runs?

[vr4manta]

Is there anything we can do to get more data on that test with only 7 passing runs?

I can increase frequency of the jobs. It runs once a day and for 2 weeks i think now w/ 100%.

[everettraven]

@vr4manta You could use gangway-cli to trigger additional runs

[vr4manta]

@vr4manta You could use gangway-cli to trigger additional runs

I can use claude with gangway to do it yes. How many are you wanting? I just gotta make sure I do not overwhelm the BM server for the hybrid jobs.

[everettraven]

@vr4manta apologies for the delay - as of last week it looked like 7 more were needed. Going to run the verification again for a more accurate number.

/test verify-feature-promotion

[everettraven]

Looks like we have enough runs now.

@vr4manta do we have an SBAR for backporting this feature promotion that has been approved?

[vr4manta]

Looks like we have enough runs now.

@vr4manta do we have an SBAR for backporting this feature promotion that has been approved?

@everettraven Yes, here is the link : https://docs.google.com/presentation/d/1mzqwAM235OgGOxXn12TYFpoTm0HHtf0JKG66EdnXqdM/edit?slide=id.g35ec264dd90_0_0#slide=id.g35ec264dd90_0_0

Should i link this is first comment of PR as well?

[vr4manta]

/hold

[everettraven]

Should i link this is first comment of PR as well?

Up to you. Just having it accessible on the PR somewhere is good enough for me.

Going to kick promotion verification one last time for fresh results. If that comes back green this is good to go from my end.

[everettraven]

/test verify-feature-promotion

[qodo-for-rh-openshift]

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

[everettraven]

/lgtm
/approve

/override ci/prow/verify-feature-promotion

[openshift-ci]

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-feature-promotion

Details

In response to this:

/lgtm
/approve

/override ci/prow/verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vr4manta]

holding off on promoting this until https://redhat.atlassian.net/browse/OCPBUGS-100052 is fixed and backported to 4.22.

[openshift-ci]

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	f6f1649	link	true	/test verify-hypershift-integration
ci/prow/e2e-azure	f6f1649	link	true	/test e2e-azure
ci/prow/e2e-aws-ovn-hypershift	f6f1649	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn	f6f1649	link	true	/test e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift-conformance	f6f1649	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/verify-feature-promotion	f6f1649	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#501
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-vsphere-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1efbb2a0-965e-11f1-9518-f3eacbf1bee6-0

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#501
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-vsphere-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8db6d200-972c-11f1-8ed1-e44bafdf590f-0