Skip to content

OCPBUGS-109794: clarify FIPS-approved TLS groups in TLSSecurityProfile docs#2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanchezl wants to merge 1 commit into
base:master
Choose a base branch
from
Open

OCPBUGS-109794: clarify FIPS-approved TLS groups in TLSSecurityProfile docs #2983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions config/v1/types_tlssecurityprofile.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,10 @@ type TLSSecurityProfile struct {
// Note that not all platform components honor the ordering: Go-based components use Go's
// internal preference order and treat this list as a filter of allowed groups rather than
// an ordered preference.
// Note that X25519MLKEM768 is a post-quantum hybrid group that is not
// FIPS-approved and should be ignored by components running in FIPS mode.
// Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
// FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
// (X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
// FIPS-approved and are ignored by components running in FIPS mode.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
//
// The profiles are intent based, so they may change over time as new ciphers are
// developed and existing ciphers are found to be insecure. Depending on
Expand DownExpand Up@@ -168,8 +170,10 @@ const (
// There is a one-to-one mapping between these names and the group IDs defined
// in Go's crypto/tls package based on IANA's "TLS Supported Groups" registry:
// https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8
// Note that X25519MLKEM768 is a post-quantum hybrid group that is not
// FIPS-approved and should be ignored by components running in FIPS mode.
// Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
// FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
// (X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
// FIPS-approved and are ignored by components running in FIPS mode.
//
// +kubebuilder:validation:Enum=X25519;secp256r1;secp384r1;secp521r1;X25519MLKEM768;SecP256r1MLKEM768;SecP384r1MLKEM1024
type TLSGroup string
Expand DownExpand Up@@ -274,8 +278,10 @@ const (
// NOTE: The caller needs to make sure to check that these constants are valid
// for their binary. Not all entries map to values for all binaries. In the case
// of ties, the kube-apiserver wins. Do not fail, just be sure to include only
// valid entries and everything will be ok. In particular, X25519MLKEM768 is
// not FIPS-approved and must be omitted by components running in FIPS mode.
// valid entries and everything will be ok. In particular, only the NIST P-curves
// (secp256r1, secp384r1, secp521r1) are FIPS-approved; X25519 and the ML-KEM
// post-quantum hybrid groups (X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024)
// are not FIPS-approved and must be omitted by components running in FIPS mode.
var TLSProfiles = map[TLSProfileType]*TLSProfileSpec{
TLSProfileOldType: {
Ciphers: []string{
Expand Down
12 changes: 8 additions & 4 deletions ...zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -600,8 +600,10 @@ spec:
There is a one-to-one mapping between these names and the group IDs defined
in Go's crypto/tls package based on IANA's "TLS Supported Groups" registry:
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.
enum:
- X25519
- secp256r1
Expand DownExpand Up@@ -719,8 +721,10 @@ spec:
Note that not all platform components honor the ordering: Go-based components use Go's
internal preference order and treat this list as a filter of allowed groups rather than
an ordered preference.
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.

The profiles are intent based, so they may change over time as new ciphers are
developed and existing ciphers are found to be insecure. Depending on
Expand Down
6 changes: 4 additions & 2 deletions config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-Default.crd.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -366,8 +366,10 @@ spec:
Note that not all platform components honor the ordering: Go-based components use Go's
internal preference order and treat this list as a filter of allowed groups rather than
an ordered preference.
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.

The profiles are intent based, so they may change over time as new ciphers are
developed and existing ciphers are found to be insecure. Depending on
Expand Down
12 changes: 8 additions & 4 deletions ...enerated.crd-manifests/0000_10_config-operator_01_apiservers-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -600,8 +600,10 @@ spec:
There is a one-to-one mapping between these names and the group IDs defined
in Go's crypto/tls package based on IANA's "TLS Supported Groups" registry:
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.
enum:
- X25519
- secp256r1
Expand DownExpand Up@@ -719,8 +721,10 @@ spec:
Note that not all platform components honor the ordering: Go-based components use Go's
internal preference order and treat this list as a filter of allowed groups rather than
an ordered preference.
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.

The profiles are intent based, so they may change over time as new ciphers are
developed and existing ciphers are found to be insecure. Depending on
Expand Down
6 changes: 4 additions & 2 deletions config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-OKD.crd.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -366,8 +366,10 @@ spec:
Note that not all platform components honor the ordering: Go-based components use Go's
internal preference order and treat this list as a filter of allowed groups rather than
an ordered preference.
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.

The profiles are intent based, so they may change over time as new ciphers are
developed and existing ciphers are found to be insecure. Depending on
Expand Down
12 changes: 8 additions & 4 deletions ...nerated.crd-manifests/0000_10_config-operator_01_apiservers-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -600,8 +600,10 @@ spec:
There is a one-to-one mapping between these names and the group IDs defined
in Go's crypto/tls package based on IANA's "TLS Supported Groups" registry:
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.
enum:
- X25519
- secp256r1
Expand DownExpand Up@@ -719,8 +721,10 @@ spec:
Note that not all platform components honor the ordering: Go-based components use Go's
internal preference order and treat this list as a filter of allowed groups rather than
an ordered preference.
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.

The profiles are intent based, so they may change over time as new ciphers are
developed and existing ciphers are found to be insecure. Depending on
Expand Down
6 changes: 4 additions & 2 deletions ...1/zz_generated.featuregated-crd-manifests/apiservers.config.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -366,8 +366,10 @@ spec:
Note that not all platform components honor the ordering: Go-based components use Go's
internal preference order and treat this list as a filter of allowed groups rather than
an ordered preference.
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.

The profiles are intent based, so they may change over time as new ciphers are
developed and existing ciphers are found to be insecure. Depending on
Expand Down
6 changes: 4 additions & 2 deletions ...zz_generated.featuregated-crd-manifests/apiservers.config.openshift.io/KMSEncryption.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -643,8 +643,10 @@ spec:
Note that not all platform components honor the ordering: Go-based components use Go's
internal preference order and treat this list as a filter of allowed groups rather than
an ordered preference.
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.

The profiles are intent based, so they may change over time as new ciphers are
developed and existing ciphers are found to be insecure. Depending on
Expand Down
6 changes: 4 additions & 2 deletions .../zz_generated.featuregated-crd-manifests/apiservers.config.openshift.io/TLSAdherence.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -397,8 +397,10 @@ spec:
Note that not all platform components honor the ordering: Go-based components use Go's
internal preference order and treat this list as a filter of allowed groups rather than
an ordered preference.
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.

The profiles are intent based, so they may change over time as new ciphers are
developed and existing ciphers are found to be insecure. Depending on
Expand Down
12 changes: 8 additions & 4 deletions ...erated.featuregated-crd-manifests/apiservers.config.openshift.io/TLSGroupPreferences.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -282,8 +282,10 @@ spec:
There is a one-to-one mapping between these names and the group IDs defined
in Go's crypto/tls package based on IANA's "TLS Supported Groups" registry:
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.
enum:
- X25519
- secp256r1
Expand DownExpand Up@@ -401,8 +403,10 @@ spec:
Note that not all platform components honor the ordering: Go-based components use Go's
internal preference order and treat this list as a filter of allowed groups rather than
an ordered preference.
Note that X25519MLKEM768 is a post-quantum hybrid group that is not
FIPS-approved and should be ignored by components running in FIPS mode.
Note that only the NIST P-curves (secp256r1, secp384r1, secp521r1) are
FIPS-approved. X25519 and the ML-KEM post-quantum hybrid groups
(X25519MLKEM768, SecP256r1MLKEM768, SecP384r1MLKEM1024) are not
FIPS-approved and are ignored by components running in FIPS mode.

@canditacanditaAug 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not quite true. SecP256r1MLKEM768, SecP384r1MLKEM1024 are allowed in FIPS mode on OpenShift. I asked in forum-fips: https://redhat-external.slack.com/archives/CQ7BBRNQN/p1775490088375709?thread_ts=1775340298.286989&cid=CQ7BBRNQN


The profiles are intent based, so they may change over time as new ciphers are
developed and existing ciphers are found to be insecure. Depending on
Expand Down
Loading