SPLAT-2890: Add VSphereScopedCredentials feature gate by rvanderp3 · Pull Request #2988 · openshift/api

rvanderp3 · 2026-08-17T19:17:01Z

No description provided.

openshift-merge-bot · 2026-08-17T19:17:03Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-17T19:17:05Z

@rvanderp3: This pull request references SPLAT-2890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-17T19:17:05Z

Hello @rvanderp3! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

rvanderp3 · 2026-08-17T19:17:10Z

/hold

coderabbitai · 2026-08-17T19:17:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0d593c63-9820-4e03-b5a1-109005f2f8e7

📥 Commits

Reviewing files that changed from the base of the PR and between 4800040 and ac0a2e4.

📒 Files selected for processing (10)

features.md
features/features.go
payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

🚧 Files skipped from review as they are similar to previous changes (9)

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
features.md

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

Walkthrough

The change adds and registers the FeatureGateVSpherePerComponentScopedCreds feature gate with SPLAT ownership, enhancement metadata, and DevPreview availability. It adds the feature to the matrix. It enables the feature for DevPreviewNoUpgrade and disables it for Default, OKD, and TechPreviewNoUpgrade manifests across HyperShift and SelfManagedHA.

Possibly related PRs

openshift/api#2974: Both changes update feature-gate declarations, the support matrix, and HyperShift/SelfManagedHA manifests.

Suggested reviewers:everettraven, joelspeed

Merge Risk:⚪ Minimal · up to ac0a2

This change adds a feature gate and updates its generated manifests and documentation; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided, so the changeset is not described.	Add a brief description that states the VSpherePerComponentScopedCreds feature gate was added and identifies its enabled configurations.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title identifies the vSphere scoped credentials feature gate, which matches the main change despite omitting “PerComponent”.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff changes only feature-gate metadata and manifests; it adds or modifies no test files or Ginkgo title calls.
Test Structure And Quality	✅ Passed	The diff changes only feature metadata, Go registration, and JSON manifests; it adds no Ginkgo tests or cluster operations to review.
Microshift Test Compatibility	✅ Passed	The diff adds only feature metadata, a feature-gate declaration, and YAML manifests; it adds no Ginkgo e2e tests or MicroShift-incompatible test references.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only feature metadata and FeatureGate manifests; it adds no Ginkgo e2e tests or multi-node test assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff adds only a feature-gate declaration, documentation, and FeatureGate list entries; it adds no workloads, replicas, affinities, topology spreads, selectors, tolerations, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The diff adds only feature metadata/manifests and a declarative feature-gate initializer; no stdout/logging APIs or process-level setup writes were found.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff adds only a feature declaration, documentation, and manifests. It adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The diff adds only a feature-gate declaration, matrix entry, and manifest entries. No MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	The diff adds only a feature gate, documentation, and FeatureGate objects; no changed container/Kubernetes manifest contains privileged settings or root execution.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds only a feature-gate declaration, matrix entry, and manifest names; the diff introduces no logging calls or sensitive data output.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-08-17T23:35:46Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

rvanderp3 · 2026-08-18T16:42:22Z

/pipeline

rvanderp3 · 2026-08-18T16:43:25Z

/pipeline required

openshift-merge-bot · 2026-08-18T16:43:27Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

rvanderp3 · 2026-08-18T19:02:42Z

/hold cancel

vr4manta · 2026-08-18T19:10:52Z

/lgtm
/assign @everettraven

openshift-merge-bot · 2026-08-18T19:12:00Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

rvanderp3 · 2026-08-18T19:14:17Z

/hold

Adds a new TechPreview feature gate for vSphere per-component credential overrides in CCO, allowing cluster administrators to provide distinct, lower-privilege credentials for each component (Machine API, CSI, Cloud Controller Manager) via annotated secrets in the openshift-config namespace. Enhancement: openshift/enhancements#2081

vr4manta · 2026-08-18T19:15:59Z

/lgtm

openshift-ci · 2026-08-18T19:16:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vr4manta
Once this PR has been reviewed and has the lgtm label, please ask for approval from everettraven. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-08-18T19:17:14Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

rvanderp3 · 2026-08-18T19:27:33Z

/hold cancel

openshift-ci · 2026-08-18T23:15:15Z

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	`ac0a2e4`	link	true	`/test e2e-azure`
ci/prow/e2e-aws-ovn-hypershift-conformance	`ac0a2e4`	link	true	`/test e2e-aws-ovn-hypershift-conformance`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 17, 2026

openshift-ciBot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 17, 2026

openshift-ciBot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2026

openshift-ciBot requested review from JoelSpeed and everettraven August 17, 2026 19:17

rvanderp3 force-pushed the add-vsphere-scoped-credentials-feature-gate branch from 00618b2 to bd2cd3cCompare August 17, 2026 23:35

openshift-ciBot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 17, 2026

rvanderp3 force-pushed the add-vsphere-scoped-credentials-feature-gate branch from bd2cd3c to 4800040Compare August 18, 2026 14:32

openshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2026

openshift-ciBot assigned everettraven and vr4manta Aug 18, 2026

openshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026

openshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2026

rvanderp3 force-pushed the add-vsphere-scoped-credentials-feature-gate branch from 4800040 to ac0a2e4Compare August 18, 2026 19:15

openshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026

openshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026

openshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2026

Uh oh!

Conversation

rvanderp3 commented Aug 17, 2026

Uh oh!

openshift-merge-botBot commented Aug 17, 2026

Uh oh!

openshift-ci-robot commented Aug 17, 2026• edited by openshift-ci BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ciBot commented Aug 17, 2026

Uh oh!

rvanderp3 commented Aug 17, 2026

Uh oh!

coderabbitaiBot commented Aug 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitaiBot commented Aug 17, 2026

Uh oh!

rvanderp3 commented Aug 18, 2026

Uh oh!

rvanderp3 commented Aug 18, 2026

Uh oh!

openshift-merge-botBot commented Aug 18, 2026

Uh oh!

rvanderp3 commented Aug 18, 2026

Uh oh!

vr4manta commented Aug 18, 2026

Uh oh!

openshift-merge-botBot commented Aug 18, 2026

Uh oh!

rvanderp3 commented Aug 18, 2026

Uh oh!

vr4manta commented Aug 18, 2026

Uh oh!

openshift-ciBot commented Aug 18, 2026

Uh oh!

openshift-merge-botBot commented Aug 18, 2026

Uh oh!

rvanderp3 commented Aug 18, 2026

Uh oh!

openshift-ciBot commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci-robot commented Aug 17, 2026•
edited by openshift-ci Bot
Loading

coderabbitaiBot commented Aug 17, 2026•
edited
Loading