Skip to content

CORS-4550: Promote GCD to Default - #2991

Open
patrickdillon wants to merge 1 commit into
openshift:masterfrom
patrickdillon:promote-gcd
Open

CORS-4550: Promote GCD to Default#2991
patrickdillon wants to merge 1 commit into
openshift:masterfrom
patrickdillon:promote-gcd

Conversation

@patrickdillon

Copy link
Copy Markdown
Contributor

Move GCD to default featureset. Promoted via SBAR.

Move GCD to default featureset.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot

openshift-ci-robot commented Aug 18, 2026

Copy link
Copy Markdown

@patrickdillon: This pull request references CORS-4550 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Move GCD to default featureset. Promoted via SBAR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 18, 2026
@openshift-ci

Copy link
Copy Markdown
Contributor

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ciopenshift-ciBot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 18, 2026
@coderabbitai

coderabbitaiBot commented Aug 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e3dfd06b-ee69-40d0-b63b-227c76911b62

📥 Commits

Reviewing files that changed from the base of the PR and between fea75cc and 33f9e5d.

📒 Files selected for processing (4)
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The change enables GCPSovereignCloudInstall in the default feature set. The feature matrix marks it enabled for Hypershift and SelfManagedHA defaults, while OKD remains unchanged. The Hypershift and SelfManagedHA default feature-gate manifests move it from disabled to enabled. TechPreview and DevPreview behavior remains unchanged.

Suggested reviewers:jsafrane, haircommander, jcmoraisjr

Merge Risk:⚪ Minimal · up to 33f9e

This localized change promotes GCD to the default feature set; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the issue and states that GCD moves to the default featureset.
Description check✅ PassedThe description directly explains that GCD moves to the default featureset and notes the SBAR promotion.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names✅ PassedThe diff changes only feature-gate metadata and generated manifests. It adds no Ginkgo It, Describe, Context, or When titles, dynamic or otherwise.
Test Structure And Quality✅ PassedThe patch changes feature metadata and feature-gate manifests only. It adds or modifies no Ginkgo tests, so the listed test-quality requirements do not apply.
Microshift Test Compatibility✅ PassedThe commit changes only feature-gate documentation, Go registration, and YAML manifests; it adds no Ginkgo e2e tests or test-like paths to assess.
Single Node Openshift (Sno) Test Compatibility✅ PassedThe commit changes only feature-gate metadata and YAML manifests; it adds no Ginkgo e2e tests or multi-node test assumptions.
Topology-Aware Scheduling Compatibility✅ PassedThe diff changes only feature-gate registration, documentation, and enabled/disabled lists; no deployment, controller, or scheduling constraint is added.
Ote Binary Stdout Contract✅ PassedThe PR changes only feature metadata, one feature-gate initializer, and two YAML manifests; it adds no process-level stdout write or OTE binary setup.
Ipv6 And Disconnected Network Test Compatibility✅ PassedThe patch changes only feature metadata and YAML manifests; the diff adds no Ginkgo e2e tests or network/external connectivity code.
No-Weak-Crypto✅ PassedThe PR only promotes GCPSovereignCloudInstall in feature metadata and manifests; the added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto code.
Container-Privileges✅ PassedThe diff only promotes GCPSovereignCloudInstall in FeatureGate data; no changed file adds privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs✅ PassedThe diff only changes feature-gate metadata and manifests; it adds no logging calls or sensitive-data indicators.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Comment @coderabbitai help to get the list of available commands.

@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@patrickdillon@openshift-ci-robot