Skip to content

Feat/check target connectivity - #208

Open
alvlkov wants to merge 3 commits into
openshift:mainfrom
alvlkov:feat/check-target-connectivity-osd-26447
Open

Feat/check target connectivity#208
alvlkov wants to merge 3 commits into
openshift:mainfrom
alvlkov:feat/check-target-connectivity-osd-26447

Conversation

@alvlkov

Copy link
Copy Markdown
Contributor

What type of PR is this?

This adds a new managed script to perform multiple checks to validate external target connectivity from Openshift cluster.

What this PR does / Why we need it?

OSD-26447

Special notes for your reviewer

Pre-checks (if applicable)

  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alvlkov
Once this PR has been reviewed and has the lgtm label, please assign wanghaoran1988 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feichashao

Copy link
Copy Markdown
Contributor

Hi @alvlkov , thank you for raising this PR and thank you for including a README!

The managed-script itself will run as pod in the cluster. I see the script is calling oc create another pod and runs the network utils in the new pod, is there a specific reason to run them in a new pod?

@alvlkov

Copy link
Copy Markdown
ContributorAuthor

Hi @alvlkov , thank you for raising this PR and thank you for including a README!

The managed-script itself will run as pod in the cluster. I see the script is calling oc create another pod and runs the network utils in the new pod, is there a specific reason to run them in a new pod?

@feichashao thank you for the review!

Yes, there is a particular reason to create another pod. I believe the base image used by managed-script does not provide all necessary dependencies to perform the checks, i.e. nmap:

  • DNS resolution check via nslookup: $ nslookup "$TARGET"
  • DNS resolution via Dig: $ dig +short "$TARGET"
  • ICMP check via ping: $ timeout 10 ping -c 3 "$TARGET"
  • Routing Check via traceroute: $ timeout 5 traceroute -m 10 -w 1 -q 1 "$TARGET"
  • Check Target Port is Open via nmap: $ timeout 5 nmap -p "$PORT" "$TARGET" 2>&1 | grep -q "$PORT/tcp open"

Other scripts as PCAP collector use the same approach and image: quay.io/app-sre/srep-network-toolbox:latest is suitable.

@feichashao

Copy link
Copy Markdown
Contributor

@alvlkov thanks for the clarifications! That make sense if the image itself doesn't have the needed binaries. Probably we can add it to the image https://github.com/openshift/managed-scripts/blob/main/Dockerfile but let me discuss with the team.

Comment threadscripts/CEE/check-target-connectivity/metadata.yaml Outdated
@openshift-bot

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ciopenshift-ciBot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2025
@alvlkov

Copy link
Copy Markdown
ContributorAuthor

/remove-lifecycle stale

@openshift-ciopenshift-ciBot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2025
@openshift-ci

Copy link
Copy Markdown
Contributor

@alvlkov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
ci/prow/images92558falinktrue/test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ciopenshift-ciBot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2025
@alvlkov

Copy link
Copy Markdown
ContributorAuthor

/remove-lifecycle stale

@openshift-ciopenshift-ciBot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2025
@openshift-bot

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ciopenshift-ciBot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2026
@openshift-bot

Copy link
Copy Markdown

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ciopenshift-ciBot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 12, 2026
@alvlkov

Copy link
Copy Markdown
ContributorAuthor

/remove-lifecycle stale
/remove-lifecycle rotten

@openshift-ciopenshift-ciBot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@alvlkov@feichashao@openshift-bot@bmeng