Edits to deployments.adoc file

[bfallonf]

@ironcladlou This PR is in response to #296 and I waited for #330 to merge before I made any edits, etc. Can I ask for a quick review? I have a couple of questions as well:

1. In the Overview, it talks about the latestversion and deploymentCause, but these parameters aren't in the example given. Should they be?
2. Under the Lifecycle Hooks section, in the Warning box, it says to check to documentation for a strategy to learn about its support for lifecycle hooks. Does this refer to our own docs? Because maybe something might have to be added here.
3. Would you be able to elaborate on the last paragraph of the ImageChange Triggers section? I can understand that when the image is updated (in this case openshift/origin-ruby-sample), then the tag parameter value changes, but I'm not too sure what happens. Does the current deployment get destroyed and a new one is created from the updated image?

Thanks in advance!

[ironcladlou]

In the Overview, it talks about the latestversion and deploymentCause, but these parameters aren't in the example given. Should they be?

In hindsight I'm not sure these details are relevant. Maybe it should say something like:

"Deployment configs have a monotonically incrementing version which is incremented each time a new deployment for the config is created. In addition, the cause of the last deployment is added to the config"

Under the Lifecycle Hooks section, in the Warning box, it says to check to documentation for a strategy to learn about its support for lifecycle hooks. Does this refer to our own docs? Because maybe something might have to be added here.

It's referring to the "Recreate Strategy [[recreate-strategy]]" section in the same document. A link to that could be provided.

Would you be able to elaborate on the last paragraph of the ImageChange Triggers section? I can understand that when the image is updated (in this case openshift/origin-ruby-sample), then the tag parameter value changes, but I'm not too sure what happens. Does the current deployment get destroyed and a new one is created from the updated image?

When the tag value for the image is updated, a new deployment using that image/tag value (and the current state of the config in general) is created, and then the deployment is rolled out using the strategy specified.

[bfallonf]

@ironcladlou Thanks a lot for that extra info. I think things are a lot clearer now.

@CowboysFan@adellape@tpoitras@tnguyen-rh This should be available for peer review if anyone wants to jump in.

[ironcladlou]

This is looking very good, thanks.

[adellape]

Accidental hyphen makes accidental bullet!

[adellape]

@bfallonf Couple comments inline, otherwise LGTM. Lemme know when you feel it's ready for merge (and squashed).

[bfallonf]

Hmm odd. I coulda sworn I'd given the ok for this to be merged...

@adellape@CowboysFan this should be alright to merge. I've edited the suggested edits above.