Skip to content

4.14 OLM 1.0 Tech Preview procedures - #66036

Merged
michaelryanpeter merged 1 commit into
openshift:mainfrom
michaelryanpeter:4.14-olm-1.0-tech-preview
Oct 20, 2023
Merged

4.14 OLM 1.0 Tech Preview procedures#66036
michaelryanpeter merged 1 commit into
openshift:mainfrom
michaelryanpeter:4.14-olm-1.0-tech-preview

Conversation

@michaelryanpeter

@michaelryanpetermichaelryanpeter commented Oct 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Version(s): 4.14

Issues:

Link to docs preview: Installing an Operator from a catalog

QE review:

  • QE has approved this change.

Additional information:

@openshift-ciopenshift-ciBot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 10, 2023
@michaelryanpetermichaelryanpeter mentioned this pull request Oct 10, 2023
Closed
1 task
@ocpdocs-previewbot

ocpdocs-previewbot commented Oct 10, 2023•
edited
Loading

Copy link
Copy Markdown

🤖 Updated build preview is available at:
https://66036--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/29262

@michaelryanpeter
michaelryanpeterforce-pushed the 4.14-olm-1.0-tech-preview branch 2 times, most recently from fab5877 to 43b3f35CompareOctober 12, 2023 20:30
michaelryanpeter
michaelryanpeter commented Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
michaelryanpeter
michaelryanpeter commented Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
michaelryanpeter
michaelryanpeter commented Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
michaelryanpeter
michaelryanpeter commented Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
michaelryanpeter
michaelryanpeter commented Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-adding-a-catalog.adoc Outdated
michaelryanpeter
michaelryanpeter commented Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
joelanford
joelanford reviewed Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-adding-a-catalog.adoc Outdated
michaelryanpeter
michaelryanpeter commented Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-red-hat-catalogs.adoc Outdated
michaelryanpeter
michaelryanpeter commented Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-about-catalogs.adoc Outdated
joelanford
joelanford reviewed Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
awgreene
awgreene reviewed Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-deleting-an-operator.adoc Outdated
tmshort
tmshort reviewed Oct 13, 2023
View reviewed changes
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
michaelryanpeter
michaelryanpeter commented Oct 13, 2023
View reviewed changes

@michaelryanpetermichaelryanpeter left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes from the engineering read through.

Comment threadmodules/olmv1-about-catalogs.adoc Outdated
Comment threadmodules/olmv1-deleting-an-operator.adoc Outdated
Comment threadmodules/olmv1-adding-a-catalog.adoc Outdated
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
Comment threadmodules/olmv1-updating-an-operator.adoc Outdated
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
Comment threadoperators/olm_v1/olmv1-installing-an-operator-from-a-catalog.adoc Outdated
@michaelryanpeter
michaelryanpeterforce-pushed the 4.14-olm-1.0-tech-preview branch 5 times, most recently from fa7cc57 to c91051bCompareOctober 16, 2023 16:14
@michaelryanpeter

michaelryanpeter commented Oct 16, 2023

Copy link
Copy Markdown
ContributorAuthor

@jianzhangbjz or @Xia-Zhao-rh PTAL.

@jianzhangbjz

jianzhangbjz commented Oct 17, 2023

Copy link
Copy Markdown

Hi @kuiwang02 , could you help review it? Thanks!
/assign @kuiwang02

kuiwang02
kuiwang02 reviewed Oct 17, 2023
View reviewed changes
Comment threadmodules/olmv1-deleting-an-operator.adoc Outdated
@kuiwang02

kuiwang02 commented Oct 17, 2023

Copy link
Copy Markdown

/assign @Xia-Zhao-rh

@jldohmannjldohmann added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 18, 2023
kuiwang02
kuiwang02 reviewed Oct 19, 2023
View reviewed changes
Comment threadmodules/olmv1-updating-an-operator.adoc Outdated
@Xia-Zhao-rh

Xia-Zhao-rh commented Oct 19, 2023

Copy link
Copy Markdown

@Xia-Zhao-rh I think I have addressed your comments.

  • I removed the section on what happens if you leave the target version unspecified. If the bug fix is backported, I will add the content back in.
  • Kevin clarified the issue with the Marketplace catalog.

Would you PTAL?

Hi, @michaelryanpeter LGTM, Thanks.

kuiwang02
kuiwang02 reviewed Oct 19, 2023
View reviewed changes
Comment threadmodules/olmv1-updating-an-operator.adoc Outdated
@michaelryanpeter
michaelryanpeterforce-pushed the 4.14-olm-1.0-tech-preview branch 2 times, most recently from 31e0937 to 2620a54CompareOctober 19, 2023 18:53
@kevinrizza

kevinrizza commented Oct 19, 2023

Copy link
Copy Markdown
Member

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@kuiwang02

kuiwang02 commented Oct 20, 2023

Copy link
Copy Markdown

/label qe-approved

@openshift-ciopenshift-ciBot added the qe-approved Signifies that QE has signed off on this PR label Oct 20, 2023
@kuiwang02

kuiwang02 commented Oct 20, 2023

Copy link
Copy Markdown

/lgtm

@Xia-Zhao-rh

Xia-Zhao-rh commented Oct 20, 2023

Copy link
Copy Markdown

/label qe-approved

@Xia-Zhao-rh

Xia-Zhao-rh commented Oct 20, 2023

Copy link
Copy Markdown

/lgtm

jianzhangbjz
jianzhangbjz suggested changes Oct 20, 2023
View reviewed changes
Comment threadmodules/olmv1-about-target-versions.adoc Outdated
Comment threadmodules/olmv1-finding-operators-to-install.adoc Outdated

@jianzhangbjzjianzhangbjzOct 20, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the same as above, the package_name is better than the operator_name here.

@michaelryanpetermichaelryanpeterOct 20, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed.

Comment threadmodules/olmv1-red-hat-catalogs.adoc Outdated

@jianzhangbjzjianzhangbjzOct 20, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we also need to list the marketplace operators here, such as,

apiVersion: catalogd.operatorframework.io/v1alpha1kind: Catalogmetadata:
name: redhat-marketplacespec:
source:
type: imageimage:
ref: registry.redhat.io/redhat/redhat-marketplace-index:v{product-version}

@michaelryanpetermichaelryanpeterOct 20, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianzhangbjz PTAL at @kevinrizza's comment here: #66036 (comment)

I believe that engineering's preference is to leave off the Marketplace catalog, since it is built by IBM and we have less control if something doesn't work with OLM 1.0 at this stage of development.

If you feel strongly that this should be included, I will open a new ticket and PR for us to discuss the issue. We have until Friday 10/27 for docs merge freeze, so we have a bit of time to discuss this.

@michaelryanpetermichaelryanpeterOct 20, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created issue OSDOCS-8299. After this PR merges, I will create a follow up PR with the Marketplace catalog, so that we can get the change published before Docs Merge Freeze on 10/27.

@michaelryanpetermichaelryanpeterOct 20, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up Marketplace catalog PR: #66647

@jianzhangbjzjianzhangbjzOct 23, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks!

@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@openshift-ci

openshift-ciBot commented Oct 20, 2023

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@michaelryanpeter
michaelryanpeter merged commit 5c84b3d into openshift:mainOct 20, 2023
@michaelryanpeter

michaelryanpeter commented Oct 20, 2023

Copy link
Copy Markdown
ContributorAuthor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

openshift-cherrypick-robot commented Oct 20, 2023

Copy link
Copy Markdown

@michaelryanpeter: new pull request created: #66645

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robotopenshift-cherrypick-robot mentioned this pull request Oct 20, 2023
Merged
@michaelryanpetermichaelryanpeter mentioned this pull request Oct 20, 2023
Closed
1 task
@adellapeadellape mentioned this pull request Oct 23, 2023
Merged
@michaelryanpeter
michaelryanpeter deleted the 4.14-olm-1.0-tech-preview branch October 26, 2023 15:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jldohmannjldohmannjldohmann left review comments
+8 more reviewers
@joelanfordjoelanfordjoelanford left review comments
@kevinrizzakevinrizzakevinrizza left review comments
@awgreeneawgreeneawgreene left review comments
@tmshorttmshorttmshort left review comments
@jianzhangbjzjianzhangbjzjianzhangbjz requested changes
@mwerner2113mwerner2113mwerner2113 left review comments
@kuiwang02kuiwang02kuiwang02 left review comments
@Xia-Zhao-rhXia-Zhao-rhXia-Zhao-rh left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@kevinrizzakevinrizza

@kuiwang02kuiwang02

@Xia-Zhao-rhXia-Zhao-rh

Labels

branch/enterprise-4.14peer-review-doneSignifies that the peer review team has reviewed this PRqe-approvedSignifies that QE has signed off on this PRsize/XLDenotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.14 GA

Development

Successfully merging this pull request may close these issues.

12 participants

@michaelryanpeter@ocpdocs-previewbot@jianzhangbjz@kuiwang02@Xia-Zhao-rh@kevinrizza@openshift-cherrypick-robot@joelanford@awgreene@tmshort@jldohmann@mwerner2113