Skip to content

NO-ISSUE: Grant QE approver permissions for OTE contributions - #457

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jianzhangbjz:ote-qe
Sep 9, 2025
Merged

NO-ISSUE: Grant QE approver permissions for OTE contributions#457
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jianzhangbjz:ote-qe

Conversation

@jianzhangbjz

Copy link
Copy Markdown
Contributor

The current owners are defined in OWNERS_ALIASES. However, with the OTE process, more and more QE test cases will be contributed to this folder. It would be better if QE also had approval permissions.
Hi @oceanc80 and @joelanford , could you help approve it when you get a chance? Thanks!

@jianzhangbjzjianzhangbjz changed the title Grant QE approve permission for OTEGrant QE approver permissions for OTE contributionsAug 27, 2025
@tmshort

Copy link
Copy Markdown
Contributor

/retitle NO-ISSUE: Grant QE approver permissions for OTE contributions

@openshift-ciopenshift-ciBot changed the title Grant QE approver permissions for OTE contributionsNO-ISSUE: Grant QE approver permissions for OTE contributionsAug 27, 2025
@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 27, 2025
@openshift-ci-robot

Copy link
Copy Markdown

@jianzhangbjz: This pull request explicitly references no jira issue.

Details

In response to this:

The current owners are defined in OWNERS_ALIASES. However, with the OTE process, more and more QE test cases will be contributed to this folder. It would be better if QE also had approval permissions.
Hi @oceanc80 and @joelanford , could you help approve it when you get a chance? Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort

Copy link
Copy Markdown
Contributor

Here, in downstream, the DOWNSTREAM_OWNERS and DOWNSTREAM_OWNERS_ALIASES are used, I'm wondering if this file would even be looked at.

@jianzhangbjz

Copy link
Copy Markdown
ContributorAuthor

I’m not sure either, but let’s try it out. :)

@jianzhangbjz

Copy link
Copy Markdown
ContributorAuthor

Hi @oceanc80 , could you help approve it when you get a chance? Thanks!

@perdasilva

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2025
@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025
@jianzhangbjz

Copy link
Copy Markdown
ContributorAuthor

/verified by pass

@openshift-ci-robotopenshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 9, 2025
@openshift-ci-robot

Copy link
Copy Markdown

@jianzhangbjz: This PR has been marked as verified by pass.

Details

In response to this:

/verified by pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

Copy link
Copy Markdown
Contributor

@jianzhangbjz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-botBot merged commit 40dae8e into openshift:mainSep 9, 2025
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.lgtmIndicates that a PR is ready to be merged.verifiedSignifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jianzhangbjz@tmshort@openshift-ci-robot@perdasilva