Skip to content

NO-ISSUE: Add pedjak and trgeiger as reviewers - #463

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
oceanc80:update-reviewers
Sep 25, 2025
Merged

NO-ISSUE: Add pedjak and trgeiger as reviewers#463
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
oceanc80:update-reviewers

Conversation

@oceanc80

@oceanc80oceanc80 commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ciopenshift-ciBot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 5, 2025
@perdasilva

perdasilva commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

/retest

@perdasilva

perdasilva commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2025
@jianzhangbjz

jianzhangbjz commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

/verified by @jianzhangbjz

@openshift-ci-robot

openshift-ci-robot commented Sep 9, 2025

Copy link
Copy Markdown

@jianzhangbjz: This PR has been marked as verified by @jianzhangbjz.

Details

In response to this:

/verified by @jianzhangbjz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robotopenshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 9, 2025
@tmshort

tmshort commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

/label merge/squash

@openshift-ci

openshift-ciBot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

@tmshort: The label(s) /label merge/squash cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label merge/squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort

tmshort commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

To not break the bumper
/label tide/merge-method-rebase

@openshift-ciopenshift-ciBot added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Sep 9, 2025
@openshift-ci

openshift-ciBot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

@jianzhangbjz: The label(s) /label jira/valid-reference cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label jira/valid-reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jianzhangbjz

jianzhangbjz commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Try to add jira/valid-reference label.
/retitle NO-ISSUE: Add pedjak and trgeiger as reviewers

@openshift-ciopenshift-ciBot changed the title UPSTREAM: <carry>: Add pedjak and trgeiger as reviewersNO-ISSUE: Add pedjak and trgeiger as reviewersSep 10, 2025
@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2025
@openshift-ci-robot

openshift-ci-robot commented Sep 10, 2025

Copy link
Copy Markdown

@oceanc80: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort

tmshort commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

/verify-owners

@tmshort

tmshort commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

/hold
Until we fix the bumper issue

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2025
@tmshort

tmshort commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

/remove-label tide/merge-method-rebase

@openshift-ciopenshift-ciBot removed the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Sep 12, 2025
@tmshort

tmshort commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

/unhold
#471 merged

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2025
@tmshort

tmshort commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

/verify-owners

@tmshort

tmshort commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

/verify-owners

@openshift-ci

openshift-ciBot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

@gavinmbell: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ciBot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gavinmbell, oceanc80, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva

perdasilva commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

/verify-owners

@perdasilva

perdasilva commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

I've reached out to Gavin to see about adding Tayler to the openshift org - still waiting

@perdasilva

perdasilva commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

/verify-owners

1 similar comment
@perdasilva

perdasilva commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

/verify-owners

@openshift-ciopenshift-ciBot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 23, 2025
@openshift-ci-robot

openshift-ci-robot commented Sep 23, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 83ffc35 and 2 for PR HEAD 9b2c8ab in total

@perdasilva

perdasilva commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ciBot commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

@oceanc80: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-botBot merged commit 1487ceb into openshift:mainSep 25, 2025
10 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120anik120Awaiting requested review from anik120
@rashmigottipatirashmigottipatiAwaiting requested review from rashmigottipati
2 more reviewers
@perdasilvaperdasilvaperdasilva approved these changes
@gavinmbellgavinmbellgavinmbell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@perdasilvaperdasilva

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.lgtmIndicates that a PR is ready to be merged.verifiedSignifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oceanc80@perdasilva@jianzhangbjz@openshift-ci-robot@tmshort@gavinmbell