Skip to content

OCPQE-29416:Init OLMv1 OTE Framework for tests-private to migrate first case - #467

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
kuiwang02:migrateqecase
Sep 18, 2025
Merged

OCPQE-29416:Init OLMv1 OTE Framework for tests-private to migrate first case#467
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
kuiwang02:migrateqecase

Conversation

@kuiwang02

@kuiwang02kuiwang02 commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Init OLMv1 OTE Test Framework for tests-private Cases and Add Test Cases

Summary

This PR continue to init OTE framework for tests-private cases and implements initial test cases for ClusterCatalog and ClusterExtension functionality.

Changes

🏗️ Infrastructure & Dependencies

  • Added vendor dependencies: Updated go.mod and go.sum with required third-party packages
  • Enhance test framework: Complete test infrastructure under test/extended/ directory
  • Updated Makefile: Added support for tests-private test execution

🧪 Test Framework Components

  • Test utilities (test/extended/util/):

    • Core testing utilities for OpenShift/Kubernetes operations
    • Client management and cluster interaction helpers
    • Container and image management tools
    • Architecture-specific utilities
  • OLMv1-specific utilities (test/extended/util/olmv1util/):

    • ClusterCatalog management and verification
    • ClusterExtension operations
    • Network policy validation
    • RBAC and security testing helpers
    • Image mirroring and registry utilities
  • Test data templates (test/extended/testdata/olm/):

    • YAML templates for various OLMv1 resources
    • ClusterCatalog and ClusterExtension configurations
    • Network policy and RBAC definitions
    • Service account and security context templates

🔍 Test Cases Implemented

1. ClusterCatalog Tests (olmv1_cc.go)

  • PolarionID:69123: Validates that ClusterCatalog can serve operator content through HTTP
  • Verifies catalog content accessibility and package/channel/bundle information

2. ClusterExtension Tests (olmv1_ce.go)

  • PolarionID:83069: Validates OLMv1 static network policies
  • Comprehensive network policy verification for:
    • openshift-catalogd namespace policies
    • openshift-cluster-olm-operator namespace policies
    • openshift-operator-controller namespace policies
  • Ensures proper network isolation and security controls

📁 Key Files Added/Modified

  • test/extended/specs/olmv1_cc.go - ClusterCatalog test implementation
  • test/extended/specs/olmv1_ce.go - ClusterExtension test implementation
  • test/extended/util/ - Core test utilities
  • test/extended/util/olmv1util/ - OLMv1-specific utilities
  • test/extended/testdata/olm/ - Test data templates
  • test/extended/README.md - Documentation for the test framework
  • cmd/main.go - Updated main entry point
  • Updated vendor dependencies and build configuration

Test Result

./openshift-tests run olmv1/extended --monitor watch-namespaces I0910 14:30:39.519860 53891 i18n.go:119] Couldn't find the LC_ALL, LC_MESSAGES or LANG environment variables, defaulting to en_US I0910 14:30:39.520255 53891 i18n.go:157] Setting language to defaultopenshift-tests v4.1.0-9884-g87d58caINFO[0000] Including only extension binaries with image tags: [tests olm-operator-controller] INFO[0000] Including extension binary with image tag: tests INFO[0000] Excluding extension binary with image tag: hyperkube (not in include list) INFO[0000] Excluding extension binary with image tag: machine-api-operator (not in include list) INFO[0000] Including extension binary with image tag: olm-operator-controller INFO[0000] Excluding extension binary with image tag: machine-config-operator (not in include lis...INFO[0226] Found 0 must-gather tests started: 0/1/2 "[sig-olmv1][Jira:OLM] clustercatalog PolarionID:69123-[Skipped:Disconnected]Catalogd clustercatalog offer the operator content through http server"started: 0/2/2 "[sig-olmv1][Jira:OLM] clusterextension PolarionID:83069-olmv1 static networkpolicy."passed: (18.7s) 2025-09-10T06:34:52 "[sig-olmv1][Jira:OLM] clusterextension PolarionID:83069-olmv1 static networkpolicy."passed: (40.7s) 2025-09-10T06:35:14 "[sig-olmv1][Jira:OLM] clustercatalog PolarionID:69123-[Skipped:Disconnected]Catalogd clustercatalog offer the operator content through http server"Shutting down the monitorCollecting data.INFO[0275] Starting CollectData for all monitor tests INFO[0275] Starting CollectData for [Jira:"Test Framework"] monitor test watch-namespaces collection INFO[0275] Finished CollectData for [Jira:"Test Framework"] monitor test watch-namespaces collection INFO[0275] Finished CollectData for all monitor tests Computing intervals.Evaluating tests.Cleaning up.INFO[0275] beginning cleanup monitorTest=watch-namespacesSerializing results.Writing to storage. m.startTime = 2025-09-10 14:34:26.067947 +0800 CST m=+226.890463335 m.stopTime = 2025-09-10 14:35:14.419778 +0800 CST m=+275.242901626Processing monitorTest: watch-namespaces finalIntervals size = 4 first interval time: From = 2025-09-10 14:34:26.072568 +0800 CST m=+226.895084668; To = 2025-09-10 14:34:26.072568 +0800 CST m=+226.895084668 last interval time: From = 2025-09-10 14:35:14.419496 +0800 CST m=+275.242619918; To = 2025-09-10 14:35:14.419496 +0800 CST m=+275.242619918Writing junits.Writing JUnit report to e2e-monitor-tests__20250910-063125.xml2 pass, 0 skip (3m49s)

Usage

please refer to openshift/tests-extension/test/extended/README.md.

Assisted-by: Claude Code

@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2025
@openshift-ci-robot

openshift-ci-robot commented Sep 10, 2025

Copy link
Copy Markdown

@kuiwang02: This pull request references OCPQE-29416 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Init OLMv1 OTE Test Framework for tests-private Cases and Add Test Cases

Summary

This PR continue to init OTE framework for tests-private cases and implements initial test cases for ClusterCatalog and ClusterExtension functionality.

Changes

🏗️ Infrastructure & Dependencies

  • Added vendor dependencies: Updated go.mod and go.sum with required third-party packages
  • Enhance test framework: Complete test infrastructure under test/extended/ directory
  • Updated Makefile: Added support for tests-private test execution

🧪 Test Framework Components

  • Test utilities (test/extended/util/):

    • Core testing utilities for OpenShift/Kubernetes operations
    • Client management and cluster interaction helpers
    • Container and image management tools
    • Architecture-specific utilities
  • OLMv1-specific utilities (test/extended/util/olmv1util/):

    • ClusterCatalog management and verification
    • ClusterExtension operations
    • Network policy validation
    • RBAC and security testing helpers
    • Image mirroring and registry utilities
  • Test data templates (test/extended/testdata/olm/):

    • YAML templates for various OLMv1 resources
    • ClusterCatalog and ClusterExtension configurations
    • Network policy and RBAC definitions
    • Service account and security context templates

🔍 Test Cases Implemented

1. ClusterCatalog Tests (olmv1_cc.go)

  • PolarionID:69123: Validates that ClusterCatalog can serve operator content through HTTP
  • Verifies catalog content accessibility and package/channel/bundle information

2. ClusterExtension Tests (olmv1_ce.go)

  • PolarionID:83069: Validates OLMv1 static network policies
  • Comprehensive network policy verification for:
    • openshift-catalogd namespace policies
    • openshift-cluster-olm-operator namespace policies
    • openshift-operator-controller namespace policies
  • Ensures proper network isolation and security controls

📁 Key Files Added/Modified

  • test/extended/specs/olmv1_cc.go - ClusterCatalog test implementation
  • test/extended/specs/olmv1_ce.go - ClusterExtension test implementation
  • test/extended/util/ - Core test utilities
  • test/extended/util/olmv1util/ - OLMv1-specific utilities
  • test/extended/testdata/olm/ - Test data templates
  • test/extended/README.md - Documentation for the test framework
  • cmd/main.go - Updated main entry point
  • Updated vendor dependencies and build configuration

Test Result

./openshift-tests run olmv1/extended --monitor watch-namespaces I0910 14:30:39.519860 53891 i18n.go:119] Couldn't find the LC_ALL, LC_MESSAGES or LANG environment variables, defaulting to en_US I0910 14:30:39.520255 53891 i18n.go:157] Setting language to defaultopenshift-tests v4.1.0-9884-g87d58caINFO[0000] Including only extension binaries with image tags: [tests olm-operator-controller] INFO[0000] Including extension binary with image tag: tests INFO[0000] Excluding extension binary with image tag: hyperkube (not in include list) INFO[0000] Excluding extension binary with image tag: machine-api-operator (not in include list) INFO[0000] Including extension binary with image tag: olm-operator-controller INFO[0000] Excluding extension binary with image tag: machine-config-operator (not in include lis...INFO[0226] Found 0 must-gather tests started: 0/1/2 "[sig-olmv1][Jira:OLM] clustercatalog PolarionID:69123-[Skipped:Disconnected]Catalogd clustercatalog offer the operator content through http server"started: 0/2/2 "[sig-olmv1][Jira:OLM] clusterextension PolarionID:83069-olmv1 static networkpolicy."passed: (18.7s) 2025-09-10T06:34:52 "[sig-olmv1][Jira:OLM] clusterextension PolarionID:83069-olmv1 static networkpolicy."passed: (40.7s) 2025-09-10T06:35:14 "[sig-olmv1][Jira:OLM] clustercatalog PolarionID:69123-[Skipped:Disconnected]Catalogd clustercatalog offer the operator content through http server"Shutting down the monitorCollecting data.INFO[0275] Starting CollectData for all monitor tests INFO[0275] Starting CollectData for [Jira:"Test Framework"] monitor test watch-namespaces collection INFO[0275] Finished CollectData for [Jira:"Test Framework"] monitor test watch-namespaces collection INFO[0275] Finished CollectData for all monitor tests Computing intervals.Evaluating tests.Cleaning up.INFO[0275] beginning cleanup monitorTest=watch-namespacesSerializing results.Writing to storage. m.startTime = 2025-09-10 14:34:26.067947 +0800 CST m=+226.890463335 m.stopTime = 2025-09-10 14:35:14.419778 +0800 CST m=+275.242901626Processing monitorTest: watch-namespaces finalIntervals size = 4 first interval time: From = 2025-09-10 14:34:26.072568 +0800 CST m=+226.895084668; To = 2025-09-10 14:34:26.072568 +0800 CST m=+226.895084668 last interval time: From = 2025-09-10 14:35:14.419496 +0800 CST m=+275.242619918; To = 2025-09-10 14:35:14.419496 +0800 CST m=+275.242619918Writing junits.Writing JUnit report to e2e-monitor-tests__20250910-063125.xml2 pass, 0 skip (3m49s)

Usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

openshift-ci-robot commented Sep 10, 2025

Copy link
Copy Markdown

@kuiwang02: This pull request references OCPQE-29416 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Init OLMv1 OTE Test Framework for tests-private Cases and Add Test Cases

Summary

This PR continue to init OTE framework for tests-private cases and implements initial test cases for ClusterCatalog and ClusterExtension functionality.

Changes

🏗️ Infrastructure & Dependencies

  • Added vendor dependencies: Updated go.mod and go.sum with required third-party packages
  • Enhance test framework: Complete test infrastructure under test/extended/ directory
  • Updated Makefile: Added support for tests-private test execution

🧪 Test Framework Components

  • Test utilities (test/extended/util/):

    • Core testing utilities for OpenShift/Kubernetes operations
    • Client management and cluster interaction helpers
    • Container and image management tools
    • Architecture-specific utilities
  • OLMv1-specific utilities (test/extended/util/olmv1util/):

    • ClusterCatalog management and verification
    • ClusterExtension operations
    • Network policy validation
    • RBAC and security testing helpers
    • Image mirroring and registry utilities
  • Test data templates (test/extended/testdata/olm/):

    • YAML templates for various OLMv1 resources
    • ClusterCatalog and ClusterExtension configurations
    • Network policy and RBAC definitions
    • Service account and security context templates

🔍 Test Cases Implemented

1. ClusterCatalog Tests (olmv1_cc.go)

  • PolarionID:69123: Validates that ClusterCatalog can serve operator content through HTTP
  • Verifies catalog content accessibility and package/channel/bundle information

2. ClusterExtension Tests (olmv1_ce.go)

  • PolarionID:83069: Validates OLMv1 static network policies
  • Comprehensive network policy verification for:
    • openshift-catalogd namespace policies
    • openshift-cluster-olm-operator namespace policies
    • openshift-operator-controller namespace policies
  • Ensures proper network isolation and security controls

📁 Key Files Added/Modified

  • test/extended/specs/olmv1_cc.go - ClusterCatalog test implementation
  • test/extended/specs/olmv1_ce.go - ClusterExtension test implementation
  • test/extended/util/ - Core test utilities
  • test/extended/util/olmv1util/ - OLMv1-specific utilities
  • test/extended/testdata/olm/ - Test data templates
  • test/extended/README.md - Documentation for the test framework
  • cmd/main.go - Updated main entry point
  • Updated vendor dependencies and build configuration

Test Result

./openshift-tests run olmv1/extended --monitor watch-namespaces I0910 14:30:39.519860 53891 i18n.go:119] Couldn't find the LC_ALL, LC_MESSAGES or LANG environment variables, defaulting to en_US I0910 14:30:39.520255 53891 i18n.go:157] Setting language to defaultopenshift-tests v4.1.0-9884-g87d58caINFO[0000] Including only extension binaries with image tags: [tests olm-operator-controller] INFO[0000] Including extension binary with image tag: tests INFO[0000] Excluding extension binary with image tag: hyperkube (not in include list) INFO[0000] Excluding extension binary with image tag: machine-api-operator (not in include list) INFO[0000] Including extension binary with image tag: olm-operator-controller INFO[0000] Excluding extension binary with image tag: machine-config-operator (not in include lis...INFO[0226] Found 0 must-gather tests started: 0/1/2 "[sig-olmv1][Jira:OLM] clustercatalog PolarionID:69123-[Skipped:Disconnected]Catalogd clustercatalog offer the operator content through http server"started: 0/2/2 "[sig-olmv1][Jira:OLM] clusterextension PolarionID:83069-olmv1 static networkpolicy."passed: (18.7s) 2025-09-10T06:34:52 "[sig-olmv1][Jira:OLM] clusterextension PolarionID:83069-olmv1 static networkpolicy."passed: (40.7s) 2025-09-10T06:35:14 "[sig-olmv1][Jira:OLM] clustercatalog PolarionID:69123-[Skipped:Disconnected]Catalogd clustercatalog offer the operator content through http server"Shutting down the monitorCollecting data.INFO[0275] Starting CollectData for all monitor tests INFO[0275] Starting CollectData for [Jira:"Test Framework"] monitor test watch-namespaces collection INFO[0275] Finished CollectData for [Jira:"Test Framework"] monitor test watch-namespaces collection INFO[0275] Finished CollectData for all monitor tests Computing intervals.Evaluating tests.Cleaning up.INFO[0275] beginning cleanup monitorTest=watch-namespacesSerializing results.Writing to storage. m.startTime = 2025-09-10 14:34:26.067947 +0800 CST m=+226.890463335 m.stopTime = 2025-09-10 14:35:14.419778 +0800 CST m=+275.242901626Processing monitorTest: watch-namespaces finalIntervals size = 4 first interval time: From = 2025-09-10 14:34:26.072568 +0800 CST m=+226.895084668; To = 2025-09-10 14:34:26.072568 +0800 CST m=+226.895084668 last interval time: From = 2025-09-10 14:35:14.419496 +0800 CST m=+275.242619918; To = 2025-09-10 14:35:14.419496 +0800 CST m=+275.242619918Writing junits.Writing JUnit report to e2e-monitor-tests__20250910-063125.xml2 pass, 0 skip (3m49s)

Usage

please refer to openshift/tests-extension/test/extended/README.md.

Assisted-by: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kuiwang02
kuiwang02force-pushed the migrateqecase branch 2 times, most recently from 35711d9 to 2fc37c7CompareSeptember 10, 2025 07:16
@openshift-ci-robot

openshift-ci-robot commented Sep 10, 2025

Copy link
Copy Markdown

@kuiwang02: This pull request references OCPQE-29416 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Init OLMv1 OTE Test Framework for tests-private Cases and Add Test Cases

Summary

This PR continue to init OTE framework for tests-private cases and implements initial test cases for ClusterCatalog and ClusterExtension functionality.

Changes

🏗️ Infrastructure & Dependencies

  • Added vendor dependencies: Updated go.mod and go.sum with required third-party packages
  • Enhance test framework: Complete test infrastructure under test/extended/ directory
  • Updated Makefile: Added support for tests-private test execution

🧪 Test Framework Components

  • Test utilities (test/extended/util/):

    • Core testing utilities for OpenShift/Kubernetes operations
    • Client management and cluster interaction helpers
    • Container and image management tools
    • Architecture-specific utilities
  • OLMv1-specific utilities (test/extended/util/olmv1util/):

    • ClusterCatalog management and verification
    • ClusterExtension operations
    • Network policy validation
    • RBAC and security testing helpers
    • Image mirroring and registry utilities
  • Test data templates (test/extended/testdata/olm/):

    • YAML templates for various OLMv1 resources
    • ClusterCatalog and ClusterExtension configurations
    • Network policy and RBAC definitions
    • Service account and security context templates

🔍 Test Cases Implemented

1. ClusterCatalog Tests (olmv1_cc.go)

  • PolarionID:69123: Validates that ClusterCatalog can serve operator content through HTTP
  • Verifies catalog content accessibility and package/channel/bundle information

2. ClusterExtension Tests (olmv1_ce.go)

  • PolarionID:83069: Validates OLMv1 static network policies
  • Comprehensive network policy verification for:
    • openshift-catalogd namespace policies
    • openshift-cluster-olm-operator namespace policies
    • openshift-operator-controller namespace policies
  • Ensures proper network isolation and security controls

📁 Key Files Added/Modified

  • test/extended/specs/olmv1_cc.go - ClusterCatalog test implementation
  • test/extended/specs/olmv1_ce.go - ClusterExtension test implementation
  • test/extended/util/ - Core test utilities
  • test/extended/util/olmv1util/ - OLMv1-specific utilities
  • test/extended/testdata/olm/ - Test data templates
  • test/extended/README.md - Documentation for the test framework
  • cmd/main.go - Updated main entry point
  • Updated vendor dependencies and build configuration

Test Result

./openshift-tests run olmv1/extended --monitor watch-namespaces I0910 14:30:39.519860 53891 i18n.go:119] Couldn't find the LC_ALL, LC_MESSAGES or LANG environment variables, defaulting to en_US I0910 14:30:39.520255 53891 i18n.go:157] Setting language to defaultopenshift-tests v4.1.0-9884-g87d58caINFO[0000] Including only extension binaries with image tags: [tests olm-operator-controller] INFO[0000] Including extension binary with image tag: tests INFO[0000] Excluding extension binary with image tag: hyperkube (not in include list) INFO[0000] Excluding extension binary with image tag: machine-api-operator (not in include list) INFO[0000] Including extension binary with image tag: olm-operator-controller INFO[0000] Excluding extension binary with image tag: machine-config-operator (not in include lis...INFO[0226] Found 0 must-gather tests started: 0/1/2 "[sig-olmv1][Jira:OLM] clustercatalog PolarionID:69123-[Skipped:Disconnected]Catalogd clustercatalog offer the operator content through http server"started: 0/2/2 "[sig-olmv1][Jira:OLM] clusterextension PolarionID:83069-olmv1 static networkpolicy."passed: (18.7s) 2025-09-10T06:34:52 "[sig-olmv1][Jira:OLM] clusterextension PolarionID:83069-olmv1 static networkpolicy."passed: (40.7s) 2025-09-10T06:35:14 "[sig-olmv1][Jira:OLM] clustercatalog PolarionID:69123-[Skipped:Disconnected]Catalogd clustercatalog offer the operator content through http server"Shutting down the monitorCollecting data.INFO[0275] Starting CollectData for all monitor tests INFO[0275] Starting CollectData for [Jira:"Test Framework"] monitor test watch-namespaces collection INFO[0275] Finished CollectData for [Jira:"Test Framework"] monitor test watch-namespaces collection INFO[0275] Finished CollectData for all monitor tests Computing intervals.Evaluating tests.Cleaning up.INFO[0275] beginning cleanup monitorTest=watch-namespacesSerializing results.Writing to storage. m.startTime = 2025-09-10 14:34:26.067947 +0800 CST m=+226.890463335 m.stopTime = 2025-09-10 14:35:14.419778 +0800 CST m=+275.242901626Processing monitorTest: watch-namespaces finalIntervals size = 4 first interval time: From = 2025-09-10 14:34:26.072568 +0800 CST m=+226.895084668; To = 2025-09-10 14:34:26.072568 +0800 CST m=+226.895084668 last interval time: From = 2025-09-10 14:35:14.419496 +0800 CST m=+275.242619918; To = 2025-09-10 14:35:14.419496 +0800 CST m=+275.242619918Writing junits.Writing JUnit report to e2e-monitor-tests__20250910-063125.xml2 pass, 0 skip (3m49s)

Usage

please refer to openshift/tests-extension/test/extended/README.md.

Assisted-by: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kuiwang02

Copy link
Copy Markdown
ContributorAuthor

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn 5

@openshift-ci

Copy link
Copy Markdown
Contributor

@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ec6182c0-8e1b-11f0-97d0-7d76e5f47d8d-0

@kuiwang02

Copy link
Copy Markdown
ContributorAuthor

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview 5

@openshift-ci

Copy link
Copy Markdown
Contributor

@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07902100-8e1c-11f0-9d27-1b2214be72fa-0

@tmshort

Copy link
Copy Markdown
Contributor

/label tide/merge-method-rebase

@openshift-ciopenshift-ciBot added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Sep 10, 2025
@tmshort

Copy link
Copy Markdown
Contributor

I'm a bit concerned about the size of this PR and its effect on the bumper. 5,000+ files changed.

@kuiwang02
kuiwang02force-pushed the migrateqecase branch 3 times, most recently from 0eabc18 to f73d456CompareSeptember 11, 2025 06:24
@kuiwang02

Copy link
Copy Markdown
ContributorAuthor

I'm a bit concerned about the size of this PR and its effect on the bumper. 5,000+ files changed.

@tmshort
Thanks for the comment.

The QE testing framework depends on k8s.io/kubernetes/test/e2e/framework. That dependency pulls a large number of files into vendor. To make the cases migrate smoothly with minimal changes, we kept that dependency during migration.

Before opening the PR I trimmed some libraries from the original QE framework to reduce the number of files, but there were still many. I’ve now further slimmed it down — removing 1,920 files overall — and I can’t reduce it any more without causing build failures (I tried; further removals break compilation). Thanks for your understanding.

If you think the PR is acceptable, please add an lgtm so the QE team can begin migrating the cases. Thanks!

if not, could I spilt the PR to two PRs to introduce the vendor files so that there are not so many files in one PR? thanks

@kuiwang02

Copy link
Copy Markdown
ContributorAuthor

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview 5

@openshift-ci

Copy link
Copy Markdown
Contributor

@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1236f1c0-8ede-11f0-96b1-dd1a5c952822-0

@kuiwang02

Copy link
Copy Markdown
ContributorAuthor

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn 5

@openshift-ci

Copy link
Copy Markdown
Contributor

@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1f79b840-8ede-11f0-892b-8bb6861d4ead-0

@tmshort

Copy link
Copy Markdown
Contributor

Right now, we're having problems with the bumper PR, and I really need to figure that out.

@kuiwang02

Copy link
Copy Markdown
ContributorAuthor

Right now, we're having problems with the bumper PR, and I really need to figure that out.

@tmshort thanks for the information. wait for your further notice, thanks.

@tmshort

Copy link
Copy Markdown
Contributor

/hold
Until we fix the bumper issue

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2025
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2025
@tmshort

Copy link
Copy Markdown
Contributor

/remove-label tide/merge-method-rebase

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025
@tmshort

Copy link
Copy Markdown
Contributor

/unhold
#471 merged

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2025
@jianzhangbjz

Copy link
Copy Markdown
Contributor

/approve

@kuiwang02

Copy link
Copy Markdown
ContributorAuthor

/label tide/merge-method-rebase

@openshift-ciopenshift-ciBot added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Sep 16, 2025
@kuiwang02

Copy link
Copy Markdown
ContributorAuthor

@tmshort@perdasilva (in case you are online afternoon BJ time), could you please help approve it so that we can start next migration? thanks

@tmshort

Copy link
Copy Markdown
Contributor

We don't need rebase anymore.
/remove-label tide/merge-method-rebase

@openshift-ciopenshift-ciBot removed the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Sep 16, 2025
Comment threadopenshift/tests-extension/Makefile Outdated
Comment on lines +83 to +89
bindata: test/extended/testdata/bindata.go
test/extended/testdata/bindata.go: $(shell find test/extended/testdata -type f ! -name 'bindata.go')
mkdir -p $(@D)
$(GO_BINDATA) -nocompress -nometadata \
-pkg testdata -o $@ -prefix "testextended" \
-ignore "test/extended/testdata/bindata.go" test/extended/testdata/...
gofmt -s -w $@

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other bindata is located in pkg/bindata/, not sure if this was intentional, or...?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmshort Thanks
I just followed the way of the tests-private, and now I change to pkg/bindata.

@tmshorttmshortSep 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this path:
openshift/tests-extension/test/extended

I really think that extended should be changed to something more descriptive? Like "qe" or "qe-private" or... I don't know - just throwing out ideas.
It feels as though this is not as integrated as the other tests, but perhaps that doesn't matter.

But the name "extended" just doesn't work for me because of the existing path. Can we come up with something better or more descriptive?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmshort Thanks. Now I change to qe.

@tmshort

Copy link
Copy Markdown
Contributor

Regarding size: most of this is vendor, and well, I suppose there's no way to get around that, so I think we're fine.

@tmshort

Copy link
Copy Markdown
Contributor

/test openshift-e2e-aws-techpreview

@openshift-ci-robotopenshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Sep 17, 2025
@openshift-ciopenshift-ciBot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 17, 2025
@kuiwang02

Copy link
Copy Markdown
ContributorAuthor

Regarding size: most of this is vendor, and well, I suppose there's no way to get around that, so I think we're fine.

@tmshort thanks

@openshift-ci

Copy link
Copy Markdown
Contributor

@kuiwang02: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort

tmshort commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

/approve
@jianzhangbjz can you do verified?

@tmshort

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, kuiwang02, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianzhangbjz

Copy link
Copy Markdown
Contributor

/verified by @jianzhangbjz

@openshift-ci-robotopenshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 18, 2025
@openshift-ci-robot

Copy link
Copy Markdown

@jianzhangbjz: This PR has been marked as verified by @jianzhangbjz.

Details

In response to this:

/verified by @jianzhangbjz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-botBot merged commit ea34b70 into openshift:mainSep 18, 2025
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.lgtmIndicates that a PR is ready to be merged.verifiedSignifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kuiwang02@openshift-ci-robot@tmshort@jianzhangbjz@openshift-merge-robot