Uh oh!
There was an error while loading. Please reload this page.
OCPQE-31553: Test empty affinity erasure and cleanup - #689
Merged
Conversation
@kuiwang02: This pull request references OCPQE-31553 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA deploymentConfig test flow was extended into two phases: Phase 1 verifies selective override behavior where configuration replaces nodeAffinity while preserving other affinity types. Phase 2 adds new validation logic that patches affinity to empty, waits for Deployment reconciliation, and confirms affinity fields become absent in both Deployment and Pod. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
tmshort
commented
Apr 1, 2026
Contributor
/hold |
bandrade
commented
Apr 1, 2026
Contributor
/label qe-approved |
openshift-ci-robot
commented
Apr 1, 2026
@bandrade: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@kuiwang02: This pull request references OCPQE-31553 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tmshort
commented
Apr 1, 2026
Contributor
/approve |
Contributor
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kuiwang02, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tmshort
commented
Apr 1, 2026
Contributor
/unhold |
jianzhangbjz
commented
Apr 2, 2026
Contributor
/lgtm |
Contributor
@kuiwang02: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @Xia-Zhao-rh@jianzhangbjz@bandrade
Summary
Add test verification for affinity fixes (OCPBUGS-76381, OCPBUGS-76383).
Changes
nodeAffinity: {}→ nil)affinity: {}→ entire affinity deleted)Assisted-By: Claude Code