OPRUN-4546: Fix boxcutter finalizer ResourceNames in preflight test

[camilamacedo86]

Motivation: #682 (comment)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 608f989f-ca89-406e-be9b-cf778a1847e6

📥 Commits

Reviewing files that changed from the base of the PR and between afa3354 and f50ba6e.

📒 Files selected for processing (1)

• openshift/tests-extension/test/olmv1-preflight.go

---

Walkthrough

A single line in the RBAC rule construction for the FeatureGateNewOLMBoxCutterRuntime enabled code path is modified in createDeficientClusterRole to set ResourceNames to a derived name using fmt.Sprintf("%s-1", ceName) instead of using ceName directly.

Changes

Cohort / File(s)	Summary
RBAC Rule Modification openshift/tests-extension/test/olmv1-preflight.go	Updated ResourceNames field in createDeficientClusterRole for the FeatureGateNewOLMBoxCutterRuntime enabled path to use fmt.Sprintf("%s-1", ceName) instead of ceName.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@camilamacedo86: This pull request references OPRUN-4546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Motivation: #682 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tmshort]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bandrade]

/label qe-approved
/verified by @bandrade

[openshift-ci-robot]

@camilamacedo86: This pull request references OPRUN-4546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Motivation: #682 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 5f801ad and 2 for PR HEAD f50ba6e in total

[camilamacedo86]

/test openshift-e2e-aws

[camilamacedo86]

/retest-required

[tmshort]

/retest

[camilamacedo86]

/test openshift-e2e-aws

[openshift-ci]

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.