Uh oh!
There was an error while loading. Please reload this page.
NO-ISSUE: Synchronize From Upstream Repositories - #752
Merged
openshift-merge-bot[bot] merged 121 commits intoJun 19, 2026
Merged
NO-ISSUE: Synchronize From Upstream Repositories#752openshift-merge-bot[bot] merged 121 commits into
openshift-merge-bot[bot] merged 121 commits into
Conversation
The default-deny-all-traffic NetworkPolicy in olmv1-system blocks all egress by default. The prometheus-operator pod (label app.kubernetes.io/name: prometheus-operator) had no matching allow policy, so it could not reach the Kubernetes API server. This caused intermittent e2e failures with "dial tcp 10.96.0.1:443: i/o timeout" when the operator was scheduled on the second control-plane node in the 2-node kind cluster used by experimental-e2e. Add an egress-allowing NetworkPolicy for the prometheus-operator pod, matching the existing pattern used for the Prometheus server pod. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add test/e2e/support-bundle.yaml spec file with collectors for cluster diagnostics and pass it to the support-bundle CLI in the e2e workflow. Fixes the "no collectors specified to run" error introduced in #2750. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
openshift-ci-robot
commented
Jun 10, 2026
@openshift-bot: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpgraded Kubernetes modules to v0.36.1, migrated Prometheus deployment from kustomize/scripts to helm, added post-quantum-hybrid TLS curves with e2e validation, extended generated applyconfiguration extraction helpers and parser schema, enhanced CRD upgrade-safety testing, and refactored test infrastructure. ChangesKubernetes 1.36 Upgrade with Prometheus Helm Migration
🎯 4 (Complex) | ⏱️ ~45 minutes Suggested labels: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 errors, 3 warnings)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@helm/prometheus/templates/networkpolicy-prometheus-operator.yml`:
- Around line 8-9: The current NetworkPolicy egress entry is an open rule
(`egress: - {}`) allowing prometheus-operator unrestricted outbound access;
replace that wildcard with explicit egress rules that enumerate only the
required destinations and ports. Update the egress section in
networkpolicy-prometheus-operator.yml to include specific peer selectors
(namespaceSelector or podSelector) and/or ipBlock CIDRs plus required
ports/protocols for scraping and webhooks (e.g., HTTP/HTTPS ports), and add a
default-deny by ensuring policyTypes includes Egress; target the
prometheus-operator podSelector (or label) so only that controller gets the
narrowed egress permissions.
- Around line 13-14: The NetworkPolicy currently only lists "Egress" in the
policyTypes field and therefore does not enforce ingress restrictions; update
the policyTypes array in networkpolicy-prometheus-operator.yml to include both
"Ingress" and "Egress" so the NetworkPolicy will also block inbound traffic as
intended (modify the policyTypes entry that currently contains only Egress to
contain both Ingress and Egress).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 29109d2a-811b-44c8-a1aa-97363cf20467
📒 Files selected for processing (2)
helm/prometheus/templates/networkpolicy-prometheus-operator.ymltest/e2e/support-bundle.yaml
Comment on lines
+8
to
+9
| egress: | ||
| - {} |
There was a problem hiding this comment.
Consider restricting egress destinations.
The egress rule - {} allows prometheus-operator to connect to any destination. While this may be necessary for operational flexibility (metrics scraping, webhooks, etc.), it weakens defense-in-depth by allowing unrestricted outbound connections if the operator is compromised.
If the operator's required egress destinations are known, consider constraining the egress rules to specific namespaces, CIDR blocks, or ports.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@helm/prometheus/templates/networkpolicy-prometheus-operator.yml` around lines
8 - 9, The current NetworkPolicy egress entry is an open rule (`egress: - {}`)
allowing prometheus-operator unrestricted outbound access; replace that wildcard
with explicit egress rules that enumerate only the required destinations and
ports. Update the egress section in networkpolicy-prometheus-operator.yml to
include specific peer selectors (namespaceSelector or podSelector) and/or
ipBlock CIDRs plus required ports/protocols for scraping and webhooks (e.g.,
HTTP/HTTPS ports), and add a default-deny by ensuring policyTypes includes
Egress; target the prometheus-operator podSelector (or label) so only that
controller gets the narrowed egress permissions.
Comment on lines
+13
to
+14
| policyTypes: | ||
| - Egress |
There was a problem hiding this comment.
NetworkPolicy does not block ingress traffic as intended.
The policyTypes field contains only Egress, which means this policy controls egress but does not restrict ingress. According to Kubernetes NetworkPolicy semantics, when Ingress is not included in policyTypes, ingress traffic remains uncontrolled (default allow).
The PR description states this policy "restricts prometheus-operator to egress-only traffic," but the current configuration allows both egress and ingress. To actually block ingress while allowing egress, add Ingress to policyTypes:
🔒 Proposed fix to block ingress traffic
policyTypes:
- Egress
+ - Ingress🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@helm/prometheus/templates/networkpolicy-prometheus-operator.yml` around lines
13 - 14, The NetworkPolicy currently only lists "Egress" in the policyTypes
field and therefore does not enforce ingress restrictions; update the
policyTypes array in networkpolicy-prometheus-operator.yml to include both
"Ingress" and "Egress" so the NetworkPolicy will also block inbound traffic as
intended (modify the policyTypes entry that currently contains only Egress to
contain both Ingress and Egress).
… alias (#2754) Add the two NIST-curve ML-KEM post-quantum hybrids introduced in Go 1.26 to the custom curve map and local constants. Also add "secp256r1" as an alias for "prime256v1" using the IANA name for P-256. Signed-off-by: Todd Short <tshort@redhat.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Bump k8s.io/* staging modules to v0.36.0 - Bump controller-tools to v0.21.0 and crdify to v0.6.0 - Update SchemeBuilder to use k8s.io/apimachinery/pkg/runtime - Suppress no-op diffs from controller-gen version bumps in generated files, CRDs, and manifests - Ignore controller-gen version annotation in CRD generator test Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Predrag Knezevic <pknezevi@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The serial e2e tests require pod restarts which causes the metrics to scrape two sets of results, which the summary generator did not allow. Now, the results from the new pod will be aggregated to the final set. Signed-off-by: Daniel Franz <dfranz@redhat.com>
openshift-botforce-pushed
the
synchronize-upstream
branch
from
June 11, 2026 00:13
a88cedc to
a41183aCompareThere was a problem hiding this comment.
♻️ Duplicate comments (1)
helm/prometheus/templates/networkpolicy-prometheus-operator.yml (1)
13-14:⚠️ Potential issue | 🟠 Major | ⚡ Quick winNetworkPolicy does not block ingress traffic as intended.
The
policyTypesfield contains onlyEgress, which means this policy controls egress but does not restrict ingress. WhenIngressis not included inpolicyTypes, ingress traffic remains uncontrolled (default allow).To block ingress while allowing egress, add
IngresstopolicyTypes:🔒 Proposed fix to block ingress traffic
policyTypes: - Egress + - IngressNote: This NetworkPolicy was added upstream (commit b15d736). If changes are needed, they should be proposed to the upstream repository first.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@helm/prometheus/templates/networkpolicy-prometheus-operator.yml` around lines 13 - 14, The NetworkPolicy currently only lists "Egress" under the policyTypes field so ingress remains allowed; update the policyTypes list in networkpolicy-prometheus-operator.yml to include "Ingress" (i.e., make the list contain both "Ingress" and "Egress") so ingress traffic is subject to the NetworkPolicy rules and will be blocked as intended.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@helm/prometheus/templates/networkpolicy-prometheus-operator.yml`:
- Around line 13-14: The NetworkPolicy currently only lists "Egress" under the
policyTypes field so ingress remains allowed; update the policyTypes list in
networkpolicy-prometheus-operator.yml to include "Ingress" (i.e., make the list
contain both "Ingress" and "Egress") so ingress traffic is subject to the
NetworkPolicy rules and will be blocked as intended.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e1744936-73b8-478f-a12a-c4b81ef2ae29
⛔ Files ignored due to path filters (269)
.bingo/controller-gen.sumis excluded by!**/*.sum.bingo/crd-diff.sumis excluded by!**/*.sumapi/v1/zz_generated.deepcopy.gois excluded by!**/zz_generated*go.sumis excluded by!**/*.sumopenshift/tests-extension/go.sumis excluded by!**/*.sumopenshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/.cliff.tomlis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/.gitignoreis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/CONTRIBUTORS.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/NOTICEis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/README.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/errors.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/ifaces.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/options.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/pointer.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/.gitignoreis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/CONTRIBUTORS.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/README.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/SECURITY.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/go.workis excluded by!**/*.work,!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/jsonname/go_name_provider.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/jsonname/ifaces.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/jsonname/name_provider.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/clustercatalog_types.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/clusterextension_types.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/clusterobjectset_types.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/groupversion_info.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!**/zz_generated*openshift/tests-extension/vendor/google.golang.org/protobuf/encoding/protodelim/protodelim.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/encoding/protojson/decode.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/encoding/prototext/decode.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/internal/descfmt/stringer.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/internal/version/version.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/reflect/protodesc/desc_init.gois excluded by!**/vendor/**openshift/tests-extension/vendor/modules.txtis excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/apiutil/errors.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/apiutil/restmapper.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/applyconfigurations.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/options.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/typed_client.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/scheme/scheme.gois excluded by!**/vendor/**vendor/github.com/fatih/color/color.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fatih/color/color_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/.cliff.tomlis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/CONTRIBUTORS.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/NOTICEis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/ifaces.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/pointer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/CONTRIBUTORS.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/SECURITY.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/go.workis excluded by!**/*.work,!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/jsonname/go_name_provider.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/jsonname/ifaces.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/jsonname/name_provider.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gregjones/httpcache/.travis.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/gregjones/httpcache/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/mxk/go-flowrate/flowrate/flowrate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/mxk/go-flowrate/flowrate/io.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/mxk/go-flowrate/flowrate/util.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/atom/atom.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/atom/table.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/const.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/doc.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/doctype.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/entity.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/escape.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/foreign.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/iter.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/node.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/nodetype_string.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/parse.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/render.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/token.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/encoding/protodelim/protodelim.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/encoding/protojson/decode.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/encoding/prototext/decode.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/descfmt/stringer.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/version/version.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/reflect/protodesc/desc_init.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/register.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/admissionregistration/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/admissionregistration/v1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/admissionregistration/v1alpha1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1alpha1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/apidiscovery/v2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apidiscovery/v2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apidiscovery/v2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apidiscovery/v2beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apidiscovery/v2beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apiserverinternal/v1alpha1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apiserverinternal/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1alpha1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1alpha1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/doc.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/register.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta2/doc.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/register.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta2/zz_generated.model_name.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta2/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/batch/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/certificates/v1beta1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/coordination/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1alpha2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1alpha2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1alpha2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/core/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/core/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/core/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/core/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/core/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/core/v1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/core/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/discovery/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/discovery/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/discovery/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/discovery/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/discovery/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/discovery/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/events/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/events/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/extensions/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/extensions/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/extensions/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/extensions/v1beta1/zz_generated.validations.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/flowcontrol/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1beta2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1beta2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1beta2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1beta3/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1beta3/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/flowcontrol/v1beta3/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/imagepolicy/v1alpha1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/imagepolicy/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/imagepolicy/v1alpha1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/networking/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/networking/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/networking/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/networking/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/networking/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/networking/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/node/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/node/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/node/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/node/v1alpha1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/node/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/node/v1alpha1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/node/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/node/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/node/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/policy/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/policy/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/policy/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/policy/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/policy/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/policy/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/rbac/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/rbac/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/rbac/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/rbac/v1alpha1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/rbac/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/rbac/v1alpha1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/rbac/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/rbac/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/rbac/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/resource/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/resource/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/resource/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/resource/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/resource/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/resource/v1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/resource/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/resource/v1alpha3/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/resource/v1alpha3/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/resource/v1alpha3/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**
📒 Files selected for processing (31)
.bingo/Variables.mk.bingo/controller-gen.mod.bingo/crd-diff.mod.bingo/variables.envMakefileapi/v1/clustercatalog_types.goapi/v1/clusterextension_types.goapi/v1/clusterobjectset_types.goapi/v1/groupversion_info.goapplyconfigurations/api/v1/clustercatalog.goapplyconfigurations/api/v1/clusterextension.goapplyconfigurations/api/v1/clusterobjectset.goapplyconfigurations/internal/internal.gogo.modhack/tools/crd-generator/main_test.gohelm/prometheus/templates/networkpolicy-prometheus-operator.ymlinternal/operator-controller/rukpak/bundle/registryv1bundleconfig.jsoninternal/shared/util/test/utils.gointernal/shared/util/tlsprofiles/tlsprofiles.gointernal/shared/util/tlsprofiles/tlsprofiles_test.goopenshift/tests-extension/go.modtest/e2e/features/tls.featuretest/e2e/features_test.gotest/e2e/steps/steps.gotest/e2e/steps/tls_steps.gotest/e2e/support-bundle.yamltest/internal/summary/artifacts.gotest/internal/summary/summary.gotest/internal/summary/templates/alert.md.tmpltest/internal/summary/templates/mermaid_chart.md.tmpltest/internal/summary/templates/summary.md.tmpl
💤 Files with no reviewable changes (1)
- internal/shared/util/test/utils.go
✅ Files skipped from review due to trivial changes (6)
- .bingo/controller-gen.mod
- .bingo/variables.env
- .bingo/crd-diff.mod
- applyconfigurations/api/v1/clusterextension.go
- applyconfigurations/api/v1/clustercatalog.go
- internal/operator-controller/rukpak/bundle/registryv1bundleconfig.json
🚧 Files skipped from review as they are similar to previous changes (1)
- test/e2e/support-bundle.yaml
…-stack (#2757) Replace the hand-rolled prometheus-operator install script and custom Helm chart (helm/prometheus/) with the official kube-prometheus-stack community chart (v86.2.2), installed from OCI registry. - Disable all unused components (grafana, alertmanager, exporters, default rules, admission webhooks, operator TLS) - Configure Prometheus instance, NetworkPolicies, and kubelet ServiceMonitor via chart values - Add operator-controller and catalogd ServiceMonitors as additionalServiceMonitors using bearerTokenFile (projected SA token) instead of the legacy prometheus-metrics-token Secret - Split PrometheusRules into controller-panic-alerts and controller-resource-alerts so the experimental override only replaces the resource-usage group - Inline the install logic into the Makefile prometheus target - Remove conftest prometheus-networkpolicies.rego policy (NetworkPolicy now managed by the chart) - Remove unused kustomize bingo tooling Co-authored-by: Claude <noreply@anthropic.com>
The lint-helm target depends on $(HELM) but invoked helm directly, which could pick up an unpinned system Helm or fail if Helm isn't on PATH. Use $(HELM) consistently, matching other targets. Co-authored-by: Claude <noreply@anthropic.com>
…2759) OneOf schema changes (e.g. adding required-field constraints) were falling back to the generic "unhandled" comparator, blocking legitimate operator upgrades like Serverless Operator 1.35.0 to 1.36.0. Pin sigs.k8s.io/crdify to latest master (bb9957dbf465) which includes a dedicated oneOf validator. Co-authored-by: Claude <noreply@anthropic.com>
Bumps [platformdirs](https://github.com/tox-dev/platformdirs) from 4.9.6 to 4.10.0. - [Release notes](https://github.com/tox-dev/platformdirs/releases) - [Changelog](https://github.com/tox-dev/platformdirs/blob/main/docs/changelog.rst) - [Commits](tox-dev/platformdirs@4.9.6...4.10.0) --- updated-dependencies: - dependency-name: platformdirs dependency-version: 4.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [idna](https://github.com/kjd/idna) from 3.16 to 3.17. - [Release notes](https://github.com/kjd/idna/releases) - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.md) - [Commits](kjd/idna@v3.16...v3.17) --- updated-dependencies: - dependency-name: idna dependency-version: '3.17' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Todd Short <tshort@redhat.com>
openshift-botforce-pushed
the
synchronize-upstream
branch
from
June 12, 2026 00:19
a41183a to
453f9a4CompareThere was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Makefile (1)
124-127: ⚡ Quick winKeep the Prometheus values under a render-time lint step.
lint-helmnow validates onlyhelm/olmv1, but the new e2e monitoring config lives intestdata/prometheus/values.yamlandtestdata/prometheus/values-experimental.yamland is only exercised later by Line 353. That means a bad values key or chart-schema drift will bypass sanity/lint and fail much later inmake test-e2e.Suggested direction
lint-helm: $(HELM) $(CONFTEST) `#HELP` Run helm linter $(HELM) lint helm/olmv1 (set -euo pipefail; $(HELM) template olmv1 helm/olmv1) | $(CONFTEST) test --policy hack/conftest/policy/ --combine -n main - + $(HELM) template prometheus oci://ghcr.io/prometheus-community/charts/kube-prometheus-stack \+ --version $(PROMETHEUS_CHART_VERSION) \+ -f testdata/prometheus/values.yaml > /dev/null+ $(HELM) template prometheus oci://ghcr.io/prometheus-community/charts/kube-prometheus-stack \+ --version $(PROMETHEUS_CHART_VERSION) \+ -f testdata/prometheus/values.yaml \+ -f testdata/prometheus/values-experimental.yaml > /dev/null🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 124 - 127, The lint-helm target currently only templates helm/olmv1 and skips the Prometheus value files under testdata; update the lint-helm recipe (target name: lint-helm) to also render the Prometheus configs and feed them into conftest so schema/key drift is caught early: run helm template against helm/olmv1 with -f testdata/prometheus/values.yaml and -f testdata/prometheus/values-experimental.yaml (or separately render each file) and pipe those outputs into $(CONFTEST) test --policy hack/conftest/policy/ --combine -n main - just like the existing helm template invocation so both Prometheus values files are validated at lint time.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 348-361: The prometheus Makefile target currently pulls
kube-prometheus-stack from the public OCI registry using only
PROMETHEUS_CHART_VERSION which makes e2e builds depend on a live registry and an
unpinned tag; update the prometheus target to pin the chart by digest (sha256)
or vendor the chart into the repo and reference the local copy instead of
oci://ghcr.io/... with only --version. Specifically, replace the OCI URL/version
usage in the prometheus target (the helm/$(HELM) upgrade --install line that
references PROMETHEUS_CHART_VERSION) with either a fully digested OCI reference
(including `@sha256`:...) built into a new PROMETHEUS_CHART_DIGEST variable or
switch to a local chart path (checked into testdata/prometheus/) and adjust
PROMETHEUS_CHART_VERSION handling accordingly so test-e2e no longer depends on
the live registry.
---
Nitpick comments:
In `@Makefile`:
- Around line 124-127: The lint-helm target currently only templates helm/olmv1
and skips the Prometheus value files under testdata; update the lint-helm recipe
(target name: lint-helm) to also render the Prometheus configs and feed them
into conftest so schema/key drift is caught early: run helm template against
helm/olmv1 with -f testdata/prometheus/values.yaml and -f
testdata/prometheus/values-experimental.yaml (or separately render each file)
and pipe those outputs into $(CONFTEST) test --policy hack/conftest/policy/
--combine -n main - just like the existing helm template invocation so both
Prometheus values files are validated at lint time.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f80d8606-8102-486d-a588-b7b502f562a3
⛔ Files ignored due to path filters (242)
.bingo/controller-gen.sumis excluded by!**/*.sum.bingo/crd-diff.sumis excluded by!**/*.sum.bingo/kustomize.sumis excluded by!**/*.sumapi/v1/zz_generated.deepcopy.gois excluded by!**/zz_generated*go.sumis excluded by!**/*.sumopenshift/tests-extension/go.sumis excluded by!**/*.sumopenshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/.cliff.tomlis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/.gitignoreis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/CONTRIBUTORS.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/NOTICEis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/README.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/errors.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/ifaces.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/options.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/jsonpointer/pointer.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/.gitignoreis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/CONTRIBUTORS.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/README.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/SECURITY.mdis excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/go.workis excluded by!**/*.work,!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/jsonname/go_name_provider.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/jsonname/ifaces.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/go-openapi/swag/jsonname/name_provider.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/clustercatalog_types.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/clusterextension_types.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/clusterobjectset_types.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/groupversion_info.gois excluded by!**/vendor/**openshift/tests-extension/vendor/github.com/operator-framework/operator-controller/api/v1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!**/zz_generated*openshift/tests-extension/vendor/golang.org/x/sync/singleflight/singleflight.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_386.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_amd64.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_arm.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_arm64.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_loong64.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_mips.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_mips64.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_ppc.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_s390x.gois excluded by!**/vendor/**openshift/tests-extension/vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/encoding/protodelim/protodelim.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/encoding/protojson/decode.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/encoding/prototext/decode.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/internal/descfmt/stringer.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/internal/version/version.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/protobuf/reflect/protodesc/desc_init.gois excluded by!**/vendor/**openshift/tests-extension/vendor/modules.txtis excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/apiutil/errors.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/apiutil/restmapper.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/applyconfigurations.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/options.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/client/typed_client.gois excluded by!**/vendor/**openshift/tests-extension/vendor/sigs.k8s.io/controller-runtime/pkg/scheme/scheme.gois excluded by!**/vendor/**vendor/github.com/fatih/color/color.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fatih/color/color_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/.cliff.tomlis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/CONTRIBUTORS.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/NOTICEis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/ifaces.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/jsonpointer/pointer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/CONTRIBUTORS.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/SECURITY.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/go.workis excluded by!**/*.work,!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/jsonname/go_name_provider.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/jsonname/ifaces.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-openapi/swag/jsonname/name_provider.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gregjones/httpcache/.travis.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/gregjones/httpcache/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/mattn/go-sqlite3/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/mattn/go-sqlite3/sqlite3-binding.cis excluded by!**/vendor/**,!vendor/**vendor/github.com/mattn/go-sqlite3/sqlite3-binding.his excluded by!**/vendor/**,!vendor/**vendor/github.com/mattn/go-sqlite3/sqlite3.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/mattn/go-sqlite3/sqlite3_context.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/mattn/go-sqlite3/sqlite3_opt_dbstat.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/mattn/go-sqlite3/sqlite3_opt_unlock_notify.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/mattn/go-sqlite3/sqlite3_opt_vtable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/mxk/go-flowrate/flowrate/flowrate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/mxk/go-flowrate/flowrate/io.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/mxk/go-flowrate/flowrate/util.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/mod/modfile/read.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/mod/modfile/rule.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/atom/atom.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/atom/table.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/const.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/doc.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/doctype.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/entity.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/escape.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/foreign.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/iter.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/node.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/nodetype_string.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/parse.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/render.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/net/html/token.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sync/errgroup/errgroup.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sync/semaphore/semaphore.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sync/singleflight/singleflight.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_386.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_amd64.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_arm.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_arm64.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_loong64.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips64.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_s390x.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/encoding/protodelim/protodelim.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/encoding/protojson/decode.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/encoding/prototext/decode.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/descfmt/stringer.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/version/version.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/reflect/protodesc/desc_init.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admission/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/register.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/admissionregistration/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/admissionregistration/v1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/admissionregistration/v1alpha1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1alpha1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/admissionregistration/v1beta1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/apidiscovery/v2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apidiscovery/v2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apidiscovery/v2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apidiscovery/v2beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apidiscovery/v2beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apiserverinternal/v1alpha1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apiserverinternal/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/apps/v1beta2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1alpha1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1alpha1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authentication/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/authorization/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/doc.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/register.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta2/doc.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/register.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/autoscaling/v2beta2/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta2/zz_generated.model_name.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/autoscaling/v2beta2/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/batch/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/batch/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/certificates/v1beta1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/certificates/v1beta1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/k8s.io/api/coordination/v1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1alpha2/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1alpha2/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1alpha2/types.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1beta1/generated.protois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/k8s.io/api/coordination/v1beta1/types.gois excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (58)
.bingo/Variables.mk.bingo/controller-gen.mod.bingo/crd-diff.mod.bingo/kustomize.mod.bingo/variables.envAGENTS.mdMakefileapi/v1/clustercatalog_types.goapi/v1/clusterextension_types.goapi/v1/clusterobjectset_types.goapi/v1/groupversion_info.goapplyconfigurations/api/v1/clustercatalog.goapplyconfigurations/api/v1/clusterextension.goapplyconfigurations/api/v1/clusterobjectset.goapplyconfigurations/internal/internal.gogo.modhack/conftest/policy/README.mdhack/conftest/policy/prometheus-networkpolicies.regohack/test/install-prometheus.shhack/tools/crd-generator/main_test.gohelm/prom_experimental.yamlhelm/prometheus/Chart.yamlhelm/prometheus/templates/clusterrole-prometheus.ymlhelm/prometheus/templates/clusterrolebinding-prometheus.ymlhelm/prometheus/templates/networkpolicy-prometheus.ymlhelm/prometheus/templates/prometheus-prometheus.ymlhelm/prometheus/templates/prometheusrule-controller-alerts.ymlhelm/prometheus/templates/secret-prometheus-metrics-token.ymlhelm/prometheus/templates/service-prometheus-service.ymlhelm/prometheus/templates/serviceaccount-prometheus.ymlhelm/prometheus/templates/servicemonitor-catalogd-controller-manager-metrics-monitor.ymlhelm/prometheus/templates/servicemonitor-kubelet.ymlhelm/prometheus/templates/servicemonitor-operator-controller-controller-manager-metrics-monitor.ymlhelm/prometheus/values.yamlinternal/operator-controller/rukpak/bundle/registryv1bundleconfig.jsoninternal/operator-controller/rukpak/preflights/crdupgradesafety/crdupgradesafety_test.gointernal/operator-controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-oneof-removed-new.jsoninternal/operator-controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-oneof-removed-old.jsoninternal/operator-controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-oneof-safe-addition-new.jsoninternal/operator-controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-oneof-safe-addition-old.jsoninternal/shared/util/image/helm_test.gointernal/shared/util/test/utils.gointernal/shared/util/tlsprofiles/tlsprofiles.gointernal/shared/util/tlsprofiles/tlsprofiles_test.goopenshift/tests-extension/go.modrequirements.txttest/e2e/features/tls.featuretest/e2e/features_test.gotest/e2e/steps/steps.gotest/e2e/steps/tls_steps.gotest/e2e/support-bundle.yamltest/internal/summary/artifacts.gotest/internal/summary/summary.gotest/internal/summary/templates/alert.md.tmpltest/internal/summary/templates/mermaid_chart.md.tmpltest/internal/summary/templates/summary.md.tmpltestdata/prometheus/values-experimental.yamltestdata/prometheus/values.yaml
💤 Files with no reviewable changes (18)
- helm/prometheus/templates/clusterrole-prometheus.yml
- hack/conftest/policy/prometheus-networkpolicies.rego
- helm/prometheus/templates/clusterrolebinding-prometheus.yml
- helm/prometheus/Chart.yaml
- helm/prometheus/templates/service-prometheus-service.yml
- helm/prometheus/templates/prometheusrule-controller-alerts.yml
- helm/prometheus/values.yaml
- helm/prometheus/templates/networkpolicy-prometheus.yml
- helm/prometheus/templates/serviceaccount-prometheus.yml
- helm/prometheus/templates/servicemonitor-operator-controller-controller-manager-metrics-monitor.yml
- helm/prom_experimental.yaml
- internal/shared/util/test/utils.go
- hack/test/install-prometheus.sh
- helm/prometheus/templates/secret-prometheus-metrics-token.yml
- helm/prometheus/templates/servicemonitor-kubelet.yml
- helm/prometheus/templates/servicemonitor-catalogd-controller-manager-metrics-monitor.yml
- helm/prometheus/templates/prometheus-prometheus.yml
- .bingo/kustomize.mod
✅ Files skipped from review due to trivial changes (8)
- test/e2e/support-bundle.yaml
- internal/operator-controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-oneof-removed-old.json
- internal/operator-controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-oneof-safe-addition-new.json
- .bingo/crd-diff.mod
- internal/operator-controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-oneof-removed-new.json
- AGENTS.md
- internal/operator-controller/rukpak/bundle/registryv1bundleconfig.json
- applyconfigurations/api/v1/clusterobjectset.go
🚧 Files skipped from review as they are similar to previous changes (17)
- .bingo/controller-gen.mod
- test/e2e/features/tls.feature
- test/e2e/features_test.go
- api/v1/clustercatalog_types.go
- applyconfigurations/api/v1/clusterextension.go
- api/v1/clusterobjectset_types.go
- test/e2e/steps/steps.go
- test/e2e/steps/tls_steps.go
- api/v1/groupversion_info.go
- api/v1/clusterextension_types.go
- internal/shared/util/tlsprofiles/tlsprofiles_test.go
- internal/shared/util/tlsprofiles/tlsprofiles.go
- test/internal/summary/summary.go
- hack/tools/crd-generator/main_test.go
- applyconfigurations/api/v1/clustercatalog.go
- openshift/tests-extension/go.mod
- applyconfigurations/internal/internal.go
Comment on lines
+348
to
+361
| prometheus: PROMETHEUS_CHART_VERSION := 86.2.2 | ||
| prometheus: $(HELM) #EXHELP Deploy Prometheus into specified namespace | ||
| ifeq ($(strip $(E2E_SUMMARY_OUTPUT)),) | ||
| @echo "E2E_SUMMARY_OUTPUT unset; skipping prometheus deployment" | ||
| else | ||
| ./hack/test/install-prometheus.sh $(PROMETHEUS_NAMESPACE) $(PROMETHEUS_VERSION) $(VERSION) $(PROMETHEUS_VALUES) | ||
| $(HELM) upgrade --install prometheus oci://ghcr.io/prometheus-community/charts/kube-prometheus-stack \ | ||
| --namespace $(PROMETHEUS_NAMESPACE) --create-namespace \ | ||
| --version $(PROMETHEUS_CHART_VERSION) \ | ||
| -f testdata/prometheus/values.yaml \ | ||
| $(if $(PROMETHEUS_VALUES),-f $(PROMETHEUS_VALUES)) \ | ||
| --set-string 'prometheus.additionalServiceMonitors[1].endpoints[0].tlsConfig.ca.secret.name=$(CATALOGD_CERT_SECRET)' \ | ||
| --set-string 'prometheus.additionalServiceMonitors[1].endpoints[0].tlsConfig.cert.secret.name=$(CATALOGD_CERT_SECRET)' \ | ||
| --set-string 'prometheus.additionalServiceMonitors[1].endpoints[0].tlsConfig.keySecret.name=$(CATALOGD_CERT_SECRET)' \ | ||
| --wait --timeout 5m |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bashset -euo pipefail
# Locate and print the referenced Makefile section with line numbersecho"== Makefile: lines 330-390 =="
nl -ba Makefile | sed -n '330,390p'# Search for the chart reference / variables across the repoechoecho"== Search: kube-prometheus-stack / ghcr.io / PROMETHEUS_* =="
rg -n --hidden --no-ignore -S "kube-prometheus-stack|ghcr\.io/prometheus-community/charts|PROMETHEUS_CHART|PROMETHEUS_VALUES|E2E_SUMMARY_OUTPUT".||true# Search for digest pinning patterns for the same chartechoecho"== Search: any `@sha256` or digest-like pin for kube-prometheus-stack =="
rg -n --hidden --no-ignore -S "kube-prometheus-stack.*`@sha256`:|`@sha256`:".||true# Show relevant env/testdata paths if presentechoecho"== List testdata/prometheus (if exists) =="
ls -la testdata/prometheus 2>/dev/null ||trueRepository: openshift/operator-framework-operator-controller
Length of output: 183
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== Makefile: lines 330-390 =="
awk 'NR>=330 && NR<=390 {printf "%d:%s\n", NR, $0}' Makefile
echoecho"== Search: kube-prometheus-stack / ghcr.io / PROMETHEUS_* =="
rg -n -S --hidden --no-ignore "kube-prometheus-stack|ghcr\.io/prometheus-community/charts|PROMETHEUS_CHART|PROMETHEUS_VALUES|E2E_SUMMARY_OUTPUT".echoecho"== Search: digest pinning patterns for kube-prometheus-stack =="
rg -n -S --hidden --no-ignore "kube-prometheus-stack.*`@sha256`:|kube-prometheus-stack.*`@sha256`|`@sha256`:".||trueechoecho"== List testdata/prometheus (if exists) =="
ls -la testdata/prometheus 2>/dev/null ||trueRepository: openshift/operator-framework-operator-controller
Length of output: 50404
Avoid making e2e setup depend on a live public chart pull.
make prometheus (run by make test-e2e / make test-experimental-e2e) installs kube-prometheus-stack from oci://ghcr.io/prometheus-community/charts/kube-prometheus-stack using only --version $(PROMETHEUS_CHART_VERSION) (86.2.2) with no digest pinning, so the test harness depends on live registry availability and can drift if the tagged OCI artifact changes. Pin the OCI artifact by digest (sha256) or vendor/mirror the chart into the repo (then reference the local artifact). [Makefile: ~346-361]
🧰 Tools
🪛 checkmake (0.3.2)
[warning] 353-353: Target body for "$(HELM) upgrade --install prometheus oci" exceeds allowed length of 5 lines (8).
(maxbodylength)
[warning] 348-348: Target "prometheus" defined multiple times (lines 347 and 348).
(uniquetargets)
[warning] 349-349: Target "prometheus" defined multiple times (lines 347 and 349).
(uniquetargets)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Makefile` around lines 348 - 361, The prometheus Makefile target currently
pulls kube-prometheus-stack from the public OCI registry using only
PROMETHEUS_CHART_VERSION which makes e2e builds depend on a live registry and an
unpinned tag; update the prometheus target to pin the chart by digest (sha256)
or vendor the chart into the repo and reference the local copy instead of
oci://ghcr.io/... with only --version. Specifically, replace the OCI URL/version
usage in the prometheus target (the helm/$(HELM) upgrade --install line that
references PROMETHEUS_CHART_VERSION) with either a fully digested OCI reference
(including `@sha256`:...) built into a new PROMETHEUS_CHART_DIGEST variable or
switch to a local chart path (checked into testdata/prometheus/) and adjust
PROMETHEUS_CHART_VERSION handling accordingly so test-e2e no longer depends on
the live registry.
perdasilva
commented
Jun 12, 2026
Contributor
/retest |
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.67.5 to 0.68.0. - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/CHANGELOG.md) - [Commits](prometheus/common@v0.67.5...v0.68.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-version: 0.68.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ffinity for HA topology Rolling updates in HighlyAvailable clusters leave catalogd and operator-controller unavailable when the only running pod is evicted before its replacement is ready. Fix by defaulting replicas=1 and PDB disabled in the static Helm values (safe for SNO/External topologies, passes the SNO conformance test that asserts exactly one replica in SingleReplica topology mode). Add pod anti-affinity to prefer scheduling replicas on different nodes. cluster-olm-operator detects the cluster's ControlPlaneTopology at startup and overrides these values to replicas=2 and PDB enabled when a HighlyAvailable topology is detected, then re-renders the manifests before starting controllers. When a topology change is observed at runtime (exceedingly rare), the operator exits so its deployment controller restarts it, triggering a fresh Helm render with the correct values for the new topology. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
…etween both-watch-modes scenarios The both-watch-modes test loops over two scenarios (singlens, ownns) inside a single It block and was blocking on full namespace deletion between them. This caused flaky 300s timeouts on GCP techpreview clusters where master nodes run at 94-99% CPU, which starves the namespace controller and makes namespace termination arbitrarily slow. The wait was not guarding anything real: - EnsureCleanupClusterExtension already ensures the CE and CRD are gone; since CE deletion uses ForegroundPropagation, the ClusterObjectSet teardown must complete before the CE disappears, meaning all managed resources (Deployments, Services, etc.) are already deleted at that point. - The singleown bundle installs no ValidatingWebhookConfiguration or MutatingWebhookConfiguration, so there is no webhook admission risk. - Each scenario generates unique namespace names and CRD group suffixes via rand.String(4), so a terminating namespace from scenario 1 cannot collide with or interfere with scenario 2's resources. Trigger both namespace deletions and proceed without waiting. The DeferCleanup registrations that already exist will handle any residual cleanup after the spec exits. Fixes: OCPBUGS-84943 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
- Replace broken test-experimental-e2e target (test/experimental-e2e no longer exists) with /bin/true so triggered jobs always succeed - Pass -timeout=60m to go test; the previous invocation relied on Go's 10m default which is too short for BoxcutterRuntime clusters - Set E2E_STEP_TIMEOUT=15m; BoxcutterRuntime applies resources through sequential phases (CRD must reach Established before the deploy phase starts), making installations slower than the upstream 5m default - Skip ~@CatalogdHA scenarios (require multiple catalogd replicas not present in standard topology) - Skip ~@ProgressDeadline scenarios (require progressDeadlineMinutes < 10 but the OpenShift CRD enforces a minimum of 10) - Skip ~@httpproxy scenarios (too disruptive to cluster networking) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
The e2e-test-registry image is no longer built by CI after openshift/release#78581 removed it from the CI config. The dynamic per-scenario catalog system replaced the pre-built registry image, making this Dockerfile dead code.
It's no longer bring used. Signed-off-by: Todd Short <tshort@redhat.com>
Adds a new test that verifies cluster-olm-operator correctly configures operator-controller and catalogd deployments based on the cluster's control plane topology: - HA topologies (HighlyAvailable, HighlyAvailableArbiter, DualReplica): replicas=2 with a PodDisruptionBudget present - Non-HA topologies (SingleReplica/SNO, External): replicas=1, no PDB Also registers policyv1 in the test scheme to support PDB list queries. Assisted-by: claude Signed-off-by: Todd Short <tshort@redhat.com>
… builders Signed-off-by: Todd Short <tshort@redhat.com>
…ge to be consistent with ART for 5.0 Reconciling with https://github.com/openshift-eng/ocp-build-data/tree/7691ed4dc0b6585b358f9e73fb736ace9a48a286/images/ose-olm-operator-controller.yml
Set catalog image tags to v5.0 for the 4.23/5.0 release. Dynamically discover an installable package from the serving catalogs instead of hardcoding quay-operator v3.13.10, preferring quay-operator, cluster-logging, serverless-operator, logic-operator in that order then alling back to the first available package. Signed-off-by: Todd Short <tshort@redhat.com>
openshift-botforce-pushed
the
synchronize-upstream
branch
from
June 18, 2026 00:11
6897ef7 to
5d4f32eCompareperdasilva
commented
Jun 18, 2026
Contributor
/retest |
perdasilva
commented
Jun 18, 2026
Contributor
/approve |
tmshort
commented
Jun 18, 2026
Contributor
/retest |
rashmigottipati
approved these changes
Jun 18, 2026
rashmigottipati
left a comment
Member
There was a problem hiding this comment.
/verified by @rashmigottipati
openshift-ci-robot
commented
Jun 18, 2026
@rashmigottipati: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-bot, perdasilva, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
rashmigottipati
commented
Jun 19, 2026
Member
/test openshift-e2e-aws |
Contributor
@openshift-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downstream repository has been updated with the following following upstream commits:
The
vendor/directory has been updated and the following commits were carried:@catalogd-updateThis pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.
/assign @openshift/openshift-team-operator-runtime