Uh oh!
There was an error while loading. Please reload this page.
NO-ISSUE: Remove HelmChartSupport feature gate from experimental manifests - #764
Merged
openshift-merge-bot[bot] merged 1 commit intoJul 16, 2026
Conversation
WalkthroughExperimental configurations remove ChangesExperimental feature gates
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci-robot
commented
Jul 15, 2026
@perdasilva: This pull request references Jira Issue OCPBUGS-95281, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
test/e2e/steps/tls_steps.go (2)
106-115: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winUse
exec.CommandContextfor the port-forward process.portForwardalready acceptsctx, butexec.Commandignores it, so a canceled scenario can leavekubectl port-forwardrunning until cleanup runs. Switch toexec.CommandContext(ctx, ...)so the process is stopped when the context is canceled.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/steps/tls_steps.go` around lines 106 - 115, The port-forward process in portForward currently ignores its context. Replace exec.Command with exec.CommandContext using the existing ctx argument, preserving the current kubectl arguments and environment setup.Source: Path instructions
63-73: 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy liftPass
ctxthrough the kubectl helpers.withMetricsPortForwardandconfigureDeploymentCustomTLSstill rely on helper calls that usecontext.Background(), so service discovery, deployment reads, and deployment patches ignore scenario cancellation and can outlive timeout or teardown. ThreadctxintogetMetricsService,getDeploymentContainerArgs, andpatchDeploymentArgs, then pass it tok8sClient.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/steps/tls_steps.go` around lines 63 - 73, Thread the scenario ctx through withMetricsPortForward and configureDeploymentCustomTLS into getMetricsService, getDeploymentContainerArgs, and patchDeploymentArgs, replacing context.Background() in their k8sClient calls with the propagated context. Preserve the existing service discovery, deployment read, and patch behavior while ensuring all kubectl operations honor cancellation and teardown.Source: Path instructions
test/e2e/steps/proxy_steps.go (1)
159-166: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winContext not threaded into proxy helper functions; drops cancellation and demo recording.
configureDeploymentProxyhas a realctxbut its three helpers (kubernetesClusterIP,getDeploymentContainerEnv,setDeploymentEnvVars) all hardcodecontext.Background()fork8sClientcalls instead of accepting/forwarding the caller's context. This silently drops cancellation/deadlines from the scenario context and, if a@demo-tagged scenario reaches these steps, the recorder attached viaRecorderFromContextwon't be found since it's not present oncontext.Background().🔧 Proposed fix: thread ctx through the proxy helpers
-func kubernetesClusterIP() (string, error) {- ip, err := k8sClient(context.Background(), "get", "service", "kubernetes", "-n", "default",+func kubernetesClusterIP(ctx context.Context) (string, error) {+ ip, err := k8sClient(ctx, "get", "service", "kubernetes", "-n", "default", "-o", "jsonpath={.spec.clusterIP}") -func getDeploymentContainerEnv(deploymentName, namespace, containerName string) ([]string, error) {- raw, err := k8sClient(context.Background(), "get", "deployment", deploymentName, "-n", namespace, "-o", "json")+func getDeploymentContainerEnv(ctx context.Context, deploymentName, namespace, containerName string) ([]string, error) {+ raw, err := k8sClient(ctx, "get", "deployment", deploymentName, "-n", namespace, "-o", "json")-func setDeploymentEnvVars(deploymentName, namespace, containerName string, env []string) error {+func setDeploymentEnvVars(ctx context.Context, deploymentName, namespace, containerName string, env []string) error { // Fetch the deployment to find the container index. - raw, err := k8sClient(context.Background(), "get", "deployment", deploymentName, "-n", namespace, "-o", "json")+ raw, err := k8sClient(ctx, "get", "deployment", deploymentName, "-n", namespace, "-o", "json") ... - if _, err := k8sClient(context.Background(), "patch", "deployment", ...); err != nil {+ if _, err := k8sClient(ctx, "patch", "deployment", ...); err != nil { ... - if _, err := k8sClient(context.Background(), "rollout", "status", "deployment", ...); err != nil {+ if _, err := k8sClient(ctx, "rollout", "status", "deployment", ...); err != nil { origEnv, err := getDeploymentContainerEnv(deployName, olmNamespace, "manager") + origEnv, err := getDeploymentContainerEnv(ctx, deployName, olmNamespace, "manager") ... - k8sIP, err := kubernetesClusterIP()+ k8sIP, err := kubernetesClusterIP(ctx) ... - return setDeploymentEnvVars(deployName, olmNamespace, "manager", newEnv)+ return setDeploymentEnvVars(ctx, deployName, olmNamespace, "manager", newEnv)Also applies to: 170-191, 197-257, 286-338
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/steps/proxy_steps.go` around lines 159 - 166, Thread the caller’s context through configureDeploymentProxy and its helpers kubernetesClusterIP, getDeploymentContainerEnv, and setDeploymentEnvVars. Add a context parameter to each helper, pass it through every internal call, and replace context.Background() in k8sClient invocations so cancellation, deadlines, and recorder data are preserved.
🧹 Nitpick comments (3)
Makefile (1)
718-727: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
demo-svg: unpinned image/tool and silent failures.
node:alpineandnpx --yes svg-term-cliare unpinned (mutable tag / latest npm release), and theforloop doesn't checkdocker run's exit status, so a failed conversion is silently skipped rather than failing the target.♻️ Optional hardening
`@for` cast in $(DEMO_OUTPUT_DIR)/*.cast; do \ svg=$${cast%.cast}.svg; \ echo "Converting $$(basename $$cast) -> $$(basename $$svg)"; \ - docker run --rm -v $(DEMO_OUTPUT_DIR):/data node:alpine \- npx --yes svg-term-cli --in /data/$$(basename $$cast) --out /data/$$(basename $$svg) --window; \+ docker run --rm -v $(DEMO_OUTPUT_DIR):/data node:alpine@sha256:<digest> \+ npx --yes svg-term-cli@<version> --in /data/$$(basename $$cast) --out /data/$$(basename $$svg) --window \+ || { echo "svg-term-cli failed for $$cast"; exit 1; }; \ done🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 718 - 727, Update the demo-svg target to use a pinned Docker image and pinned svg-term-cli version, and make each docker run failure propagate so the Make target exits nonzero instead of silently continuing. Preserve the existing cast-to-SVG conversion and output mapping in the loop.test/e2e/steps/upgrade_steps.go (1)
269-291: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicated catalog-condition step logic across two files.
ScenarioCatalogReportsConditionandCatalogReportsConditionWithoutReasonimplement the same "resolve catalog name (scenario map or cluster existence check) →waitForCondition→ record jsonpath viaRecorderFromContext" flow, differing only in whether aconditionReasonis passed.
test/e2e/steps/upgrade_steps.go#L269-L291: extract the shared resolve/wait/record logic into a helper parameterized by an optionalconditionReason, and have this function call it.test/e2e/steps/demo_steps.go#L53-L79: call the same shared helper withconditionReason = nilinstead of re-implementing the flow.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/steps/upgrade_steps.go` around lines 269 - 291, Extract the shared catalog condition flow from ScenarioCatalogReportsCondition into a helper that resolves the catalog name, waits via waitForCondition, and records the condition output, accepting an optional conditionReason. Update test/e2e/steps/upgrade_steps.go:269-291 to call the helper with the reason, and update test/e2e/steps/demo_steps.go:53-79 to call it with conditionReason = nil instead of duplicating the flow.test/e2e/steps/demo_steps.go (1)
27-51: 🔒 Security & Privacy | 🔵 Trivial | 💤 Low valueShell interpolation of step-supplied strings into
bash -c.
bash()runsexec.CommandContext(ctx, "bash", "-c", script), andcatalogCurlJqbuildsscriptviafmt.SprintfembeddingcatalogName/packageNameunescaped (e.g.CatalogContainsSomePackages,PackageHasSomeChannels,PackageHasSomeBundles). Any scenario/package name containing shell metacharacters (`,$(),;) would be executed as shell code. Exploitability is limited here since these strings originate from.featurefiles in the repo, but this is exactly the exec-with-shell pattern flagged by static analysis and the injection-prevention guideline.As per path instructions,
**/*.{py,js,ts,go,rs,java,rb,php,kt,swift,cs}: "Command: no shell=True, os.system, or backtick exec with user input". Based on learnings from static analysis: OpenGrep/ast-grep flaggedexec.CommandContext(ctx, "bash", "-c", script)at Line 28 and the underlying pattern at Line 27 as command injection risks.🔧 Possible mitigation
- script := fmt.Sprintf(- `curl -s -k https://%s/catalogs/%s/api/v1/all | jq -s '%s'`,- addr, catalogName, jqFilter,- )- return bash(ctx, script)+ // Prefer exec.CommandContext without a shell, or fetch+parse JSON in Go+ // instead of shelling out to curl|jq with interpolated names.Also applies to: 112-122
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/steps/demo_steps.go` around lines 27 - 51, Remove the shell-interpolation risk in bash and the callers such as catalogCurlJq, CatalogContainsSomePackages, PackageHasSomeChannels, and PackageHasSomeBundles. Stop embedding step-supplied catalogName/packageName values into a bash -c script; invoke the required commands directly with exec.CommandContext arguments or otherwise pass values as safely separated arguments, while preserving the existing command output, error, timing, and recording behavior.Sources: Path instructions, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/draft/howto/enable-webhook-support.md`:
- Around line 55-59: Update the asciinema-player embed’s file path in the
webhook support documentation to use ../../demos/webhook-support.cast, ensuring
it resolves to docs/demos/ while leaving the rest of the embed unchanged.
In `@test/e2e/steps/asciicast_recorder.go`:
- Around line 66-79: The recorder currently timestamps completed commands and
step markers with the post-execution time, causing Stop to apply the command
duration twice. Update RecordCommand and RecordCommandWithInput to capture or
receive each command’s start time and use it for their entries, then ensure
CommitStep uses that preserved start timestamp for the step marker instead of
inheriting the offset.
In `@test/e2e/steps/steps.go`:
- Around line 245-305: Update k8sClient and k8scliWithInput to detect kubectl
commands targeting secret or secrets resources, and skip raw stdout/stderr
logging and recorder calls for those commands. Preserve command execution, error
propagation, ExitError stderr injection, and recording of non-secret commands;
ensure secret command output is not passed to logger.V or
RecordCommand/RecordCommandWithInput.
---
Outside diff comments:
In `@test/e2e/steps/proxy_steps.go`:
- Around line 159-166: Thread the caller’s context through
configureDeploymentProxy and its helpers kubernetesClusterIP,
getDeploymentContainerEnv, and setDeploymentEnvVars. Add a context parameter to
each helper, pass it through every internal call, and replace
context.Background() in k8sClient invocations so cancellation, deadlines, and
recorder data are preserved.
In `@test/e2e/steps/tls_steps.go`:
- Around line 106-115: The port-forward process in portForward currently ignores
its context. Replace exec.Command with exec.CommandContext using the existing
ctx argument, preserving the current kubectl arguments and environment setup.
- Around line 63-73: Thread the scenario ctx through withMetricsPortForward and
configureDeploymentCustomTLS into getMetricsService, getDeploymentContainerArgs,
and patchDeploymentArgs, replacing context.Background() in their k8sClient calls
with the propagated context. Preserve the existing service discovery, deployment
read, and patch behavior while ensuring all kubectl operations honor
cancellation and teardown.
---
Nitpick comments:
In `@Makefile`:
- Around line 718-727: Update the demo-svg target to use a pinned Docker image
and pinned svg-term-cli version, and make each docker run failure propagate so
the Make target exits nonzero instead of silently continuing. Preserve the
existing cast-to-SVG conversion and output mapping in the loop.
In `@test/e2e/steps/demo_steps.go`:
- Around line 27-51: Remove the shell-interpolation risk in bash and the callers
such as catalogCurlJq, CatalogContainsSomePackages, PackageHasSomeChannels, and
PackageHasSomeBundles. Stop embedding step-supplied catalogName/packageName
values into a bash -c script; invoke the required commands directly with
exec.CommandContext arguments or otherwise pass values as safely separated
arguments, while preserving the existing command output, error, timing, and
recording behavior.
In `@test/e2e/steps/upgrade_steps.go`:
- Around line 269-291: Extract the shared catalog condition flow from
ScenarioCatalogReportsCondition into a helper that resolves the catalog name,
waits via waitForCondition, and records the condition output, accepting an
optional conditionReason. Update test/e2e/steps/upgrade_steps.go:269-291 to call
the helper with the reason, and update test/e2e/steps/demo_steps.go:53-79 to
call it with conditionReason = nil instead of duplicating the flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b94ca144-c28d-4785-96be-86cdb3f403da
⛔ Files ignored due to path filters (281)
go.sumis excluded by!**/*.sumhack/tools/test-profiling/go.sumis excluded by!**/*.sumhack/tools/test-profiling/vendor/golang.org/x/net/html/escape.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/iter.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/node.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/nodetype_string.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/parse.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/render.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/token.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/README.mdis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/client_conn_pool.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/client_priority_go126.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/client_priority_go127.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/clientconn.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config_go124.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config_go125.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config_go126.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config_pre_go124.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/frame.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/gotrack.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/http2.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/server.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/server_common.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/server_wrap.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/timer.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/transport.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/transport_common.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/transport_wrap.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_common.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_priority_rfc7540.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_priority_rfc9218.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_random.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_roundrobin.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/go118.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/idna.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/idna9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/pre_go118.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/punycode.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables10.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables11.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables12.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables13.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables15.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables17.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/trie12.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/trie13.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/internal/httpcommon/request.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/internal/httpsfv/httpsfv.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/internal/socks/socks.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/websocket/hybi.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/plan9/pwd_go15_plan9.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/plan9/pwd_plan9.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/plan9/syscall_plan9.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/affinity_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/fdset.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ifreq_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ioctl_signed.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ioctl_unsigned.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/mkall.shis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/mkerrors.shis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/readv_unix.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_darwin.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux_loong64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_netbsd.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_openbsd.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_solaris.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_unix.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_386.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_mips.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_386.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_loong64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_mips.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_mips64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_mips64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_mipsle.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_ppc.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_s390x.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_sparc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_386.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_loong64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_mips.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_mips64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_ppc.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_s390x.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_netbsd_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/aliases.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/dll_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/security_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/syscall_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/types_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/zsyscall_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/term/term_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/term/terminal.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/secure/bidirule/bidirule.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/secure/bidirule/bidirule10.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/secure/bidirule/bidirule9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/core.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables10.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables11.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables12.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables13.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables15.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables17.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/forminfo.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables10.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables11.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables12.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables15.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables17.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/modules.txtis excluded by!**/vendor/**openshift/tests-extension/go.sumis excluded by!**/*.sumopenshift/tests-extension/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/mux.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/tracetransform/attribute.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/client.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/observ/instrumentation.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig/options.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/version.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/options.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/version.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/builtin.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/container.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/env.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/host_id.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/host_id_exec.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/os.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/os_unix.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/os_windows.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/process.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/batch_span_processor.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/batch_span_processor.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/simple_span_processor.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/tracer.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/provider.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/sampling.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/span.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/span_limits.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/version.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/semconv/v1.41.0/otelconv/metric.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/modules.txtis excluded by!**/vendor/**vendor/github.com/google/go-containerregistry/internal/gzip/zip.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/internal/limit/limit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/name/registry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/name/repository.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/registry/blobs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/registry/blobs_disk.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/layout/blob.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/mutate/mutate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/catalog.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/fetcher.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/referrers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/bearer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/tarball/image.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/tarball/write.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/mux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/flate/dict_decoder.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/flate/inflate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/gzhttp/compress.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/huff0/build_table.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/internal/snapref/decode.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/dict.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/enc_base.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/enc_best.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/enc_better.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/enc_dfast.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/enc_fast.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/enc_jobs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/encoder.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/encoder_options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/fse_decoder_amd64.sis excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/fse_decoder_arm64.sis excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/fse_decoder_asm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/fse_decoder_generic.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/seqdec_amd64.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/seqdec_amd64.sis excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/seqdec_arm64.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/seqdec_arm64.sis excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/seqdec_asm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/zstd/seqdec_generic.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sigstore/fulcio/pkg/certificate/extensions.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sigstore/protobuf-specs/gen/pb-go/common/v1/sigstore_common.pb.gois excluded by!**/*.pb.go,!**/gen/**,!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/tracetransform/attribute.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/client.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/observ/instrumentation.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig/options.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/version.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/options.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/version.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/builtin.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/container.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/env.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_exec.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_unix.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_windows.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/process.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/batch_span_processor.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/batch_span_processor.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/simple_span_processor.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/tracer.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/provider.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/sampling.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/span.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/span_limits.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/version.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.41.0/otelconv/metric.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/tools/internal/stdlib/manifest.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/tools/internal/typesinternal/zerovalue.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/annotations/client.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/helm.sh/helm/v3/pkg/lint/rules/template.gois excluded by!**/vendor/**,!vendor/**vendor/k8s.io/apimachinery/pkg/api/validation/path/name.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (68)
.gitignoreMakefileREADME.mddocs/draft/howto/enable-helm-chart-support.mddocs/draft/howto/enable-webhook-support.mddocs/draft/howto/single-ownnamespace-install.mdgo.modhack/demo/catalogd-demo-script.shhack/demo/catalogd-metas-demo-script.shhack/demo/generate-asciidemo.shhack/demo/graphql-demo-script.shhack/demo/graphql-demo-server/main.gohack/demo/gzip-demo-script.shhack/demo/own-namespace-demo-script.shhack/demo/resources/own-namespace-demo.yamlhack/demo/resources/single-namespace-demo.yamlhack/demo/resources/synthetic-user-perms/argocd-clusterextension.yamlhack/demo/resources/synthetic-user-perms/cegroup-admin-binding.yamlhack/demo/resources/webhook-provider-certmanager/mutating-webhook-test.yamlhack/demo/resources/webhook-provider-certmanager/validating-webhook-test.yamlhack/demo/resources/webhook-provider-certmanager/webhook-operator-catalog.yamlhack/demo/resources/webhook-provider-certmanager/webhook-operator-extension.yamlhack/demo/single-namespace-demo-script.shhack/demo/synthetic-user-cluster-admin-demo-script.shhack/demo/webhook-provider-certmanager-demo-script.shhack/tools/test-profiling/go.modhelm/experimental.yamlhelm/olmv1/values.yamlhelm/tilt.yamlinternal/catalogd/graphql/graphql.gointernal/operator-controller/applier/helm.gointernal/operator-controller/features/features.gointernal/operator-controller/rukpak/render/registryv1/generators/generators.gointernal/operator-controller/rukpak/render/registryv1/generators/generators_test.gointernal/shared/util/image/cache.gointernal/shared/util/image/cache_test.gointernal/shared/util/image/helm.gointernal/shared/util/image/helm_test.gointernal/shared/util/image/pull.gomanifests/experimental-e2e.yamlmanifests/experimental.yamlmanifests/standard-e2e.yamlmanifests/standard.yamlmkdocs.ymlopenshift/helm/experimental.yamlopenshift/operator-controller/manifests-experimental.yamlopenshift/operator-controller/manifests.yamlopenshift/tests-extension/go.modrequirements.txtscripts/install.tpl.shtest/e2e/features/demos.featuretest/e2e/features_test.gotest/e2e/steps/asciicast_hooks.gotest/e2e/steps/asciicast_recorder.gotest/e2e/steps/demo_steps.gotest/e2e/steps/ha_steps.gotest/e2e/steps/hooks.gotest/e2e/steps/proxy_steps.gotest/e2e/steps/steps.gotest/e2e/steps/tls_steps.gotest/e2e/steps/upgrade_steps.gotest/regression/convert/testdata/expected-manifests/argocd-operator.v0.6.0/all-namespaces/11_deployment_argocd-operator-controller-manager.yamltest/regression/convert/testdata/expected-manifests/argocd-operator.v0.6.0/own-namespace/09_deployment_argocd-operator-controller-manager.yamltest/regression/convert/testdata/expected-manifests/argocd-operator.v0.6.0/single-namespace/09_deployment_argocd-operator-controller-manager.yamltest/regression/convert/testdata/expected-manifests/argocd-operator.v0.6.0/with-deploymentconfig-options/11_deployment_argocd-operator-controller-manager.yamltest/regression/convert/testdata/expected-manifests/argocd-operator.v0.6.0/with-empty-affinity-subtype/11_deployment_argocd-operator-controller-manager.yamltest/regression/convert/testdata/expected-manifests/argocd-operator.v0.6.0/with-empty-affinity/11_deployment_argocd-operator-controller-manager.yamltest/regression/convert/testdata/expected-manifests/webhook-operator.v0.0.5/all-webhook-types/05_deployment_webhook-operator-controller-manager.yaml
💤 Files with no reviewable changes (35)
- hack/demo/resources/webhook-provider-certmanager/webhook-operator-catalog.yaml
- hack/demo/resources/webhook-provider-certmanager/validating-webhook-test.yaml
- hack/demo/graphql-demo-script.sh
- hack/demo/own-namespace-demo-script.sh
- hack/demo/resources/single-namespace-demo.yaml
- hack/demo/synthetic-user-cluster-admin-demo-script.sh
- hack/demo/resources/synthetic-user-perms/cegroup-admin-binding.yaml
- docs/draft/howto/enable-helm-chart-support.md
- hack/demo/catalogd-metas-demo-script.sh
- hack/demo/webhook-provider-certmanager-demo-script.sh
- hack/demo/graphql-demo-server/main.go
- hack/demo/resources/webhook-provider-certmanager/mutating-webhook-test.yaml
- hack/demo/gzip-demo-script.sh
- hack/demo/generate-asciidemo.sh
- helm/tilt.yaml
- hack/demo/catalogd-demo-script.sh
- openshift/helm/experimental.yaml
- internal/shared/util/image/helm_test.go
- hack/demo/resources/own-namespace-demo.yaml
- hack/demo/single-namespace-demo-script.sh
- manifests/standard-e2e.yaml
- manifests/experimental-e2e.yaml
- internal/operator-controller/features/features.go
- openshift/operator-controller/manifests.yaml
- manifests/standard.yaml
- helm/olmv1/values.yaml
- internal/shared/util/image/helm.go
- internal/shared/util/image/cache_test.go
- openshift/operator-controller/manifests-experimental.yaml
- hack/demo/resources/synthetic-user-perms/argocd-clusterextension.yaml
- helm/experimental.yaml
- internal/shared/util/image/pull.go
- internal/operator-controller/applier/helm.go
- hack/demo/resources/webhook-provider-certmanager/webhook-operator-extension.yaml
- manifests/experimental.yaml
Comment on lines
+55
to
+59
| ```asciinema-player | ||
| { | ||
| "file": "../../../demos/webhook-support.cast" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bashset -euo pipefail
printf'Repo files of interest:\n'
git ls-files docs/draft/howto/enable-webhook-support.md .gitignore docs/demos 2>/dev/null ||trueprintf'\nLine numbers in docs/draft/howto/enable-webhook-support.md:\n'
cat -n docs/draft/howto/enable-webhook-support.md | sed -n '45,70p'printf'\nRelevant .gitignore lines:\n'
cat -n .gitignore | sed -n '1,220p'printf'\nAny cast files under docs/demos or demos:\n'
find docs demos -type f \( -name '*.cast' -o -name '*.Cast'\)2>/dev/null | sort ||trueRepository: openshift/operator-framework-operator-controller
Length of output: 2409
🏁 Script executed:
#!/bin/bashset -euo pipefail
printf'Search for asciinema-player usage and file-path conventions:\n'
rg -n --hidden --glob '!**/.git/**''asciinema-player|"\s*file"\s*:' docs .github .2>/dev/null ||trueRepository: openshift/operator-framework-operator-controller
Length of output: 1628
🏁 Script executed:
#!/bin/bashset -euo pipefail
printf'mkdocs config excerpts around docs_dir and plugin config:\n'
cat -n mkdocs.yml | sed -n '1,140p'printf'\nSibling how-to page excerpt:\n'
cat -n docs/draft/howto/single-ownnamespace-install.md | sed -n '20,45p'printf'\nSearch for references to docs/demos or repo-root demos in docs/config:\n'
rg -n --hidden --glob '!**/.git/**''docs/demos|/demos/|demos/' mkdocs.yml docs .github requirements.txt 2>/dev/null ||trueRepository: openshift/operator-framework-operator-controller
Length of output: 4672
🌐 Web query:
mkdocs-asciinema-player file path relative markdown current directory
💡 Result:
In the mkdocs-asciinema-player plugin, file paths for.cast files are resolved relative to the location of the current Markdown file [1]. You can specify the path to your.cast file within the asciinema-player code block using standard relative path syntax [2]. For example: asciinema-player { "file": "../assets/asciinema/example.cast" } The file value can also be a remote URL if the cast file is hosted online [1]. Keep in mind that the file parameter is required for every individual asciinema-player block [3][4].
Citations:
- 1: https://pa-decarvalho.github.io/mkdocs-asciinema-player/getting-started/
- 2: https://github.com/pa-decarvalho/mkdocs-asciinema-player/blob/main/docs/themes.md
- 3: https://pa-decarvalho.github.io/mkdocs-asciinema-player/setup/
- 4: https://github.com/pa-decarvalho/mkdocs-asciinema-player/blob/main/docs/setup.md
Relative cast path should point at docs/demos/../../../demos/webhook-support.cast climbs out of docs/ to the repo root. Use ../../demos/webhook-support.cast so the asciinema embed can load the cast from docs/demos/.
Proposed fix
```asciinema-player
{
- "file": "../../../demos/webhook-support.cast"+ "file": "../../demos/webhook-support.cast"
}
</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/draft/howto/enable-webhook-support.md` around lines 55 - 59, Update the
asciinema-player embed’s file path in the webhook support documentation to use
../../demos/webhook-support.cast, ensuring it resolves to docs/demos/ while
leaving the rest of the embed unchanged.
Comment on lines
+66
to
+79
| func (r *AsciiCastRecorder) CommitStep() { | ||
| if len(r.stepBuffer) == 0 { | ||
| return | ||
| } | ||
| comment := recordedEntry{ | ||
| command: "", | ||
| stdout: "\033[34m# " + r.stepText + "\033[0m", // ANSI blue for step comments | ||
| timestamp: r.stepBuffer[0].timestamp, | ||
| } | ||
| r.entries = append(r.entries, comment) | ||
| r.entries = append(r.entries, r.stepBuffer...) | ||
| r.stepBuffer = nil | ||
| r.stepIndex = nil | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash# Inspect callers to confirm whether `duration` is measured before RecordCommand# is invoked (i.e., timestamp is captured after the command already ran).
rg -n -B3 -A3 '\.RecordCommand(WithInput)?\(' test/e2e/stepsRepository: openshift/operator-framework-operator-controller
Length of output: 1412
🏁 Script executed:
#!/bin/bashset -euo pipefail
forfin test/e2e/steps/demo_steps.go test/e2e/steps/steps.go test/e2e/steps/asciicast_recorder.go;doecho"===== $f ====="
wc -l "$f"doneecho"===== demo_steps.go snippet ====="
sed -n '1,120p' test/e2e/steps/demo_steps.go
echo"===== steps.go snippets ====="
sed -n '220,330p' test/e2e/steps/steps.go
echo"===== asciicast_recorder.go snippet ====="
sed -n '1,260p' test/e2e/steps/asciicast_recorder.goRepository: openshift/operator-framework-operator-controller
Length of output: 13422
🏁 Script executed:
#!/bin/bashset -euo pipefail
nl -ba test/e2e/steps/demo_steps.go | sed -n '1,120p'echo'---'
nl -ba test/e2e/steps/steps.go | sed -n '230,330p'echo'---'
nl -ba test/e2e/steps/asciicast_recorder.go | sed -n '1,260p'Repository: openshift/operator-framework-operator-controller
Length of output: 226
test/e2e/steps/asciicast_recorder.go: store the command start timeRecordCommand and RecordCommandWithInput are called after the command has already finished, but they stamp entries with time.Now(). Stop() then treats that timestamp as the prompt time and adds duration again for output, so prompts land after execution and output is delayed by an extra duration; CommitStep() inherits the same offset for the step marker. Capture the start time instead (or pass it in directly), and apply the same change in RecordCommandWithInput.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/e2e/steps/asciicast_recorder.go` around lines 66 - 79, The recorder
currently timestamps completed commands and step markers with the post-execution
time, causing Stop to apply the command duration twice. Update RecordCommand and
RecordCommandWithInput to capture or receive each command’s start time and use
it for their entries, then ensure CommitStep uses that preserved start timestamp
for the step marker instead of inheriting the offset.
Comment on lines
245
to
305
| func k8sClient(ctx context.Context, args ...string) (string, error) { | ||
| cmd := exec.CommandContext(ctx, k8sCli, args...) | ||
| logger.V(1).Info("Running", "command", strings.Join(cmd.Args, " ")) | ||
| cmd.Env = append(os.Environ(), fmt.Sprintf("KUBECONFIG=%s", kubeconfigPath)) | ||
| b, err := cmd.Output() | ||
| var stdoutBuf, stderrBuf bytes.Buffer | ||
| cmd.Stdout = &stdoutBuf | ||
| cmd.Stderr = &stderrBuf | ||
| start := time.Now() | ||
| err := cmd.Run() | ||
| elapsed := time.Since(start) | ||
| output := stdoutBuf.String() | ||
| stderrStr := stderrBuf.String() | ||
| if err != nil { | ||
| logger.V(1).Info("Failed to run", "command", strings.Join(cmd.Args, " "), "stderr", stderrOutput(err), "error", err) | ||
| logger.V(1).Info("Failed to run", "command", strings.Join(cmd.Args, " "), "stderr", stderrStr, "error", err) | ||
| // Inject stderr into ExitError so stderrOutput() can extract it. | ||
| // cmd.Run() with explicit cmd.Stderr does not populate ExitError.Stderr. | ||
| var exitErr *exec.ExitError | ||
| if errors.As(err, &exitErr) { | ||
| exitErr.Stderr = []byte(stderrStr) | ||
| } | ||
| } | ||
| output := string(b) | ||
| logger.V(1).Info("Output", "command", strings.Join(cmd.Args, " "), "output", output) | ||
| if rec := RecorderFromContext(ctx); rec != nil { | ||
| rec.RecordCommand(strings.Join(cmd.Args, " "), output, stderrStr, elapsed) | ||
| } | ||
| return output, err | ||
| } | ||
| func k8scliWithInput(yaml string, args ...string) (string, error) { | ||
| cmd := exec.Command(k8sCli, args...) | ||
| func k8scliWithInput(ctx context.Context, yaml string, args ...string) (string, error) { | ||
| cmd := exec.CommandContext(ctx, k8sCli, args...) | ||
| cmd.Stdin = bytes.NewBufferString(yaml) | ||
| cmd.Env = append(os.Environ(), fmt.Sprintf("KUBECONFIG=%s", kubeconfigPath)) | ||
| b, err := cmd.Output() | ||
| return string(b), err | ||
| var stdoutBuf, stderrBuf bytes.Buffer | ||
| cmd.Stdout = &stdoutBuf | ||
| cmd.Stderr = &stderrBuf | ||
| start := time.Now() | ||
| err := cmd.Run() | ||
| elapsed := time.Since(start) | ||
| output := stdoutBuf.String() | ||
| stderrStr := stderrBuf.String() | ||
| if err != nil { | ||
| var exitErr *exec.ExitError | ||
| if errors.As(err, &exitErr) { | ||
| exitErr.Stderr = []byte(stderrStr) | ||
| } | ||
| } | ||
| if rec := RecorderFromContext(ctx); rec != nil { | ||
| rec.RecordCommandWithInput(strings.Join(cmd.Args, " "), yaml, output, stderrStr, elapsed) | ||
| } | ||
| return output, err | ||
| } |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Unconditional full-output logging/recording can leak Secret data (and into published demo docs).
k8sClient/k8scliWithInput log the complete raw stdout/stderr for every kubectl invocation via logger.V(1).Info("Output", ...), and also feed it to rec.RecordCommand/RecordCommandWithInput when a recorder is attached. Several call sites in this file run get secret(s) ... -o json (e.g. listReferredSecrets, resolveObjectRef, helmReleaseSecretForExtension), whose output includes full Secret data. Since this is the single choke point for all kubectl calls, any such command's output is unconditionally logged, and — per the new asciicast pipeline in this PR — could end up embedded in a published demo .cast recording if a @demo scenario's flow ever touches one of these paths.
Consider redacting/skipping output logging and recording when the command targets secret/secrets resources.
🔒 Proposed guard against logging/recording Secret output
+func isSecretCommand(args []string) bool {+ for _, a := range args {+ if a == "secret" || a == "secrets" {+ return true+ }+ }+ return false+}+
func k8sClient(ctx context.Context, args ...string) (string, error) {
...
- logger.V(1).Info("Output", "command", strings.Join(cmd.Args, " "), "output", output)+ logOutput := output+ if isSecretCommand(args) {+ logOutput = "[REDACTED: secret resource output omitted from logs]"+ }+ logger.V(1).Info("Output", "command", strings.Join(cmd.Args, " "), "output", logOutput)
if rec := RecorderFromContext(ctx); rec != nil {
- rec.RecordCommand(strings.Join(cmd.Args, " "), output, stderrStr, elapsed)+ rec.RecordCommand(strings.Join(cmd.Args, " "), logOutput, stderrStr, elapsed)
}As per path instructions, "Flag logging that may expose passwords, tokens, API keys, PII (email, SSN, credit card), session IDs, internal hostnames, or customer data."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/e2e/steps/steps.go` around lines 245 - 305, Update k8sClient and
k8scliWithInput to detect kubectl commands targeting secret or secrets
resources, and skip raw stdout/stderr logging and recorder calls for those
commands. Preserve command execution, error propagation, ExitError stderr
injection, and recording of non-secret commands; ensure secret command output is
not passed to logger.V or RecordCommand/RecordCommandWithInput.
Source: Path instructions
perdasilva
commented
Jul 15, 2026
ContributorAuthor
/retest |
tmshort
commented
Jul 15, 2026
Contributor
Per's openshift/operator-framework-operator-controller@973e0e3 LGTM to me. But I have code in coming down from upstream, so I can't give an |
openshift-ci-robot
commented
Jul 15, 2026
@perdasilva: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…ntal manifests HelmChartSupport was removed upstream in dbc9b4a but the downstream experimental.yaml values file and its generated manifest still referenced it, causing operator-controller to crash on startup with: invalid argument "HelmChartSupport=false" for "--feature-gates" flag: unrecognized feature gate: HelmChartSupport This made the OLM cluster operator Degraded/Unavailable and caused cluster installation to time out (exit code 6). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
perdasilvaforce-pushed
the
fix/remove-helmchartsupport-feature-gate
branch
from
July 15, 2026 13:31
973e0e3 to
9bb156dComparetmshort
commented
Jul 15, 2026
Contributor
/lgtm This can be verified by CI. |
tmshort
commented
Jul 15, 2026
Contributor
/retest |
1 similar comment
tmshort
commented
Jul 16, 2026
Contributor
/retest |
tmshort
commented
Jul 16, 2026
Contributor
/override ci/prow/e2e-aws-upgrade-ovn-signle-node |
Contributor
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tmshort
commented
Jul 16, 2026
Contributor
/override ci/prow/e2e-aws-upgrade-ovn-single-node |
tmshort
commented
Jul 16, 2026
Contributor
/verified by CI |
openshift-ci-robot
commented
Jul 16, 2026
@tmshort: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tmshort
commented
Jul 16, 2026
Contributor
/label acknowledge-critical-fixes-only |
Contributor
@tmshort: Overrode contexts on behalf of tmshort: ci/prow/e2e-aws-upgrade-ovn-single-node DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Uh oh!
There was an error while loading. Please reload this page.
Contributor
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HelmChartSupportwas removed upstream in dbc9b4a butopenshift/helm/experimental.yamlstill listed it as a disabled feature gate, causingoperator-controller-controller-managerto crash on startup:This made the OLM cluster operator
Degraded/Unavailableand caused cluster installation to fail with exit code 6, as seen in the synchronize-upstream CI run.Changes:
HelmChartSupportfromopenshift/helm/experimental.yamlopenshift/operator-controller/manifests-experimental.yamlviamake -C openshift manifestsSummary by CodeRabbit