Skip to content

NO-ISSUE: Remove stale reviewers/approvers, add trgeiger - #769

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
tmshort:update-stale-owners
Jul 22, 2026
Merged

NO-ISSUE: Remove stale reviewers/approvers, add trgeiger#769
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
tmshort:update-stale-owners

Conversation

@tmshort

@tmshorttmshort commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Remove stale handles from DOWNSTREAM_OWNERS_ALIASES.

Removed from operator-framework-approvers:oceanc80, jianzhangbjz
Removed from operator-framework-reviewers:anik120, bentito, camilamacedo86, oceanc80, rashmigottipati, thetechnick
(trgeiger was already present)

Summary by CodeRabbit

  • Chores
    • Updated contributor alias lists for approvers and reviewers.
    • Removed outdated entries and adjusted membership for the approvers and reviewers aliases.

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cef863db-6d7d-409b-8603-f06678a0a03a

📥 Commits

Reviewing files that changed from the base of the PR and between 67298be and bbe4abc.

📒 Files selected for processing (1)
  • DOWNSTREAM_OWNERS_ALIASES
💤 Files with no reviewable changes (1)
  • DOWNSTREAM_OWNERS_ALIASES

Walkthrough

Updated the approver and reviewer membership lists in DOWNSTREAM_OWNERS_ALIASES.

Changes

Downstream owner aliases

Layer / File(s)Summary
Update alias membership
DOWNSTREAM_OWNERS_ALIASES
Revised the operator-framework-approvers and operator-framework-reviewers contributor lists by removing specified entries and retaining the updated memberships.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers:joelanford, oceanc80

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title matches the reviewer/approver cleanup, but 'add trgeiger' is misleading because trgeiger was already present.Rename the PR to describe only the actual alias cleanup, e.g. 'Remove stale reviewers/approvers from DOWNSTREAM_OWNERS_ALIASES'.
✅ Passed checks (14 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names✅ PassedOnly DOWNSTREAM_OWNERS_ALIASES changed; no Ginkgo tests or test titles were modified, so there are no dynamic test names to flag.
Test Structure And Quality✅ PassedOnly DOWNSTREAM_OWNERS_ALIASES changed; no Ginkgo test code or test behavior was modified, so the test-quality check is not applicable.
Microshift Test Compatibility✅ PassedOnly DOWNSTREAM_OWNERS_ALIASES changed; no Ginkgo e2e tests or MicroShift-relevant APIs were added or modified.
Single Node Openshift (Sno) Test Compatibility✅ PassedPR only updates DOWNSTREAM_OWNERS_ALIASES; no Ginkgo e2e tests were added or changed.
Topology-Aware Scheduling Compatibility✅ PassedOnly DOWNSTREAM_OWNERS_ALIASES changed; no deployment manifests, operator code, or controllers were modified, so topology scheduling checks are not applicable.
Ote Binary Stdout Contract✅ PassedOnly DOWNSTREAM_OWNERS_ALIASES changed; no process-level code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility✅ PassedOnly alias entries changed in DOWNSTREAM_OWNERS_ALIASES; no Ginkgo e2e tests or network assumptions were added.
No-Weak-Crypto✅ PassedThe PR only removes owner aliases in DOWNSTREAM_OWNERS_ALIASES; no weak-crypto, custom crypto, or secret-comparison code is present.
Container-Privileges✅ PassedOnly DOWNSTREAM_OWNERS_ALIASES changed; no container/K8s manifests or security-context settings were modified.
No-Sensitive-Data-In-Logs✅ PassedPR only removes alias entries from DOWNSTREAM_OWNERS_ALIASES; no logging or sensitive-data exposure was added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2026
@tmshort
tmshortforce-pushed the update-stale-owners branch from e1475cd to 67298beCompareJuly 21, 2026 19:44
@tmshorttmshort changed the title Remove stale reviewers/approvers, add trgeigerNO-ISSUE: Remove stale reviewers/approvers, add trgeigerJul 21, 2026
@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@tmshort: This pull request explicitly references no jira issue.

Details

In response to this:

Remove stale handles from DOWNSTREAM_OWNERS_ALIASES.

Removed from operator-framework-approvers:oceanc80, jianzhangbjz
Removed from operator-framework-reviewers:anik120, bentito, camilamacedo86, oceanc80, rashmigottipati, thetechnick
(trgeiger was already present)

Summary by CodeRabbit

  • Chores
  • Updated contributor approval and review assignments.
  • Added greeting text for Evan, Alice, Bob, Carol, and Dave.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2026
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshortforce-pushed the update-stale-owners branch from 67298be to bbe4abcCompareJuly 21, 2026 20:12
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2026
@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2026
@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort

Copy link
Copy Markdown
ContributorAuthor

/override ci/prow/e2e-aws-upgrade-ovn-single-node

Updating owners should not impact these tests; which have been flakey and are not required

@openshift-ci

Copy link
Copy Markdown
Contributor

@tmshort: Overrode contexts on behalf of tmshort: ci/prow/e2e-aws-upgrade-ovn-single-node

Details

In response to this:

/override ci/prow/e2e-aws-upgrade-ovn-single-node

Updating owners should not impact these tests; which have been flakey and are not required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort

Copy link
Copy Markdown
ContributorAuthor

/verified by CI

Other than the flakey, non-required test, everything passes. This is only a change to the owners

@openshift-ci-robotopenshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@tmshort: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Other than the flakey, non-required test, everything passes. This is only a change to the owners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rashmigottipati

Copy link
Copy Markdown
Member

/test openshift-e2e-aws-techpreview is failing on other PRs too ...

@tmshort

Copy link
Copy Markdown
ContributorAuthor

/override ci/prow/openshift-e2e-aws-techpreview

This is just a change to the owner's files, which shouldn't impact tests. And since this CI is failing more often than passing, I think we can override it.

@openshift-ci

Copy link
Copy Markdown
Contributor

@tmshort: Overrode contexts on behalf of tmshort: ci/prow/openshift-e2e-aws-techpreview

Details

In response to this:

/override ci/prow/openshift-e2e-aws-techpreview

This is just a change to the owner's files, which shouldn't impact tests. And since this CI is failing more often than passing, I think we can override it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-botBot merged commit 186c9e6 into openshift:mainJul 22, 2026
14 checks passed
@tmshort
tmshort deleted the update-stale-owners branch July 27, 2026 12:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.lgtmIndicates that a PR is ready to be merged.verifiedSignifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort@openshift-ci-robot@rashmigottipati@grokspawn