Uh oh!
There was an error while loading. Please reload this page.
NO-ISSUE: Remove openshift/ e2e related to deprecated Servic… - #770
Closed
tmshort wants to merge 1 commit into
Closed
NO-ISSUE: Remove openshift/ e2e related to deprecated Servic…#770tmshort wants to merge 1 commit into
tmshort wants to merge 1 commit into
Conversation
…eAccount usage in ClusterExtension API, Synthetic Permissions, and PreFlight Admissions Signed-off-by: Daniel Franz <dfranz@redhat.com>
openshift-ci-robot
commented
Jul 23, 2026
@tmshort: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tmshort
commented
Jul 23, 2026
ContributorAuthor
Alternative to the sync+removal PR #767 |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (48)
💤 Files with no reviewable changes (37)
WalkthroughChangesThe operator-controller experimental feature gates now enable own-namespace and OpenShift Service CA support while disabling CertManager and Boxcutter runtime features. OLMv1 helpers, templates, manifests, and tests remove explicit ServiceAccount/RBAC setup, and payload coverage shifts from preflight permission checks to installation, downgrade, upgrade, and watch-mode scenarios. OLMv1 feature configuration
Estimated code review effort: 4 (Complex) | ~60 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning, 1 inconclusive)
✅ Passed checks (12 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tmshort
commented
Jul 23, 2026
ContributorAuthor
/test unit |
tmshort
commented
Jul 23, 2026
ContributorAuthor
/retest |
Contributor
@tmshort: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eAccount usage in ClusterExtension API, Synthetic Permissions, and PreFlight Admissions
Summary by CodeRabbit
New Features
Bug Fixes
Tests