Uh oh!
There was an error while loading. Please reload this page.
Update bumper for golang 1.23/OCP 4.19 - #63
Conversation
Do you also want to bump go.mod to 1.23? |
tmshort
commented
Jan 15, 2025
Those changes are a result of me using golang 1.23.0, so it updated it to 1.22.1, not sure why it picked that version? |
tmshort
commented
Jan 15, 2025
Lint is passing now, but it might be better to have everything be 1.23? |
tmshort
commented
Jan 15, 2025
openshift/release has been updated. |
Update golangci-lint for 1.23 support Signed-off-by: Todd Short <todd.short@me.com>
tmshort
commented
Jan 15, 2025
The last changed updated |
Yeah & expected. Since you standardized all components on a greatest common version, no I was expecting the same thing to happen here though. Did you re-gen the bingo config after bumping to go1.23 in go.mod? |
tmshort
commented
Jan 15, 2025
I tried various things, and it doesn't seem to want to update that to 1.23 |
tmshort
commented
Jan 15, 2025
It matches the version on OLMv0: |
@tmshort: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
grokspawn
commented
Jan 15, 2025
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.