Uh oh!
There was an error while loading. Please reload this page.
Serve web console from same port as API by default and allow configuring console's context root - #1458
Conversation
jwforres
commented
Mar 25, 2015
There was a problem hiding this comment.
Is there a better place to put this?
jwforres
commented
Mar 25, 2015
implemented all review feedback except for the ongoing discussion about CORS [test] |
openshift-bot
commented
Mar 25, 2015
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1472/) |
There was a problem hiding this comment.
Add a TODO to build these paths in a non-hardcoded way
There was a problem hiding this comment.
Integration test for root redirect with "accept: text/html" and json otherwise?
https://gist.github.com/liggitt/602ad5b5cfab6d156c90
There was a problem hiding this comment.
Also, add a TODO in the integration test file to add a test when the asset config is nil, once David's changes to let you manipulate the config are available
… or as its own server on a separate port
… to asset server or dump of api paths when / is requested.
jwforres
commented
Mar 26, 2015
@liggitt squashed down to two commits, your initial changes and then all my follow-up changes, ready for a final glance-over before merge |
jwforres
commented
Mar 26, 2015
[merge] |
openshift-bot
commented
Mar 26, 2015
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1310/) (Image: devenv-fedora_1142) |
openshift-bot
commented
Mar 26, 2015
Evaluated for origin up to 22045ca |
bparees
commented
Mar 26, 2015
impacts the sample app readme, right? |
jwforres
commented
Mar 26, 2015
@bparees you are correct, I was about to add info about the console to the main readme, will fix that at the same time |
No description provided.