Uh oh!
There was an error while loading. Please reload this page.
Cleanup sysconfig values as everything is now in a config file - #1935
Conversation
sdodson
commented
Apr 27, 2015
8553a6b to
410cd43Compare* Cleanup several unused items now that everything is stored in config
files, now the only things in our sysconfig files are the paths to
the openshift config files and OPTIONS
* Create /etc/openshift/{master,node} in their respective packages410cd43 to
b5ffc45CompareThere was a problem hiding this comment.
I'm not certain what to do about this, if they have a config file as the services expect them to then passing this as a commandline argument is ignored, but then we have no way other than generating a config file to set the default registry.
If we care, perhaps this could be adjusted to patch pkg/cmd/util/variable/imagetemplate.go or override it at build time with an ldflag somehow?
There was a problem hiding this comment.
With the other changes, the services will choke without a config file anyway. I guess I don't really see a problem with that, although maybe we should supply config files with some workable defaults so that the services will start out of the box? Given we expect to be using the ansible installer, and the rate of change of config, not sure we want that yet though.
I guess LGTM as-is.
sdodson
commented
Apr 29, 2015
@sosiouxme Mind taking a look at this? It's re-incarnation of #1616 which we tried to merge but kept hitting flakiness and it then ran into merge conflicts and was ultimately closed. |
sosiouxme
commented
Apr 29, 2015
How about we [merge] then while we can... |
openshift-bot
commented
Apr 29, 2015
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1729/) (Image: devenv-fedora_1397) |
openshift-bot
commented
Apr 29, 2015
Evaluated for origin up to b5ffc45 |
files, now the only things in our sysconfig files are the paths to
the openshift config files and items that should be specified as OPTIONS and cannot be defined in
the config file.