Skip to content

OCPCRT-598: Adding the missing populatePayloadPhases(release) to the audit process - #811

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bradmwilliams:ocpcrt-598
Aug 7, 2026
Merged

OCPCRT-598: Adding the missing populatePayloadPhases(release) to the audit process#811
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bradmwilliams:ocpcrt-598

Conversation

@bradmwilliams

@bradmwilliamsbradmwilliams commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

When me, and claude, migrated processing to the ReleasePayload as the source of truth it appears as though the (most) important piece, populating the release phases, was missed. This PR adds the call to the missing function.

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED

Summary by CodeRabbit

  • Bug Fixes
    • Release audit records now include phase information when releases are logged and synchronized.

…audit process
rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@openshift-ci-robot

openshift-ci-robot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@bradmwilliams: This pull request references OCPCRT-598 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

When me, and claude, migrated processing to the ReleasePayload as the source of truth it appears as though the (most) important piece, populating the release phases, was missed. This PR adds the call to the missing function.

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2026
@coderabbitai

coderabbitaiBot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 10d1ae15-134e-4f7f-b4e2-929be5223d9b

📥 Commits

Reviewing files that changed from the base of the PR and between 65da42a and 5d46257.

📒 Files selected for processing (1)
  • cmd/release-controller/audit.go

📝 Walkthrough

Walkthrough

syncAudit now populates release payload phases after loading the release and before logging and synchronizing it with the audit tracker.

Changes

Audit synchronization

Layer / File(s)Summary
Populate phases before audit tracking
cmd/release-controller/audit.go
syncAudit invokes populatePayloadPhases(release) before audit tracking.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers:alexnpavel

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the missing populatePayloadPhases(release) call and matches the main change in the pull request.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2026
@openshift-ci

Copy link
Copy Markdown
Contributor

@bradmwilliams: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2026
@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, hoxhaeris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bradmwilliams,hoxhaeris]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-botBot merged commit 5735800 into openshift:mainAug 7, 2026
10 checks passed
@bradmwilliams
bradmwilliams deleted the ocpcrt-598 branch August 7, 2026 16:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bradmwilliams@openshift-ci-robot@hoxhaeris