Sync Serverless CI - #44332

Merged
openshift-ci[bot] merged 6 commits into
openshift:masterfrom
serverless-qe:sync-serverless-ci
Oct 13, 2023
Merged

Sync Serverless CI#44332
openshift-ci[bot] merged 6 commits into
openshift:masterfrom
serverless-qe:sync-serverless-ci

Conversation

@serverless-qe

@serverless-qeserverless-qe commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

Sync Serverless CI using openshift-knative/hack.

@openshift-ciopenshift-ciBot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2023
@openshift-ci

openshift-ciBot commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

Hi @serverless-qe. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
openshift-ciBot requested review from alanfx and aliokOctober 13, 2023 06:12
@openshift-ci-robot

openshift-ci-robot commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test nameRepoTypeReason
pull-ci-openshift-knative-serving-release-v1.10-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.10-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.11-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.10-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.11-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-imagesopenshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411openshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-imagesopenshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-imagesopenshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

For reference this comes from: openshift-knative/hack#78.

@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ciopenshift-ciBot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2023
@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

/pj-rehearse max

@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

/hold for tests

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

cc @pierDipi for the approval.

@ReToCodeReToCode mentioned this pull request Oct 13, 2023
Merged
@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

or @matzew could you approve?

@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

Serving job failed with:

{ failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

/pj-rehearse pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411

@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

/pj-rehearse periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous

@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

/pj-rehearse pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411

@pierDipi

pierDipi commented Oct 13, 2023

Copy link
Copy Markdown
Member

/lgtm
/approve

pierDipi
pierDipi approved these changes Oct 13, 2023
View reviewed changes

@pierDipipierDipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ciBot commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, serverless-qe, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@pierDipi

pierDipi commented Oct 13, 2023

Copy link
Copy Markdown
Member

/unhold

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@skonto

skonto commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

/unhold

@pierDipi

pierDipi commented Oct 13, 2023

Copy link
Copy Markdown
Member

/pj-rehearse ack

@openshift-ci-robotopenshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 13, 2023
@openshift-ci
openshift-ciBot merged commit 064bff3 into openshift:masterOct 13, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanfxalanfxAwaiting requested review from alanfx
@aliokaliokAwaiting requested review from aliok
1 more reviewer
@pierDipipierDipipierDipi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skontoskonto

@pierDipipierDipi

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.rehearsals-ackSignifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serverless-qe@openshift-ci-robot@skonto@pierDipi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Sync Serverless CI - #44332
Merged
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Oct 13, 2023
Merged
Sync Serverless CI#44332
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Conversation
@serverless-qe
@serverless-qeserverless-qe
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Sync Serverless CI using openshift-knative/hack.
@openshift-ciopenshift-ciBot
added
the 
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Hi @serverless-qe. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-ci
openshift-ciBot
requested review from
alanfx and aliokOctober 13, 2023 06:12
@openshift-ci-robot
openshift-ci-robot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:
Test nameRepoTypeReason
pull-ci-openshift-knative-serving-release-v1.10-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.10-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.11-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.10-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.11-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-imagesopenshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411openshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-imagesopenshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-imagesopenshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.
Interacting with pj-rehearse
Comment: /pj-rehearse to run up to 10 rehearsals

Comment: /pj-rehearse skip to opt-out of rehearsals

Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals

Comment: /pj-rehearse more to run up to 20 rehearsals

Comment: /pj-rehearse max to run up to 35 rehearsals

Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success

Comment: /pj-rehearse abort to abort all active rehearsals
Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.

If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
For reference this comes from: openshift-knative/hack#78.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/ok-to-test
@openshift-ciopenshift-ciBot
added

ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
and removed

needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
labels
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse max
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/hold for tests
@openshift-ciopenshift-ciBot
added
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/lgtm

/approve
@openshift-ciopenshift-ciBot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
cc @pierDipi for the approval.
@ReToCodeReToCode
mentioned this pull request
Oct 13, 2023
 Merged

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
or @matzew could you approve?
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Serving job failed with:
{ failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/lgtm

/approve
pierDipi
pierDipi
approved these changes
Oct 13, 2023
View reviewed changes
@pierDipipierDipi
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pierDipi, serverless-qe, skonto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@openshift-ciopenshift-ciBot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 13, 2023
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/unhold
@openshift-ciopenshift-ciBot
removed
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/unhold
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/pj-rehearse ack
@openshift-ci-robotopenshift-ci-robot
added
the 
rehearsals-ack
Signifies that rehearsal jobs have been acknowledged
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
merged commit 064bff3
into
openshift:masterOct 13, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alanfxalanfxAwaiting requested review from alanfx
@aliokaliokAwaiting requested review from aliok

1 more reviewer

@pierDipipierDipipierDipi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skontoskonto
@pierDipipierDipi

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.rehearsals-ackSignifies that rehearsal jobs have been acknowledged

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@serverless-qe@openshift-ci-robot@skonto@pierDipi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Sync Serverless CI - #44332
Merged
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Oct 13, 2023
Merged
Sync Serverless CI#44332
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Conversation
@serverless-qe
@serverless-qeserverless-qe
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Sync Serverless CI using openshift-knative/hack.
@openshift-ciopenshift-ciBot
added
the 
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Hi @serverless-qe. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-ci
openshift-ciBot
requested review from
alanfx and aliokOctober 13, 2023 06:12
@openshift-ci-robot
openshift-ci-robot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:
Test nameRepoTypeReason
pull-ci-openshift-knative-serving-release-v1.10-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.10-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.11-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.10-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.11-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-imagesopenshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411openshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-imagesopenshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-imagesopenshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.
Interacting with pj-rehearse
Comment: /pj-rehearse to run up to 10 rehearsals

Comment: /pj-rehearse skip to opt-out of rehearsals

Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals

Comment: /pj-rehearse more to run up to 20 rehearsals

Comment: /pj-rehearse max to run up to 35 rehearsals

Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success

Comment: /pj-rehearse abort to abort all active rehearsals
Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.

If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
For reference this comes from: openshift-knative/hack#78.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/ok-to-test
@openshift-ciopenshift-ciBot
added

ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
and removed

needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
labels
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse max
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/hold for tests
@openshift-ciopenshift-ciBot
added
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/lgtm

/approve
@openshift-ciopenshift-ciBot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
cc @pierDipi for the approval.
@ReToCodeReToCode
mentioned this pull request
Oct 13, 2023
 Merged

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
or @matzew could you approve?
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Serving job failed with:
{ failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/lgtm

/approve
pierDipi
pierDipi
approved these changes
Oct 13, 2023
View reviewed changes
@pierDipipierDipi
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pierDipi, serverless-qe, skonto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@openshift-ciopenshift-ciBot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 13, 2023
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/unhold
@openshift-ciopenshift-ciBot
removed
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/unhold
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/pj-rehearse ack
@openshift-ci-robotopenshift-ci-robot
added
the 
rehearsals-ack
Signifies that rehearsal jobs have been acknowledged
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
merged commit 064bff3
into
openshift:masterOct 13, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alanfxalanfxAwaiting requested review from alanfx
@aliokaliokAwaiting requested review from aliok

1 more reviewer

@pierDipipierDipipierDipi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skontoskonto
@pierDipipierDipi

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.rehearsals-ackSignifies that rehearsal jobs have been acknowledged

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@serverless-qe@openshift-ci-robot@skonto@pierDipi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Sync Serverless CI - #44332
Merged
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Oct 13, 2023
Merged
Sync Serverless CI#44332
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Conversation
@serverless-qe
@serverless-qeserverless-qe
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Sync Serverless CI using openshift-knative/hack.
@openshift-ciopenshift-ciBot
added
the 
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Hi @serverless-qe. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-ci
openshift-ciBot
requested review from
alanfx and aliokOctober 13, 2023 06:12
@openshift-ci-robot
openshift-ci-robot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:
Test nameRepoTypeReason
pull-ci-openshift-knative-serving-release-v1.10-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.10-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.11-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.10-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.11-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-imagesopenshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411openshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-imagesopenshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-imagesopenshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.
Interacting with pj-rehearse
Comment: /pj-rehearse to run up to 10 rehearsals

Comment: /pj-rehearse skip to opt-out of rehearsals

Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals

Comment: /pj-rehearse more to run up to 20 rehearsals

Comment: /pj-rehearse max to run up to 35 rehearsals

Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success

Comment: /pj-rehearse abort to abort all active rehearsals
Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.

If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
For reference this comes from: openshift-knative/hack#78.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/ok-to-test
@openshift-ciopenshift-ciBot
added

ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
and removed

needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
labels
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse max
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/hold for tests
@openshift-ciopenshift-ciBot
added
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/lgtm

/approve
@openshift-ciopenshift-ciBot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
cc @pierDipi for the approval.
@ReToCodeReToCode
mentioned this pull request
Oct 13, 2023
 Merged

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
or @matzew could you approve?
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Serving job failed with:
{ failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/lgtm

/approve
pierDipi
pierDipi
approved these changes
Oct 13, 2023
View reviewed changes
@pierDipipierDipi
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pierDipi, serverless-qe, skonto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@openshift-ciopenshift-ciBot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 13, 2023
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/unhold
@openshift-ciopenshift-ciBot
removed
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/unhold
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/pj-rehearse ack
@openshift-ci-robotopenshift-ci-robot
added
the 
rehearsals-ack
Signifies that rehearsal jobs have been acknowledged
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
merged commit 064bff3
into
openshift:masterOct 13, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alanfxalanfxAwaiting requested review from alanfx
@aliokaliokAwaiting requested review from aliok

1 more reviewer

@pierDipipierDipipierDipi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skontoskonto
@pierDipipierDipi

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.rehearsals-ackSignifies that rehearsal jobs have been acknowledged

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@serverless-qe@openshift-ci-robot@skonto@pierDipi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Sync Serverless CI - #44332
Merged
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Oct 13, 2023
Merged
Sync Serverless CI#44332
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Conversation
@serverless-qe
@serverless-qeserverless-qe
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Sync Serverless CI using openshift-knative/hack.
@openshift-ciopenshift-ciBot
added
the 
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Hi @serverless-qe. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-ci
openshift-ciBot
requested review from
alanfx and aliokOctober 13, 2023 06:12
@openshift-ci-robot
openshift-ci-robot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:
Test nameRepoTypeReason
pull-ci-openshift-knative-serving-release-v1.10-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.10-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.11-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.10-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.11-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-imagesopenshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411openshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-imagesopenshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-imagesopenshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.
Interacting with pj-rehearse
Comment: /pj-rehearse to run up to 10 rehearsals

Comment: /pj-rehearse skip to opt-out of rehearsals

Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals

Comment: /pj-rehearse more to run up to 20 rehearsals

Comment: /pj-rehearse max to run up to 35 rehearsals

Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success

Comment: /pj-rehearse abort to abort all active rehearsals
Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.

If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
For reference this comes from: openshift-knative/hack#78.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/ok-to-test
@openshift-ciopenshift-ciBot
added

ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
and removed

needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
labels
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse max
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/hold for tests
@openshift-ciopenshift-ciBot
added
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/lgtm

/approve
@openshift-ciopenshift-ciBot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
cc @pierDipi for the approval.
@ReToCodeReToCode
mentioned this pull request
Oct 13, 2023
 Merged

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
or @matzew could you approve?
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Serving job failed with:
{ failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/lgtm

/approve
pierDipi
pierDipi
approved these changes
Oct 13, 2023
View reviewed changes
@pierDipipierDipi
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pierDipi, serverless-qe, skonto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@openshift-ciopenshift-ciBot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 13, 2023
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/unhold
@openshift-ciopenshift-ciBot
removed
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/unhold
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/pj-rehearse ack
@openshift-ci-robotopenshift-ci-robot
added
the 
rehearsals-ack
Signifies that rehearsal jobs have been acknowledged
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
merged commit 064bff3
into
openshift:masterOct 13, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alanfxalanfxAwaiting requested review from alanfx
@aliokaliokAwaiting requested review from aliok

1 more reviewer

@pierDipipierDipipierDipi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skontoskonto
@pierDipipierDipi

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.rehearsals-ackSignifies that rehearsal jobs have been acknowledged

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@serverless-qe@openshift-ci-robot@skonto@pierDipi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Sync Serverless CI - #44332
Merged
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Oct 13, 2023
Merged
Sync Serverless CI#44332
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Conversation
@serverless-qe
@serverless-qeserverless-qe
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Sync Serverless CI using openshift-knative/hack.
@openshift-ciopenshift-ciBot
added
the 
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Hi @serverless-qe. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-ci
openshift-ciBot
requested review from
alanfx and aliokOctober 13, 2023 06:12
@openshift-ci-robot
openshift-ci-robot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:
Test nameRepoTypeReason
pull-ci-openshift-knative-serving-release-v1.10-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.10-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.11-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.10-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.11-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-imagesopenshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411openshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-imagesopenshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-imagesopenshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.
Interacting with pj-rehearse
Comment: /pj-rehearse to run up to 10 rehearsals

Comment: /pj-rehearse skip to opt-out of rehearsals

Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals

Comment: /pj-rehearse more to run up to 20 rehearsals

Comment: /pj-rehearse max to run up to 35 rehearsals

Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success

Comment: /pj-rehearse abort to abort all active rehearsals
Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.

If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
For reference this comes from: openshift-knative/hack#78.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/ok-to-test
@openshift-ciopenshift-ciBot
added

ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
and removed

needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
labels
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse max
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/hold for tests
@openshift-ciopenshift-ciBot
added
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/lgtm

/approve
@openshift-ciopenshift-ciBot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
cc @pierDipi for the approval.
@ReToCodeReToCode
mentioned this pull request
Oct 13, 2023
 Merged

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
or @matzew could you approve?
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Serving job failed with:
{ failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/lgtm

/approve
pierDipi
pierDipi
approved these changes
Oct 13, 2023
View reviewed changes
@pierDipipierDipi
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pierDipi, serverless-qe, skonto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@openshift-ciopenshift-ciBot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 13, 2023
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/unhold
@openshift-ciopenshift-ciBot
removed
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/unhold
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/pj-rehearse ack
@openshift-ci-robotopenshift-ci-robot
added
the 
rehearsals-ack
Signifies that rehearsal jobs have been acknowledged
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
merged commit 064bff3
into
openshift:masterOct 13, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alanfxalanfxAwaiting requested review from alanfx
@aliokaliokAwaiting requested review from aliok

1 more reviewer

@pierDipipierDipipierDipi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skontoskonto
@pierDipipierDipi

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.rehearsals-ackSignifies that rehearsal jobs have been acknowledged

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@serverless-qe@openshift-ci-robot@skonto@pierDipi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Sync Serverless CI - #44332
Merged
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Oct 13, 2023
Merged
Sync Serverless CI#44332
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Conversation
@serverless-qe
@serverless-qeserverless-qe
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Sync Serverless CI using openshift-knative/hack.
@openshift-ciopenshift-ciBot
added
the 
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Hi @serverless-qe. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-ci
openshift-ciBot
requested review from
alanfx and aliokOctober 13, 2023 06:12
@openshift-ci-robot
openshift-ci-robot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:
Test nameRepoTypeReason
pull-ci-openshift-knative-serving-release-v1.10-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.10-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.11-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.10-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.11-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-imagesopenshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411openshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-imagesopenshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-imagesopenshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.
Interacting with pj-rehearse
Comment: /pj-rehearse to run up to 10 rehearsals

Comment: /pj-rehearse skip to opt-out of rehearsals

Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals

Comment: /pj-rehearse more to run up to 20 rehearsals

Comment: /pj-rehearse max to run up to 35 rehearsals

Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success

Comment: /pj-rehearse abort to abort all active rehearsals
Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.

If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
For reference this comes from: openshift-knative/hack#78.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/ok-to-test
@openshift-ciopenshift-ciBot
added

ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
and removed

needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
labels
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse max
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/hold for tests
@openshift-ciopenshift-ciBot
added
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/lgtm

/approve
@openshift-ciopenshift-ciBot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
cc @pierDipi for the approval.
@ReToCodeReToCode
mentioned this pull request
Oct 13, 2023
 Merged

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
or @matzew could you approve?
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Serving job failed with:
{ failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/lgtm

/approve
pierDipi
pierDipi
approved these changes
Oct 13, 2023
View reviewed changes
@pierDipipierDipi
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pierDipi, serverless-qe, skonto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@openshift-ciopenshift-ciBot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 13, 2023
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/unhold
@openshift-ciopenshift-ciBot
removed
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/unhold
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/pj-rehearse ack
@openshift-ci-robotopenshift-ci-robot
added
the 
rehearsals-ack
Signifies that rehearsal jobs have been acknowledged
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
merged commit 064bff3
into
openshift:masterOct 13, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alanfxalanfxAwaiting requested review from alanfx
@aliokaliokAwaiting requested review from aliok

1 more reviewer

@pierDipipierDipipierDipi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skontoskonto
@pierDipipierDipi

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.rehearsals-ackSignifies that rehearsal jobs have been acknowledged

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@serverless-qe@openshift-ci-robot@skonto@pierDipi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Sync Serverless CI - #44332
Merged
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Oct 13, 2023
Merged
Sync Serverless CI#44332
openshift-ci[bot] merged 6 commits into
openshift:masterfrom 
serverless-qe:sync-serverless-ci
Conversation
@serverless-qe
@serverless-qeserverless-qe
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Sync Serverless CI using openshift-knative/hack.
@openshift-ciopenshift-ciBot
added
the 
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Hi @serverless-qe. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-ci
openshift-ciBot
requested review from
alanfx and aliokOctober 13, 2023 06:12
@openshift-ci-robot
openshift-ci-robot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:
Test nameRepoTypeReason
pull-ci-openshift-knative-serving-release-v1.10-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-imagesopenshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411openshift-knative/servingpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.10-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.11-411-imagesopenshift-knative/net-kourierpresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.10-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-net-istio-release-v1.11-411-imagesopenshift-knative/net-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-imagesopenshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventing-kafka-brokerpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411openshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-imagesopenshift-knative/eventing-istiopresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-imagesopenshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411openshift-knative/eventingpresubmitPresubmit changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411-continuousN/AperiodicPeriodic changed
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.
Interacting with pj-rehearse
Comment: /pj-rehearse to run up to 10 rehearsals

Comment: /pj-rehearse skip to opt-out of rehearsals

Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals

Comment: /pj-rehearse more to run up to 20 rehearsals

Comment: /pj-rehearse max to run up to 35 rehearsals

Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success

Comment: /pj-rehearse abort to abort all active rehearsals
Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.

If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
For reference this comes from: openshift-knative/hack#78.
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/ok-to-test
@openshift-ciopenshift-ciBot
added

ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
and removed

needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
labels
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse max
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/hold for tests
@openshift-ciopenshift-ciBot
added
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/lgtm

/approve
@openshift-ciopenshift-ciBot
added
the 
lgtm
Indicates that a PR is ready to be merged.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
cc @pierDipi for the approval.
@ReToCodeReToCode
mentioned this pull request
Oct 13, 2023
 Merged

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
or @matzew could you approve?
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
Serving job failed with:
{ failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/pj-rehearse pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/lgtm

/approve
pierDipi
pierDipi
approved these changes
Oct 13, 2023
View reviewed changes
@pierDipipierDipi
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve
@openshift-ci
openshift-ciBot
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pierDipi, serverless-qe, skonto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment

Approvers can cancel approval by writing /approve cancel in a comment
@openshift-ciopenshift-ciBot
added
the 
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 13, 2023
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/unhold
@openshift-ciopenshift-ciBot
removed
the 
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 13, 2023
@skonto
skonto
commented
Oct 13, 2023

Copy link


Copy Markdown

Contributor
/unhold
@pierDipi
pierDipi
commented
Oct 13, 2023

Copy link


Copy Markdown

Member
/pj-rehearse ack
@openshift-ci-robotopenshift-ci-robot
added
the 
rehearsals-ack
Signifies that rehearsal jobs have been acknowledged
label
Oct 13, 2023
@openshift-ci
openshift-ciBot
merged commit 064bff3
into
openshift:masterOct 13, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alanfxalanfxAwaiting requested review from alanfx
@aliokaliokAwaiting requested review from aliok

1 more reviewer

@pierDipipierDipipierDipi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skontoskonto
@pierDipipierDipi

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.rehearsals-ackSignifies that rehearsal jobs have been acknowledged

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@serverless-qe@openshift-ci-robot@skonto@pierDipi