Skip to content

Replace missing reason code with another one - #31474

Closed
t8m wants to merge 1 commit into
openssl:openssl-3.6from
t8m:error-reason-fixup-3.6
Closed

Replace missing reason code with another one#31474
t8m wants to merge 1 commit into
openssl:openssl-3.6from
t8m:error-reason-fixup-3.6

Conversation

@t8m

@t8mt8m commented Jun 12, 2026

Copy link
Copy Markdown
Member

There is no PROV_R_INVALID_CIPHER on 3.6 use PROV_R_NOT_SUPPORTED instead.

Fixes 73807b3

@t8m
Replace missing reason code with another one
d3ecf5a
There is no PROV_R_INVALID_CIPHER on 3.6 use PROV_R_NOT_SUPPORTED
instead.
Fixes 73807b3
@t8mt8m added triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing branch: 3.6 Applies to openssl-3.6 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 labels Jun 12, 2026
@t8m

t8m commented Jun 12, 2026

Copy link
Copy Markdown
MemberAuthor

FIPS Check is broken due to broken build on the base branches.

@t8m

t8m commented Jun 12, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

This needs to be applied to 3.6, 3.5 and 3.4 branches and it is urgent to fix CI.

@t8mt8m added the approval: review pending This pull request needs review by a committer label Jun 12, 2026
This was referenced Jun 12, 2026
Closed
Closed
Closed
Closed
levitte
levitte approved these changes Jun 12, 2026
View reviewed changes

@levittelevitte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 re urgent

mbroz
mbroz approved these changes Jun 12, 2026
View reviewed changes

@mbrozmbroz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with urgent

@openssl-machineopenssl-machine added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 12, 2026
@levitte

levitte commented Jun 12, 2026

Copy link
Copy Markdown
Member

The compute-* failures aren't relevant here

openssl-machine pushed a commit that referenced this pull request Jun 12, 2026
@t8m
Replace missing reason code with another one
0217baf
There is no PROV_R_INVALID_CIPHER on 3.6 use PROV_R_NOT_SUPPORTED
instead.
Fixes 73807b3
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Milan Broz <mbroz@openssl.org>
MergeDate: Fri Jun 12 06:34:15 2026
(Merged from #31474)
openssl-machine pushed a commit that referenced this pull request Jun 12, 2026
@t8m
Replace missing reason code with another one
23b0396
There is no PROV_R_INVALID_CIPHER on 3.6 use PROV_R_NOT_SUPPORTED
instead.
Fixes 73807b3
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Milan Broz <mbroz@openssl.org>
MergeDate: Fri Jun 12 06:34:15 2026
(Merged from #31474)
(cherry picked from commit 0217baf)
openssl-machine pushed a commit that referenced this pull request Jun 12, 2026
@t8m
Replace missing reason code with another one
d06ab25
There is no PROV_R_INVALID_CIPHER on 3.6 use PROV_R_NOT_SUPPORTED
instead.
Fixes 73807b3
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Milan Broz <mbroz@openssl.org>
MergeDate: Fri Jun 12 06:34:15 2026
(Merged from #31474)
(cherry picked from commit 0217baf)
@t8m

t8m commented Jun 12, 2026

Copy link
Copy Markdown
MemberAuthor

Merged to the 3.6, 3.5 and 3.4 branches. Thank you for the reviews.

@t8mt8m closed this Jun 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levittelevittelevitte approved these changes
@mbrozmbrozmbroz approved these changes

Assignees

No one assigned

Labels

approval: doneThis pull request has the required number of approvalsbranch: 3.4Applies to openssl-3.4branch: 3.5Applies to openssl-3.5branch: 3.6Applies to openssl-3.6severity: urgentFixes an urgent issue (exempt from 24h grace period)tests: exemptedThe PR is exempt from requirements for testingtriaged: bugThe issue/pr is/fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@t8m@levitte@mbroz@openssl-machine