Uh oh!
There was an error while loading. Please reload this page.
Fix build failure in -ansi config - #32338
Closed
nhorman wants to merge 2 commits into
Closed
Conversation
The backport of openssl#32052 intorduced a bug that was missed. The added tests from the above PR reference the calling functions with the predefined __func__ macro, which doesn't exist in -ansi builds (which are only done on 3.5 and earlier currently). As such the github ci that runs on push failed. Fix it in the same way as openssl#31988 by replacing __func__ with OPENSSL_FUNC
nhorman
requested review from
Sashan, andrewkdinh, bob-beck, mbroz, npajkovsky and t8mAugust 12, 2026 19:11
Sashan
approved these changes
Aug 12, 2026
Sashan
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, thank you for taking a care of it.
mbroz
approved these changes
Aug 12, 2026
npajkovsky
commented
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backport of #32052 intorduced a bug that was missed. The added tests from the above PR reference the calling functions with the predefined func macro, which doesn't exist in -ansi builds (which are only done on 3.5 and earlier currently). As such the github ci that runs on push failed.
Fix it in the same way as #31988 by replacing func with OPENSSL_FUNC