Skip to content

feat: add obligations - #150

Merged
alkalescent merged 11 commits into
mainfrom
DSPX-1353-obl-docs
Oct 3, 2025
Merged

feat: add obligations#150
alkalescent merged 11 commits into
mainfrom
DSPX-1353-obl-docs

Conversation

@alkalescent

Copy link
Copy Markdown
Contributor

No description provided.

@alkalescent
alkalescent requested a review from a team as a code ownerSeptember 29, 2025 20:33
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @alkalescent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces foundational documentation for 'Obligations,' a new policy construct designed to enable conditional access enforcement at the Policy Enforcement Point (PEP) level. The added content clarifies the purpose, composition, and various types of obligations, providing a clear understanding of how they extend beyond basic attribute-based access control (ABAC) to enforce additional restrictions and requirements.

Highlights

  • Introduction of Obligations Documentation: A new comprehensive Markdown document has been added, detailing the concept of 'Obligations' within the policy framework.
  • Definition and Composition: The documentation clearly defines what obligations are, their role in conditional access enforcement, and their structural components: Namespace, Definition, and Value.
  • Obligation Types Explained: Two distinct types of obligations are described: 'Standard Obligations' for direct enforcement and 'Handling Obligations' for conditional resource manipulation (noting that the latter is currently unimplemented).
  • Practical Examples and Use Cases: The document includes concrete examples for both standard and handling obligations, alongside common use cases such as Multi-Factor Authentication (MFA), geographic restrictions, time-based access, and document watermarking.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for 'Obligations', a key concept in the platform's policy framework. The new document is well-structured and provides a good overview. I've added a couple of suggestions to improve clarity and consistency within the new file. One comment addresses a potentially confusing statement about how obligations are enforced, clarifying the roles of the PDP and PEP. The other comment suggests a formatting change for the use case examples to make them more consistent with the rest of the document. Additionally, you might consider adding 'Obligations' to the list of policy components in docs/components/policy/index.md to make the documentation more discoverable.

Comment threaddocs/components/policy/obligations.md
Comment threaddocs/components/policy/obligations.md Outdated

@jp-ayyappanjp-ayyappan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, let chat if needed

Comment threaddocs/components/policy/obligations.md Outdated
Comment threaddocs/components/policy/obligations.md Outdated
Comment threaddocs/components/policy/obligations.md Outdated
Comment threaddocs/components/policy/obligations.md Outdated
alkalescentand others added 5 commits October 2, 2025 10:28
Co-authored-by: Jp Ayyappan <108297634+jp-ayyappan@users.noreply.github.com>
Co-authored-by: Jp Ayyappan <108297634+jp-ayyappan@users.noreply.github.com>
Co-authored-by: Jp Ayyappan <108297634+jp-ayyappan@users.noreply.github.com>
Co-authored-by: Jp Ayyappan <108297634+jp-ayyappan@users.noreply.github.com>
Comment threaddocs/components/policy/obligations.md
Comment threaddocs/components/policy/obligations.md Outdated
alkalescentand others added 2 commits October 3, 2025 13:05
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>

@jp-ayyappanjp-ayyappan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alkalescent
alkalescent merged commit b39da16 into mainOct 3, 2025
3 checks passed
@alkalescent
alkalescent deleted the DSPX-1353-obl-docs branch October 3, 2025 20:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alkalescent@jakedoublev@jp-ayyappan