Skip to content

chore(docs): add Setup section to Authentication page - #284

Merged
marythought merged 2 commits into
mainfrom
chore/274-f-authentication-setup
Apr 8, 2026
Merged

chore(docs): add Setup section to Authentication page#284
marythought merged 2 commits into
mainfrom
chore/274-f-authentication-setup

Conversation

@marythought

@marythoughtmarythought commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Add a Setup section to the Authentication page showing base imports for Go, Java, and JS so readers know where sdk, SDKBuilder, and authTokenInterceptor come from before hitting the first code example.

Part of #274

Test plan

  • Verify Setup section renders with proper tabs
  • Verify imports match what's used in subsequent examples

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Added a new "Setup" section to authentication docs with base import examples for Go, Java, and JavaScript.
  • New Features

    • Added optional sorting support to the subject mappings API, letting clients request sorted results by a single field and direction (unspecified/ascending/descending).

@marythought
marythought requested review from a team as code ownersApril 7, 2026 16:34
@coderabbitai

This comment was marked as low quality.

@marythought
marythoughtforce-pushed the chore/274-f-authentication-setup branch from 8977b30 to e6ad079CompareApril 7, 2026 16:34

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the authentication documentation by adjusting the sidebar position and adding a new 'Setup' section with import examples for Go, Java, and JavaScript. A review comment suggests expanding the JavaScript import list to include common token providers required by subsequent examples on the page to ensure the setup section is a complete reference.

Comment threaddocs/sdks/authentication.mdx
jp-ayyappan
jp-ayyappan previously approved these changes Apr 8, 2026

@jp-ayyappanjp-ayyappan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marythought
marythoughtforce-pushed the chore/274-f-authentication-setup branch from b5359dc to c9b921dCompareApril 8, 2026 17:07

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/sdks/authentication.mdx`:
- Around line 41-47: The imports shown for the JavaScript TabItem are missing
clientCredentialsTokenProvider; update the import statement that currently lists
authTokenInterceptor and OpenTDF to also include clientCredentialsTokenProvider
so the first example can use clientCredentialsTokenProvider alongside
authTokenInterceptor and OpenTDF.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cc85cdac-4c00-4be9-8faf-8b73a24fc6ad

📥 Commits

Reviewing files that changed from the base of the PR and between bf813a9 and c9b921d.

📒 Files selected for processing (1)
  • docs/sdks/authentication.mdx

Comment threaddocs/sdks/authentication.mdx

@jp-ayyappanjp-ayyappan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on prior approval

marythoughtand others added 2 commits April 8, 2026 14:44
Show base imports for Go, Java, and JS so readers know where sdk,
SDKBuilder, and authTokenInterceptor come from before hitting the
first code example.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@marythought
marythoughtforce-pushed the chore/274-f-authentication-setup branch from cf13705 to 2608c1bCompareApril 8, 2026 21:44
@marythought
marythought merged commit d009386 into mainApr 8, 2026
9 checks passed
@marythought
marythought deleted the chore/274-f-authentication-setup branch April 8, 2026 21:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@marythought@jp-ayyappan