bug: Make batch_list local not global - #837
Merged
Merged
Conversation
Thought. Is batch list added to to the Validator object causing race conditions. Difficult to test, but we can move batch_lisy to local scope anyway.
Collaborator
Author
|
@John-F-Wagstaff. Despite the bad commit message, is this one good to go? |
John-F-Wagstaff
approved these changes
Jun 26, 2026
John-F-Wagstaff
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to go in when you want to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought. Is batch list added to to the Validator object causing race conditions. Difficult to test, but we can move batch_lisy to local scope anyway.