Skip to content

Improve warnings is transcript selection errors - #846

Merged
Peter-J-Freeman merged 1 commit into
developfrom
transcript_select
Jun 25, 2026
Merged

Improve warnings is transcript selection errors#846
Peter-J-Freeman merged 1 commit into
developfrom
transcript_select

Conversation

@Peter-J-Freeman

Copy link
Copy Markdown
Collaborator

This commit adds error codes to existing transcript selection warnings. It also now warns if a transcript variant is submitted with a non-matching transcript selection, rather than the old behavior which resulted in a lost result and could become empty.

This commit adds error codes to existing transcript selection warnings.
It also now warns if a transcript variant is submitted with a
non-matching transcript selection, rather than the old behavior which
resulted in a lost result and could become empty.
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.33%. Comparing base (9c292f6) to head (94f0fd4).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
VariantValidator/modules/mappers.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #846   +/-   ##
========================================
  Coverage    76.32%   76.33%           
========================================
  Files           37       37           
  Lines        13054    13059    +5     
========================================
+ Hits          9964     9968    +4     
- Misses        3090     3091    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@John-F-Wagstaff John-F-Wagstaff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, if Raymond is happy with the output then this is good to go in.

@Peter-J-Freeman

Copy link
Copy Markdown
Collaborator Author

I took Raymond's guidance. So will pull it in

@Peter-J-Freeman
Peter-J-Freeman merged commit c561106 into develop Jun 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants