Improve warnings is transcript selection errors - #846
Merged
Conversation
This commit adds error codes to existing transcript selection warnings. It also now warns if a transcript variant is submitted with a non-matching transcript selection, rather than the old behavior which resulted in a lost result and could become empty.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #846 +/- ##
========================================
Coverage 76.32% 76.33%
========================================
Files 37 37
Lines 13054 13059 +5
========================================
+ Hits 9964 9968 +4
- Misses 3090 3091 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
John-F-Wagstaff
approved these changes
Jun 25, 2026
John-F-Wagstaff
left a comment
Collaborator
There was a problem hiding this comment.
That looks good, if Raymond is happy with the output then this is good to go in.
Collaborator
Author
|
I took Raymond's guidance. So will pull it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds error codes to existing transcript selection warnings. It also now warns if a transcript variant is submitted with a non-matching transcript selection, rather than the old behavior which resulted in a lost result and could become empty.