Uh oh!
There was an error while loading. Please reload this page.
fix: preserve timestep rank in sinusoidal embedding - #316
Merged
yxlllc merged 1 commit intoAug 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SinusoidalPosEmbMotivation
The ONNX exporters trace diffusion backbones with a rank-1 timestep tensor. Forcing that tensor to rank 2 inside
SinusoidalPosEmbmakes the timestep MLP operate on rank-3 inputs, which exports its linear layers asMatMul+Add. ONNX Runtime DirectML graph fusion rejects the resulting diffusion loop graph.Keeping rank-1 timesteps rank 1 lets the linear layers export as 2-D
Gemm, then the backbone restores the existing[B, 1, C]contract. Rank-2 dual timesteps already produce[B, 1, C]and are unchanged.Validation
[B, 1, C]output (max_abs_error = 0)Gemmnodes and noMatMulfor the timestep MLP