Uh oh!
There was an error while loading. Please reload this page.
containers.yml: make Docker Hub and Quay.io registries optional and dynamic - #204
Merged
Merged
Conversation
BKPepeforce-pushed
the
containers-optional-registries
branch
from
June 24, 2026 21:25
1cccf21 to
5eb9e04CompareCurrently, the workflow attempts to log in and push to the official openwrt namespaces on Docker Hub and Quay.io unconditionally on all non-pull-request events. This causes errors on repository forks where these credentials are not set. This change makes the Docker Hub and Quay.io steps conditional on their respective secrets being non-empty. Additionally, the target repository namespace paths are dynamically derived from the secrets (or from the github.repository_owner in case of GHCR), allowing forks to optionally push to their own Docker Hub or Quay.io accounts if they set up the credentials.
BKPepeforce-pushed
the
containers-optional-registries
branch
from
June 24, 2026 21:26
5eb9e04 to
3a05395CompareUh oh!
There was an error while loading. Please reload this page.
aparcar
commented
Aug 17, 2026
Member
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
containers.ymlworkflow attempts to log in and push to the officialopenwrtnamespaces on Docker Hub and Quay.io unconditionally on all non-pull-request events. This causes login failures on repository forks where these credentials are not configured (resulting inUsername and password requirederrors).This pull request makes the Docker Hub and Quay.io login and push steps conditional on their respective secrets (
DOCKER_USER/DOCKER_TOKENandQUAY_USER/QUAY_TOKEN) being non-empty.