Skip to content

move binary dependency management to bingo - #471

Merged
openshift-merge-bot[bot] merged 2 commits into
operator-framework:masterfrom
grokspawn:shift-tools-to-bingo
Jan 29, 2026
Merged

move binary dependency management to bingo#471
openshift-merge-bot[bot] merged 2 commits into
operator-framework:masterfrom
grokspawn:shift-tools-to-bingo

Conversation

@grokspawn

Copy link
Copy Markdown
Contributor

move the retrieval of binaries to bingo, because otherwise there is no version comparison here, and since the acquisition makes no version comparison, it's trivial to see version drift between the upstream and users' local environments, and there's no check to prevent this. Instead, a user would literally have to identify that some of the generated artifacts from make manifests shouldn't have been generated.

This new approach will make the version checks explicit, tied to go version dependency management, and independent of user environments.

@codecov

codecovBot commented Jan 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.86%. Comparing base (2dc4fea) to head (5459fac).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #471 +/- ##
==========================================
+ Coverage 37.78% 37.86% +0.08% 
==========================================
Files 57 57 Lines 4557 4563 +6 ==========================================
+ Hits 1722 1728 +6 
Misses 2678 2678 Partials 157 157 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: grokspawn <jordan@nimblewidget.com>
Comment threadMakefile Outdated
Signed-off-by: grokspawn <jordan@nimblewidget.com>

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2026
@grokspawn

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2026
@openshift-merge-bot
openshift-merge-botBot merged commit 0f51e11 into operator-framework:masterJan 29, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@grokspawn@rashmigottipati@tmshort