pkg/manifests: fix dropped walk errors

[alrs]

A filepath.Walk() function takes an error as one of its arguments. Usually the first thing to do in a Walk() is to check if the err provided is not nil and should be returned. This fixes three places in pkg/manifests where a WalkFunc() was not handling the err.

Tests continue to pass.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds early error handling at the start of filepath.WalkFunc implementations to propagate errors received from the walker before attempting further processing.

Changes:

• Return early when the incoming err parameter is non-nil in LoadPackagesWalkFunc and LoadBundleWalkFunc in packagemanifestloader.go.
• Apply the same early-return guard in bundleLoader.LoadBundleWalkFunc.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/manifests/packagemanifestloader.go	Propagates walker errors early in both walk functions before file inspection.
pkg/manifests/bundleloader.go	Propagates walker errors early in the bundle loader's walk function.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[perdasilva]

@alrs Thanks for this ^^ the functions changed are exported - should we add a unit test for each for the changes?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.33%. Comparing base (755d5d1) to head (b087a17).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #495 +/- ##
==========================================
+ Coverage 22.13% 22.33% +0.19% 
==========================================
Files 60 60 Lines 7869 7872 +3 ==========================================
+ Hits 1742 1758 +16 + Misses 5969 5962 -7 + Partials 158 152 -6 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tmshort]

/lgtm

Looks fine to me, these types of walk functions should be returning the error they receive as input.

[tmshort]

/hold

[tmshort]

/approve cancel
/hold cancel

I did not mean to LGTM and approve

[Copilot]

✅ Ready to approve

The changes correctly implement standard filepath.WalkFunc error handling and are covered by new unit tests without introducing behavioral risk beyond preserving/propagating existing walk errors.

Note: this review does not count toward required approvals for merging.

Copilot's findings

• Files reviewed: 3/3 changed files
• Comments generated: 0 new

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

[perdasilva]

@tmshort@alrs I've added a commit with unit tests - let me know if this is an improvement or not

[tmshort]

/approve

[rashmigottipati]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment