Uh oh!
There was an error while loading. Please reload this page.
🌱 Combine the catalogd services - #402
Conversation
bentito
commented
Sep 16, 2024
/lgtm |
| - op: replace | ||
| path: /webhooks/0/clientConfig/service/name | ||
| value: catalogd-webhook-service | ||
| value: catalogd-catalogserver |
There was a problem hiding this comment.
Is it possible to get the name of the service to end up being simply catalogd?
There was a problem hiding this comment.
No, because catalogd- is a prefix that is added via kustomize.
The name is defined here: https://github.com/operator-framework/catalogd/blob/main/config/base/manager/catalogserver_service.yaml without the catalogd-. I suppose I could just name it service, that way, it ends up as catalogd-service?
There was a problem hiding this comment.
I was able to reduce it to catalogd-service (once the prefix is added).
| - name: webhook | ||
| protocol: TCP | ||
| port: 444 | ||
| targetPort: 9444 |
There was a problem hiding this comment.
WDYT about this mapping?
- catalogd api server 8443:443
- webhook server 9443:9443
- metrics - 10443:10443
Everything gets a 443 suffix, and the main catalogd api server ends up getting the "nice" https url with no explicit port necessary.
There was a problem hiding this comment.
I can play around with it. The metrics port would require some additional golang programming, I'm guessing.
There was a problem hiding this comment.
The metrics might be stuck at https due to the proxy.
There was a problem hiding this comment.
I don't like 10443, so I used 7443 instead.
The 443 port is patched in with the cert-manager overlay.
tmshort
commented
Sep 17, 2024
How did this fail EVERYTHING? |
Only need to define one service for: * metrics * webhook * catalogd itself Clean up the name of the service (now `catalogd-service`) and any corresponding resources Renumber the ports to 7443/8443/9443. The external port for the catalog server is either 80 or 443. Signed-off-by: Todd Short <todd.short@me.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #402 +/- ##
=======================================
Coverage 38.04% 38.04% =======================================
Files 15 15 Lines 786 786 =======================================
Hits 299 299 Misses 443 443 Partials 44 44 ☔ View full report in Codecov by Sentry. |
Only need to define one service for:
Clean up the name of the service (now
catalogd-service) and any corresponding resourcesRenumber the ports to 7443/8443/9443. The external port for the catalog server is either 80 or 443.