Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

✨ Replace separator in NotSatisfiable error - #158

Merged
everettraven merged 1 commit into
operator-framework:mainfrom
m1kola:change_separator
Nov 13, 2023
Merged

✨ Replace separator in NotSatisfiable error#158
everettraven merged 1 commit into
operator-framework:mainfrom
m1kola:change_separator

Conversation

@m1kola

@m1kolam1kola commented Nov 13, 2023

Copy link
Copy Markdown
Member

Use new line instead of comma as a separator.

Example from operator-controller as yaml:

status:
conditions:
- lastTransitionTime: "2023-11-13T13:43:28Z"message: |- constraints not satisfiable: argocd-operator package uniqueness permits at most 1 of operatorhubio-argocd-operator-argocd-operator.v0.6.0, operatorhubio-argocd-operator-argocd-operator.v0.4.0 installed package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.4.0 installed package argocd-operator is mandatory required package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.6.0 required package argocd-operator is mandatoryobservedGeneration: 2reason: ResolutionFailedstatus: "False"type: Resolved

And as json:

{
"status": {
"conditions": [
{
"lastTransitionTime": "2023-11-13T13:43:28Z",
"message": "constraints not satisfiable:\nargocd-operator package uniqueness permits at most 1 of operatorhubio-argocd-operator-argocd-operator.v0.6.0, operatorhubio-argocd-operator-argocd-operator.v0.4.0\ninstalled package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.4.0\ninstalled package argocd-operator is mandatory\nrequired package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.6.0\nrequired package argocd-operator is mandatory",
"observedGeneration": 2,
"reason": "ResolutionFailed",
"status": "False",
"type": "Resolved"
}
]
}
}

Closes#150

Use new line instead of comma as a separator.
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@codecov

codecovBot commented Nov 13, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a012d2) 65.45% compared to head (3135de7) 65.45%.

Additional details and impacted files
@@ Coverage Diff @@## main #158 +/- ##
=======================================
Coverage 65.45% 65.45% =======================================
Files 11 11 Lines 495 495 =======================================
Hits 324 324 Misses 152 152 Partials 19 19 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola
m1kola marked this pull request as ready for review November 13, 2023 13:32
@m1kola
m1kola requested a review from a team as a code ownerNovember 13, 2023 13:32
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@m1kolam1kola changed the title Replace separator in NotSatisfiable error✨ Replace separator in NotSatisfiable errorNov 13, 2023
@m1kola
m1kola marked this pull request as draft November 13, 2023 13:39
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@m1kola
m1kola marked this pull request as ready for review November 13, 2023 13:47
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023

@everettraveneverettraven left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help a lot with readability!

@everettraven
everettraven added this pull request to the merge queueNov 13, 2023
Merged via the queue into operator-framework:main with commit ddaf504Nov 13, 2023
@m1kola
m1kola deleted the change_separator branch November 14, 2023 13:36
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace commas in error messages

3 participants

@m1kola@ncdc@everettraven