Skip to content

fix: adding missing tags for non k8s events - #3256

Merged
csviri merged 8 commits into
operator-framework:mainfrom
csviri:add-empty-action
Mar 27, 2026
Merged

fix: adding missing tags for non k8s events#3256
csviri merged 8 commits into
operator-framework:mainfrom
csviri:add-empty-action

Conversation

@csviri

@csviricsviri commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

Signed-off-by: Attila Mészáros a_meszaros@apple.com

CopilotAI review requested due to automatic review settings March 26, 2026 16:09
@csviricsviri mentioned this pull request Mar 26, 2026
Closed
@csviri
fix: adding missing tags for non k8s events
c001f86
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
f59d07b
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
39e58cc
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
CopilotAI reviewed Mar 26, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts MicrometerMetricsV2 event metrics so that non-Kubernetes (non-ResourceEvent) events emit a more consistent set of tags.

Changes:

  • Adds an action tag with an "UNKNOWN" value for non-ResourceEvent events.
  • Adds a namespace value for non-ResourceEvent events (currently hardcoded as "NO_NAMESPACE").

Comment thread...ort/src/main/java/io/javaoperatorsdk/operator/monitoring/micrometer/MicrometerMetricsV2.java
Comment thread...ort/src/main/java/io/javaoperatorsdk/operator/monitoring/micrometer/MicrometerMetricsV2.java
@csviricsviri linked an issue Mar 26, 2026 that may be closed by this pull request
Micrometer metrics meter events_received_total is registered multiple times #3255
Closed
@csviri
wip
258fc0c
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
5a44c3c
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
0685dd6
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
c3f8698
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
csviri requested a review from CopilotMarch 27, 2026 12:29
CopilotAI reviewed Mar 27, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comment thread...ort/src/main/java/io/javaoperatorsdk/operator/monitoring/micrometer/MicrometerMetricsV2.java
Comment thread...-processing/src/test/java/io/javaoperatorsdk/operator/sample/metrics/MetricsHandlingE2E.java Outdated
Comment thread...-processing/src/test/java/io/javaoperatorsdk/operator/sample/metrics/MetricsHandlingE2E.java
Comment on lines +260 to +262
for (String expected : expectedSubstrings) {
log.info("Checking if result: {} contains expected: {}", result, expected);
assertThat(result).contains(expected);

CopilotAIMar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log.info("Checking if result: {} contains expected: {}", result, expected); logs the full Prometheus JSON response once per expected substring on every poll iteration. This can create extremely noisy logs and slow CI. Prefer logging only the query / expected substring (or log the full result once at debug level).

Copilot uses AI. Check for mistakes.
Comment thread...ing/src/main/java/io/javaoperatorsdk/operator/sample/metrics/MetricsHandlingReconciler1.java
@csviri
wip
4ddc85a
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
csviri merged commit c0eb78f into operator-framework:mainMar 27, 2026
26 checks passed
@ThoSapThoSap mentioned this pull request Apr 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@metacosmmetacosmmetacosm approved these changes
@xstefankxstefankxstefank approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Micrometer metrics meter events_received_total is registered multiple times

4 participants

@csviri@metacosm@xstefank