fix: set configuration service for default pool by csviri · Pull Request #3535 · operator-framework/java-operator-sdk

csviri · 2026-08-01T19:40:23Z

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Copilot

Pull request overview

This PR updates the default ConfigurationService#informerPool() implementation to ensure the returned DefaultInformerPool is properly initialized with the ConfigurationService, aligning the default pool’s lifecycle with the framework’s expected configuration injection behavior.

Changes:

Initialize the default DefaultInformerPool with setConfigurationService(this) before returning it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

csviri · 2026-08-01T19:40:23Z

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Copilot

Pull request overview

This PR updates the default ConfigurationService#informerPool() implementation to ensure the returned DefaultInformerPool is properly initialized with the ConfigurationService, aligning the default pool’s lifecycle with the framework’s expected configuration injection behavior.

Changes:

Initialize the default DefaultInformerPool with setConfigurationService(this) before returning it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

csviri · 2026-08-01T19:40:23Z

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Copilot

Pull request overview

This PR updates the default ConfigurationService#informerPool() implementation to ensure the returned DefaultInformerPool is properly initialized with the ConfigurationService, aligning the default pool’s lifecycle with the framework’s expected configuration injection behavior.

Changes:

Initialize the default DefaultInformerPool with setConfigurationService(this) before returning it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

csviri · 2026-08-01T19:40:23Z

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Copilot

Pull request overview

This PR updates the default ConfigurationService#informerPool() implementation to ensure the returned DefaultInformerPool is properly initialized with the ConfigurationService, aligning the default pool’s lifecycle with the framework’s expected configuration injection behavior.

Changes:

Initialize the default DefaultInformerPool with setConfigurationService(this) before returning it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

csviri · 2026-08-01T19:40:23Z

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Copilot

Pull request overview

This PR updates the default ConfigurationService#informerPool() implementation to ensure the returned DefaultInformerPool is properly initialized with the ConfigurationService, aligning the default pool’s lifecycle with the framework’s expected configuration injection behavior.

Changes:

Initialize the default DefaultInformerPool with setConfigurationService(this) before returning it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

csviri · 2026-08-01T19:40:23Z

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Copilot

Pull request overview

This PR updates the default ConfigurationService#informerPool() implementation to ensure the returned DefaultInformerPool is properly initialized with the ConfigurationService, aligning the default pool’s lifecycle with the framework’s expected configuration injection behavior.

Changes:

Initialize the default DefaultInformerPool with setConfigurationService(this) before returning it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

csviri · 2026-08-01T19:40:23Z

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Copilot

Pull request overview

This PR updates the default ConfigurationService#informerPool() implementation to ensure the returned DefaultInformerPool is properly initialized with the ConfigurationService, aligning the default pool’s lifecycle with the framework’s expected configuration injection behavior.

Changes:

Initialize the default DefaultInformerPool with setConfigurationService(this) before returning it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

csviri · 2026-08-01T19:40:23Z

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Copilot

Pull request overview

This PR updates the default ConfigurationService#informerPool() implementation to ensure the returned DefaultInformerPool is properly initialized with the ConfigurationService, aligning the default pool’s lifecycle with the framework’s expected configuration injection behavior.

Changes:

Initialize the default DefaultInformerPool with setConfigurationService(this) before returning it.

This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

fix: set configuration service for default pool
dd7b12a
This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

CopilotAI review requested due to automatic review settings August 1, 2026 19:40

openshift-ciBot requested review from metacosm and xstefank August 1, 2026 19:40

openshift-ciBot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2026

csviri changed the base branch from main to nextAugust 1, 2026 19:40

Copilotstarted reviewing on behalf of csviri August 1, 2026 19:40 View session

csviri changed the title ~~default pool fix~~fix: set configuration service for default poolAug 1, 2026

CopilotAI reviewed Aug 1, 2026
View reviewed changes

Comment thread...ramework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java

csviri marked this pull request as draft August 1, 2026 19:51

openshift-ciBot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 1, 2026

csviri marked this pull request as ready for review August 2, 2026 09:16

openshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2026

xstefank approved these changes Aug 3, 2026
View reviewed changes

csviri merged commit 907fe61 into operator-framework:nextAug 3, 2026
1 check passed

csviri mentioned this pull request Aug 11, 2026
test: sample for virtual threads #3554
Closed