Uh oh!
There was an error while loading. Please reload this page.
🐛 Revert "✨ Wire up Service Account (#1038)" - #1072
Conversation
This reverts commit 95b9f0d.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
commented
Jul 19, 2024
The "Verify PR title" test is failing because I have an Issue/PR number in the title. In this case, I think it makes sense for the title to reference the PR that we're reverting, so I'm going to ignore that error. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1072 +/- ##
==========================================
+ Coverage 72.59% 72.85% +0.25%
==========================================
Files 31 31 Lines 1883 1864 -19 ==========================================
- Hits 1367 1358 -9 + Misses 377 371 -6 + Partials 139 135 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This reverts commit 95b9f0d.
Description
This reverts the #1038, which breaks the standard install of OLMv1.
It appears that the code from #1038 still requires the OLMv1 system service account to have
* / * / *permissions (or at least permission to list/watch everything).The e2e tests from that PR pass because they layer
* / * / *permissions back in for both the OLM SA and the ClusterExtension SA, which means that our SA features are essentially untested.Reviewer Checklist