Skip to content

🐛 Revert "✨ Wire up Service Account (#1038)" - #1072

Closed
joelanford wants to merge 1 commit into
operator-framework:mainfrom
joelanford:revert-1038
Closed

🐛 Revert "✨ Wire up Service Account (#1038)"#1072
joelanford wants to merge 1 commit into
operator-framework:mainfrom
joelanford:revert-1038

Conversation

@joelanford

Copy link
Copy Markdown
Member

This reverts commit 95b9f0d.

Description

This reverts the #1038, which breaks the standard install of OLMv1.

It appears that the code from #1038 still requires the OLMv1 system service account to have * / * / * permissions (or at least permission to list/watch everything).

The e2e tests from that PR pass because they layer * / * / * permissions back in for both the OLM SA and the ClusterExtension SA, which means that our SA features are essentially untested.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford
joelanford requested a review from a team as a code ownerJuly 19, 2024 12:43
@joelanfordjoelanford changed the title Revert ":sparkles: Wire up Service Account (#1038)"🐛 Revert "✨ Wire up Service Account (#1038)"Jul 19, 2024
@netlify

netlifyBot commented Jul 19, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitbb4171f
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/669a5f69f7ab3400083b9d94
😎 Deploy Previewhttps://deploy-preview-1072--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joelanford

Copy link
Copy Markdown
MemberAuthor

The "Verify PR title" test is failing because I have an Issue/PR number in the title. In this case, I think it makes sense for the title to reference the PR that we're reverting, so I'm going to ignore that error.

@codecov

codecovBot commented Jul 19, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.85%. Comparing base (95b9f0d) to head (bb4171f).

Additional details and impacted files
@@ Coverage Diff @@## main #1072 +/- ##
==========================================
+ Coverage 72.59% 72.85% +0.25% 
==========================================
Files 31 31 Lines 1883 1864 -19 ==========================================
- Hits 1367 1358 -9 + Misses 377 371 -6 + Partials 139 135 -4 
FlagCoverage Δ
e2e55.51% <ø> (-0.68%)⬇️
unit45.01% <ø> (+0.45%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford
joelanford added this pull request to the merge queue Jul 19, 2024
github-merge-queueBot pushed a commit that referenced this pull request Jul 19, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jul 19, 2024
@joelanford
joelanford added this pull request to the merge queue Jul 19, 2024
@joelanford
joelanford removed this pull request from the merge queue due to a manual request Jul 19, 2024
@joelanford
joelanford deleted the revert-1038 branch July 19, 2024 13:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@joelanford@grokspawn