Skip to content

⚠️ Bump ClusterExtension API to v1 - #1228

Merged
everettraven merged 3 commits into
operator-framework:mainfrom
perdasilva:perdasilva/api/bump-to-v1
Nov 12, 2024
Merged

⚠️ Bump ClusterExtension API to v1#1228
everettraven merged 3 commits into
operator-framework:mainfrom
perdasilva:perdasilva/api/bump-to-v1

Conversation

@perdasilva

@perdasilvaperdasilva commented Sep 6, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Updates ClusterExtension to v1
  • Adds operatorsv1alpha1 package alias for operators/v1alpha1
  • Does NOT update to catalogd v1 (as that's not merged or released yet)

Closes#1155

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva
perdasilva requested a review from a team as a code ownerSeptember 6, 2024 15:14
@perdasilvaperdasilva changed the title ⚠️ Bump CatalogExtension API to v1[HOLD] ⚠️ Bump CatalogExtension API to v1Sep 6, 2024
@netlify

netlifyBot commented Sep 6, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit05f03c6
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/6733bc3c0fbe080008eac482
😎 Deploy Previewhttps://deploy-preview-1228--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch from d847c22 to f5ee8f8CompareSeptember 6, 2024 16:41
@codecov

codecovBot commented Sep 6, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (aaa0e00) to head (05f03c6).
Report is 2 commits behind head on main.

Files with missing linesPatch %Lines
internal/controllers/common_controller.go82.35%3 Missing ⚠️
internal/applier/helm.go75.00%1 Missing ⚠️
internal/contentmanager/sourcerer.go0.00%0 Missing and 1 partial ⚠️
internal/resolve/resolver.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1228 +/- ##
==========================================
- Coverage 74.88% 74.76% -0.13% 
==========================================
Files 42 42 Lines 3241 3241 ==========================================
- Hits 2427 2423 -4 - Misses 643 646 +3 - Partials 171 172 +1
FlagCoverage Δ
e2e52.05% <81.15%> (ø)
unit57.05% <66.66%> (-0.13%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch from f5ee8f8 to c28a8e4CompareSeptember 6, 2024 17:01
@perdasilva

perdasilva commented Sep 6, 2024

Copy link
Copy Markdown
ContributorAuthor

@yashoza19 I just saw that you had your name down on the ticket to bump the API. I was on a bit of rampage today and didn't notice and went ahead and did it. I'm sorry about that. If it's helpful, please take what I've done here, otherwise, I'm happy to close. Apologies again =(

@yashoza19

yashoza19 commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

@yashoza19 I just saw that you had your name down on the ticket to bump the API. I was on a bit of rampage today and didn't notice and went ahead and did it. I'm sorry about that. If it's helpful, please take what I've done here, otherwise, I'm happy to close. Apologies again =(

@perdasilva No worries at all. I was holding this issue off until we are done with all the other issues in epic-v1.

@LalatenduMohanty

LalatenduMohanty commented Sep 9, 2024

Copy link
Copy Markdown
Member

/hold

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2024
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch from c28a8e4 to 99301a4CompareSeptember 11, 2024 15:00
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch from 99301a4 to e75be81CompareSeptember 11, 2024 15:01
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2024
@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch from e75be81 to 05ac2e2CompareSeptember 12, 2024 09:40
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2024
@perdasilva
perdasilva marked this pull request as draft September 12, 2024 13:39
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch from 05ac2e2 to 39632f2CompareSeptember 13, 2024 08:49
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch from 39632f2 to 82c0ef0CompareSeptember 20, 2024 12:40
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch 2 times, most recently from 374f2ce to ccf704fCompareSeptember 25, 2024 15:34
@perdasilvaperdasilva changed the title [HOLD] ⚠️ Bump CatalogExtension API to v1[HOLD] ⚠️ Bump ClusterExtension API to v1Sep 25, 2024
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2024
@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch from ccf704f to 1552e77CompareOctober 7, 2024 08:41
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@perdasilva
perdasilvaforce-pushed the perdasilva/api/bump-to-v1 branch from 1552e77 to e41bc8fCompareOctober 7, 2024 13:07
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/bundleutil/bundle.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/catalogmetadata/filter/successors.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/catalogmetadata/filter/successors_test.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/contentmanager/cache/cache_test.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/controllers/clusterextension_admission_test.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/controllers/clusterextension_controller.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/controllers/clusterextension_controller_test.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/controllers/common_controller.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/controllers/common_controller_test.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/controllers/suite_test.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/resolve/catalog.go Outdated
everettraven
everettraven reviewed Nov 12, 2024
View reviewed changes
Comment threadinternal/resolve/catalog_test.go Outdated
@everettraven
update imports to drop alpha1 suffix
05f03c6
and other minor version changes that were missed when bumping
API versions to v1.
Signed-off-by: everettraven <everettraven@gmail.com>
@everettraveneverettraven changed the title [HOLD] ⚠️ Bump ClusterExtension API to v1⚠️ Bump ClusterExtension API to v1Nov 12, 2024
@everettraven

everettraven commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

/hold cancel

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
@everettraven
everettraven added this pull request to the merge queue Nov 12, 2024
Merged via the queue into operator-framework:main with commit cb08ad4Nov 12, 2024
@everettraveneverettraven mentioned this pull request Nov 12, 2024
Closed
4 tasks
@m1kolam1kola mentioned this pull request Nov 13, 2024
Merged
4 tasks
m1kola pushed a commit to m1kola/operator-controller that referenced this pull request Nov 13, 2024
Mikalai Radchuk
Fix upgrade-e2e CI job
ab954d5
The latest release v1.0.0-rc1 includes the change to the API:
OLM v1alpha1 APIs became v1 and this needs to be reflected
in the upgrade-e2e CI job.
Refs:
* operator-framework#1228
* operator-framework#1441
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kolam1kola mentioned this pull request Nov 13, 2024
Merged
4 tasks
m1kola pushed a commit to m1kola/operator-controller that referenced this pull request Nov 13, 2024
Mikalai Radchuk
Update remaining v1alpha1 references with v1
0aa25b5
There are a few remaining references to v1alpha1 that need to be
updated to use v1.
Ref:
* operator-framework#1228
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kolam1kola mentioned this pull request Nov 13, 2024
Merged
4 tasks
github-merge-queueBot pushed a commit that referenced this pull request Nov 13, 2024
@m1kola
Fix upgrade-e2e CI job (#1451)
a5966fa
The latest release v1.0.0-rc1 includes the change to the API:
OLM v1alpha1 APIs became v1 and this needs to be reflected
in the upgrade-e2e CI job.
Refs:
* #1228
* #1441
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola pushed a commit to m1kola/operator-controller that referenced this pull request Nov 13, 2024
Mikalai Radchuk
Update remaining v1alpha1 references with v1
932501a
There are a few remaining references to v1alpha1 that need to be
updated to use v1.
Ref:
* operator-framework#1228
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
github-merge-queueBot pushed a commit that referenced this pull request Nov 13, 2024
@m1kola
Update remaining v1alpha1 references with v1 (#1452)
102f29f
There are a few remaining references to v1alpha1 that need to be
updated to use v1.
Ref:
* #1228
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@everettraveneverettraveneverettraven approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Promote v1alpha1 ClusterExtension API version to v1

6 participants

@perdasilva@yashoza19@LalatenduMohanty@joelanford@everettraven@openshift-merge-robot