Uh oh!
There was an error while loading. Please reload this page.
✨ Remove unpacked status - #1309
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1309 +/- ##
==========================================
- Coverage 76.58% 76.34% -0.24%
==========================================
Files 40 40 Lines 2413 2389 -24 ==========================================
- Hits 1848 1824 -24
Misses 397 397 Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| require.NoError(t, cl.DeleteAllOf(ctx, &ocv1alpha1.ClusterExtension{})) |
There was a problem hiding this comment.
This seems reasonable to keep around - I must've been a bit heavy handed on my removal of logic in this test and removed this
Uh oh!
There was an error while loading. Please reload this page.
5cdbd9d to
325ddf2CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
325ddf2 to
75c07f5Compare
everettraven
left a comment
There was a problem hiding this comment.
Changes look good to me! Thanks @skattoju !
CI also looks green except for go-apidiff which has the expected failure
Uh oh!
There was an error while loading. Please reload this page.
skattoju
commented
Sep 26, 2024
There is an e2e failure in the merge queue but it passes locally 🤔 and its not in a function that had an unpacked condition removed.. specifically |
Description
This PR removes the "Unpacked" status which has now been rolled into a "Progressing" status.
Fixes#1294
Reviewer Checklist