Skip to content

✨ Remove unpacked status - #1309

Merged
everettraven merged 1 commit into
operator-framework:mainfrom
skattoju:remove_unpacked
Sep 26, 2024
Merged

✨ Remove unpacked status#1309
everettraven merged 1 commit into
operator-framework:mainfrom
skattoju:remove_unpacked

Conversation

@skattoju

@skattojuskattoju commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

Description

This PR removes the "Unpacked" status which has now been rolled into a "Progressing" status.
Fixes#1294

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@skattoju
skattoju requested a review from a team as a code ownerSeptember 25, 2024 19:28
@netlify

netlifyBot commented Sep 25, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit75c07f5
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66f4a2dc01d26e00072fb4e5
😎 Deploy Previewhttps://deploy-preview-1309--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@skattojuskattoju changed the title Remove unpacked status✨ Remove unpacked statusSep 25, 2024
@codecov

codecovBot commented Sep 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.34%. Comparing base (679e4ab) to head (75c07f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1309 +/- ##
==========================================
- Coverage 76.58% 76.34% -0.24% 
==========================================
Files 40 40 Lines 2413 2389 -24 ==========================================
- Hits 1848 1824 -24 
Misses 397 397 Partials 168 168 
FlagCoverage Δ
e2e58.81% <0.00%> (+0.08%)⬆️
unit52.69% <100.00%> (-0.48%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment threadinternal/controllers/clusterextension_controller.go
Comment threadinternal/controllers/clusterextension_controller_test.go Outdated
Comment threadinternal/controllers/clusterextension_controller_test.go Outdated
Comment on lines +303 to +235

require.NoError(t, cl.DeleteAllOf(ctx, &ocv1alpha1.ClusterExtension{}))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to keep around - I must've been a bit heavy handed on my removal of logic in this test and removed this

Comment threadinternal/controllers/clusterextension_controller_test.go Outdated
@skattoju
skattojuforce-pushed the remove_unpacked branch 2 times, most recently from 5cdbd9d to 325ddf2CompareSeptember 25, 2024 20:20
Comment threadinternal/controllers/clusterextension_controller_test.go
Comment threadinternal/controllers/clusterextension_controller_test.go Outdated
Comment threadinternal/controllers/clusterextension_controller_test.go Outdated
Comment threadinternal/controllers/clusterextension_controller_test.go

@everettraveneverettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Thanks @skattoju !

CI also looks green except for go-apidiff which has the expected failure

@everettraven
everettraven added this pull request to the merge queue Sep 26, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@skattoju

Copy link
Copy Markdown
ContributorAuthor

There is an e2e failure in the merge queue but it passes locally 🤔 and its not in a function that had an unpacked condition removed.. specifically TestClusterExtensionBlockInstallNonSuccessorVersion It might be intermittent ...

@everettraven
everettraven added this pull request to the merge queue Sep 26, 2024
Merged via the queue into operator-framework:main with commit 40ada4aSep 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1 API Review] Remove the Unpacked status condition

2 participants

@skattoju@everettraven