Skip to content

✨ Remove the Resolved status condition - #1312

Merged
everettraven merged 1 commit into
operator-framework:mainfrom
yashoza19:issue1293
Sep 26, 2024
Merged

✨ Remove the Resolved status condition#1312
everettraven merged 1 commit into
operator-framework:mainfrom
yashoza19:issue1293

Conversation

@yashoza19

Copy link
Copy Markdown
Contributor

Description

Fixes#1293

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@yashoza19
yashoza19 requested a review from a team as a code ownerSeptember 26, 2024 16:22
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@netlify

netlifyBot commented Sep 26, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitea816a4
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66f598c8089fac0008e36f2d
😎 Deploy Previewhttps://deploy-preview-1312--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
Signed-off-by: yashoza19 <yoza@redhat.com>

@LalatenduMohantyLalatenduMohanty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@LalatenduMohanty

Copy link
Copy Markdown
Member

@yashoza19 The PR is still work in progress. Can you please remove it ?

@everettraveneverettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @yashoza19 !

@everettraveneverettraven changed the title ✨ [WIP] Remove the Resolved status condition✨ Remove the Resolved status conditionSep 26, 2024
@everettraven
everettraven added this pull request to the merge queue Sep 26, 2024
Merged via the queue into operator-framework:main with commit 8699d25Sep 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1 API Review] Remove the Resolved status condition

4 participants

@yashoza19@LalatenduMohanty@everettraven@openshift-merge-robot