Uh oh!
There was an error while loading. Please reload this page.
📖 Fix docs: "How to" section - #1463
Merged
Merged
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m1kolaforce-pushed
the
fix_docs
branch
2 times, most recently
from
November 14, 2024 12:23
7bd4e73 to
9ecac97Compare
There were several intentional breaking changes in the API which are now included in v0.18.0 release. This commit mostly focuses on updating the documentation to reflect API changes. This includes making sure that snippets and example outputs match the current state of the project. Relevant PRs: * operator-framework#1439 * operator-framework#1434 Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
marked this pull request as ready for review
November 14, 2024 15:26
tmshort
approved these changes
Nov 14, 2024
tmshort
left a comment
Contributor
There was a problem hiding this comment.
/lgtm
Looks like the changes I need to make to some of the tests! :)
m1kola
commented
Nov 14, 2024
| namespace: argocd | ||
| serviceAccount: | ||
| name: argocd-installer | ||
| version: "!=1.3.2" # Don’t allow version 1.3.2 |
MemberAuthor
There was a problem hiding this comment.
I panicked because of this doc today:
- It was using
!instead of!=. - After fixing it - it did not work because of
“instead of"
I thought we had a regression in version field validation somewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were several intentional breaking changes in the API which are now included in v0.18.0 release.
This commit mostly focuses on updating the documentation to reflect API changes. This includes making sure that snippets and example outputs match the current state of the project.
Relevant PRs:
.spec.install.namespaceand.spec.install.serviceAccountto.spec.namespaceand.spec.serviceAccount#1439Reviewer Checklist