Skip to content

🐛 Use monorepo release for catalogd - #1656

Merged
perdasilva merged 1 commit into
operator-framework:mainfrom
LalatenduMohanty:1605_update_catalogd_demo_script
Jan 28, 2025
Merged

🐛 Use monorepo release for catalogd#1656
perdasilva merged 1 commit into
operator-framework:mainfrom
LalatenduMohanty:1605_update_catalogd_demo_script

Conversation

@LalatenduMohanty

@LalatenduMohantyLalatenduMohanty commented Jan 28, 2025

Copy link
Copy Markdown
Member

Description

With the change we will use the operator-controller releases for catalogd demo script

Fixes#1605

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

With the change we will use the operator-controller releases for
catalogd demo script
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty
LalatenduMohanty requested a review from a team as a code ownerJanuary 28, 2025 01:44
@netlify

netlifyBot commented Jan 28, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit930f2d0
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/6798366c303eac0008fb5288
😎 Deploy Previewhttps://deploy-preview-1656--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Jan 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.40%. Comparing base (a46ff7d) to head (930f2d0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1656 +/- ##
==========================================
- Coverage 67.42% 67.40% -0.03% 
==========================================
Files 55 55 Lines 4632 4632 ==========================================
- Hits 3123 3122 -1 - Misses 1284 1285 +1 
Partials 225 225 
FlagCoverage Δ
e2e53.29% <ø> (+0.08%)⬆️
unit54.42% <ø> (-0.03%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilvaperdasilva changed the title 🐛 Fixed #1605: Using monorepo release for catalogd🐛 Use monorepo release for catalogdJan 28, 2025
@perdasilva
perdasilva added this pull request to the merge queue Jan 28, 2025
Merged via the queue into operator-framework:main with commit 0ce72bdJan 28, 2025

# use the install script from the latest github release
curl -L -s https://github.com/operator-framework/catalogd/releases/latest/download/install.sh | bash
curl -L -s https://github.com/operator-framework/operator-controller/releases/latest/download/install.sh | bash

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this change has been made before cutting a latest release, I think this link points to the old latest which does not include the monorepo changes. Is the plan to follow-up with cutting a release to make this script work?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the CatalogD demo script to use source-code in the operator-controller repo

3 participants

@LalatenduMohanty@perdasilva@rashmigottipati