Skip to content

🌱 Bump github.com/containers/image/v5 from 5.33.1 to 5.34.0 - #1692

Closed
dependabot[bot] wants to merge 7 commits into
mainfrom
dependabot/go_modules/github.com/containers/image/v5-5.34.0
Closed

🌱 Bump github.com/containers/image/v5 from 5.33.1 to 5.34.0#1692
dependabot[bot] wants to merge 7 commits into
mainfrom
dependabot/go_modules/github.com/containers/image/v5-5.34.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubFeb 3, 2025

Copy link
Copy Markdown
Contributor

Bumps github.com/containers/image/v5 from 5.33.1 to 5.34.0.

Release notes

Sourced from github.com/containers/image/v5's releases.

v5.34.0

What's Changed

... (truncated)

Commits
  • 51a5d96 Bump to c/image v5.34.0
  • 771660e Bump c/storage to v1.57.1
  • 7f0e59d Merge pull request #2696 from Luap99/ENOENT
  • 3f17e2e ignore ENOENT errors when parsing .crt files
  • c9771a8 ignore ENOENT errors when parsing registries.conf.d files
  • 1294122 ignore ENOENT errors when parsing registries.d files
  • b5c6aff Merge pull request #2693 from containers/renovate/github.com-docker-docker-27.x
  • 1683fc2 Update module github.com/docker/docker to v27.5.1+incompatible
  • 16f7e1e Merge pull request #2692 from containers/renovate/github.com-docker-cli-27.x
  • 30f0d87 Update module github.com/docker/cli to v27.5.1+incompatible
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot
dependabotBot requested a review from a team as a code ownerFebruary 3, 2025 14:25
@dependabotdependabotBot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 3, 2025
@netlify

netlifyBot commented Feb 3, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitee0adae
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67c60bf33bafde0008b2aeec
😎 Deploy Previewhttps://deploy-preview-1692--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dependabot
dependabotBotforce-pushed the dependabot/go_modules/github.com/containers/image/v5-5.34.0 branch from 69c10b2 to 8656f73CompareFebruary 3, 2025 22:02
camilamacedo86

This comment was marked as outdated.

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@camilamacedo86

Copy link
Copy Markdown
Contributor

/lgtm cancel

Mistake.

@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@camilamacedo86
camilamacedo86 dismissed their stale reviewFebruary 3, 2025 22:43

we need to make it pass in the tests

@dependabot
dependabotBotforce-pushed the dependabot/go_modules/github.com/containers/image/v5-5.34.0 branch 3 times, most recently from 1f344a4 to 15052d3CompareFebruary 11, 2025 15:32
@camilamacedo86

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot
dependabotBotforce-pushed the dependabot/go_modules/github.com/containers/image/v5-5.34.0 branch 2 times, most recently from fd6c6fe to f180d0aCompareFebruary 12, 2025 14:52
@perdasilva
perdasilvaforce-pushed the dependabot/go_modules/github.com/containers/image/v5-5.34.0 branch from f180d0a to 38129deCompareFebruary 12, 2025 17:22
@perdasilva
perdasilva marked this pull request as draft February 12, 2025 17:22
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@joelanford

Copy link
Copy Markdown
Member

This looks like an issue with containers/image and its pgp dependency. We should make sure to use -tags=containers_image_openpgp wherever necessary to avoid this.

The Makefile already has GO_BUILD_TAGS variable with this setup, so we just need to plumb that variable into whatever other commands need it to avoid pulling in github.com/proglottis/gpgme (which requires CGO_ENABLED=1).

@perdasilva
perdasilvaforce-pushed the dependabot/go_modules/github.com/containers/image/v5-5.34.0 branch from 38129de to 9709f3bCompareFebruary 13, 2025 13:40
@LalatenduMohanty

Copy link
Copy Markdown
Member

Right we already have https://github.com/operator-framework/operator-controller/blob/main/Makefile#L323 so trying to figureout how we can pass it so that it wont be an issue.

@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2025
@perdasilva
perdasilvaforce-pushed the dependabot/go_modules/github.com/containers/image/v5-5.34.0 branch from 9709f3b to 1389508CompareFebruary 14, 2025 09:44
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2025
@joelanford
joelanfordforce-pushed the dependabot/go_modules/github.com/containers/image/v5-5.34.0 branch from 1389508 to 23c02adCompareFebruary 14, 2025 19:53
@camilamacedo86

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot@github

dependabotBot commented on behalf of githubFeb 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@dependabot@github

dependabotBot commented on behalf of githubFeb 20, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@camilamacedo86

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot@github

dependabotBot commented on behalf of githubFeb 27, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@camilamacedo86

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot@github

dependabotBot commented on behalf of githubMar 3, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Comment threadMakefile

.PHONY: lint-custom
lint-custom: custom-linter-build #HELP Call custom linter for the project
go vet -tags=$(GO_BUILD_TAGS) -vettool=./bin/custom-linter ./...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelanford the problem seems to be that controller-gen does not accept that.

@dependabot@github

dependabotBot commented on behalf of githubMar 3, 2025

Copy link
Copy Markdown
ContributorAuthor

A newer version of github.com/containers/image/v5 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@tmshorttmshort mentioned this pull request Mar 3, 2025
4 tasks
dependabotBotand others added 4 commits March 3, 2025 14:52
Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.33.1 to 5.34.0.
- [Release notes](https://github.com/containers/image/releases)
- [Commits](containers/image@v5.33.1...v5.34.0)
---
updated-dependencies:
- dependency-name: github.com/containers/image/v5
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford
joelanfordforce-pushed the dependabot/go_modules/github.com/containers/image/v5-5.34.0 branch from d023b4c to d6d1734CompareMarch 3, 2025 19:57
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2025
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@codecov

codecovBot commented Mar 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.44%. Comparing base (97b1337) to head (ee0adae).
Report is 43 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1692 +/- ##
==========================================
- Coverage 68.50% 68.44% -0.06% 
==========================================
Files 63 63 Lines 5134 5134 ==========================================
- Hits 3517 3514 -3 - Misses 1388 1390 +2 - Partials 229 230 +1 
FlagCoverage Δ
e2e51.65% <ø> (-0.08%)⬇️
unit56.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot@github

dependabotBot commented on behalf of githubMar 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2025
@openshift-merge-robot

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot@github

dependabotBot commented on behalf of githubMar 6, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@tmshort

Copy link
Copy Markdown
Contributor

Closing in favor of #1892.

@tmshorttmshort closed this Apr 7, 2025
@dependabot@github

dependabotBot commented on behalf of githubApr 7, 2025

Copy link
Copy Markdown
ContributorAuthor

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabotBot deleted the dependabot/go_modules/github.com/containers/image/v5-5.34.0 branch April 7, 2025 13:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedo-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress.goPull requests that update Go codeneeds-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@camilamacedo86@joelanford@LalatenduMohanty@tmshort@openshift-merge-robot