Skip to content

🌱 [Bingo Upgrade] - Upgrade EnvTest and OPM tooling - #1820

Merged
camilamacedo86 merged 1 commit into
operator-framework:mainfrom
camilamacedo86:upgrade-opm
Mar 3, 2025
Merged

🌱 [Bingo Upgrade] - Upgrade EnvTest and OPM tooling#1820
camilamacedo86 merged 1 commit into
operator-framework:mainfrom
camilamacedo86:upgrade-opm

Conversation

@camilamacedo86

Copy link
Copy Markdown
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86
camilamacedo86 requested a review from a team as a code ownerFebruary 27, 2025 18:53
@camilamacedo86

Copy link
Copy Markdown
ContributorAuthor

@anik120

@netlify

netlifyBot commented Feb 27, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit73575a4
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67c0b4a6234d410008f01c6f
😎 Deploy Previewhttps://deploy-preview-1820--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Feb 27, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (df35dcd) to head (73575a4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1820 +/- ##
==========================================
+ Coverage 68.43% 68.49% +0.05% 
==========================================
Files 63 63 Lines 5132 5132 ==========================================
+ Hits 3512 3515 +3 + Misses 1390 1388 -2 + Partials 230 229 -1 
FlagCoverage Δ
e2e51.70% <ø> (+0.15%)⬆️
unit56.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva
perdasilva added this pull request to the merge queue Feb 28, 2025
@perdasilva
perdasilva removed this pull request from the merge queue due to a manual request Feb 28, 2025
@perdasilva

Copy link
Copy Markdown
Contributor

@camilamacedo86 lgtm and I'm leaving it up to you to merge. I just wonder if we want/need this before #1818 gets merged (or even if we want to make this part of that PR)

@camilamacedo86

Copy link
Copy Markdown
ContributorAuthor

@camilamacedo86 lgtm and I'm leaving it up to you to merge. I just wonder if we want/need this before #1818 gets merged (or even if we want to make this part of that PR)

Just updating the binary to the latest version! One thing is the version of the binary used for execution, like mocking data for E2E tests, and another is using it as a library.

If we wanted to be super precise, we could say that dependencies should be updated together, but I think is fine to do this separately. Let me know if you see any issues! 😊

@anik120anik120 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

for the changes in this PR. It's a little odd that bingo env can have binaries of a different version than what go pulls in, but it is what it is now.

Ideally it'd be nice to have what shows up in bingo + go mod be the same thing (which means any PR making changes in one would have to change the other)

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
@camilamacedo86

Copy link
Copy Markdown
ContributorAuthor

Hi @anik120@perdasilva

Ideally it'd be nice to have what shows up in bingo + go mod be the same thing (which means any PR making changes in one would have to change the other)

Yep, that would not work because the dependabot will update the dependency but not the OPM bin.
So, we never do that. but I agree that is a little odd for sure.

@camilamacedo86
camilamacedo86 added this pull request to the merge queue Mar 3, 2025
Merged via the queue into operator-framework:main with commit 97b1337Mar 3, 2025
@camilamacedo86
camilamacedo86 deleted the upgrade-opm branch March 3, 2025 19:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@camilamacedo86@perdasilva@anik120