Uh oh!
There was an error while loading. Please reload this page.
🌱 Add catalogd metas service demo - #1840
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1840 +/- ##
=======================================
Coverage 68.39% 68.39% =======================================
Files 63 63 Lines 5136 5136 =======================================
Hits 3513 3513 Misses 1392 1392 Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
| # | ||
| trap 'trap - SIGTERM && kill -- -"$$"' SIGINT SIGTERM EXIT | ||
| ## until we cut a release containing the new API, we need to deploy local artifacts |
There was a problem hiding this comment.
Why are some of these "double" commented?
There was a problem hiding this comment.
The linter said "use single quotes so they are not expanded now, but are expanded later", and the general syntax is "quote to capture strings with spaces / special characters".
grokspawn
commented
Mar 4, 2025
This is not OK. The problem here appears to be that catalogd's deployment conditions are serving := True with progressing := True... but the api is not actually serving. I need to diagnose this more, but it looks like an architectural communications gap rather than a bug. |
884e7ac to
427d0e6CompareUh oh!
There was an error while loading. Please reload this page.
f01f02e to
9f4b2d9Compare9f4b2d9 to
cb66b49Compareperdasilva
commented
Mar 6, 2025
should we hold until this is resolved? Or can we still merge and resolve out of band? |
IMO we can merge this and then look into what's going on with catd under the hood. It doesn't look like a demo bug, but the demo could be useful in diagnosing what's going on in catd. [Edit: Dialoguing elsewhere we reached consensus that |
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
cb66b49 to
0303310Compare
perdasilva
left a comment
There was a problem hiding this comment.
lgtm ^^ thanks for adding the curl retries =D
perdasilva
commented
Mar 10, 2025
we should probably standardize the w:h for the demo window when generating it, if that's possible. Nothing that needs doing in the PR tho... |
Resolves demo items of #1783
Description
Demo
Reviewer Checklist