Skip to content

🌱 Add catalogd metas service demo - #1840

Merged
perdasilva merged 3 commits into
operator-framework:mainfrom
grokspawn:fix-tutorial-metas-query
Mar 10, 2025
Merged

🌱 Add catalogd metas service demo#1840
perdasilva merged 3 commits into
operator-framework:mainfrom
grokspawn:fix-tutorial-metas-query

Conversation

@grokspawn

@grokspawngrokspawn commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Resolves demo items of #1783

Description

  • adds a demo for the metas catalog service endpoint (but does not make this part of regular CI, since it is currently dependent on deploying from local artifacts
  • Fixes a bug in the Makefile where the VERSION attribute would be empty instead of undefined, and succeeds now only with valid (non-empty) input

Demo

asciicast

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@grokspawn
grokspawn requested a review from a team as a code ownerMarch 4, 2025 19:29
@netlify

netlifyBot commented Mar 4, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit0303310
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67c9e2bf50e59b0008862180
😎 Deploy Previewhttps://deploy-preview-1840--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Mar 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.39%. Comparing base (e4e76d2) to head (0303310).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1840 +/- ##
=======================================
Coverage 68.39% 68.39% =======================================
Files 63 63 Lines 5136 5136 =======================================
Hits 3513 3513 Misses 1392 1392 Partials 231 231 
FlagCoverage Δ
e2e51.52% <ø> (ø)
unit56.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment threadMakefile Outdated
#
trap 'trap - SIGTERM && kill -- -"$$"' SIGINT SIGTERM EXIT

## until we cut a release containing the new API, we need to deploy local artifacts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are some of these "double" commented?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter said "use single quotes so they are not expanded now, but are expanded later", and the general syntax is "quote to capture strings with spaces / special characters".

@grokspawn

Copy link
Copy Markdown
ContributorAuthor

This is not OK. The problem here appears to be that catalogd's deployment conditions are serving := True with progressing := True... but the api is not actually serving.

I need to diagnose this more, but it looks like an architectural communications gap rather than a bug.

@grokspawn
grokspawnforce-pushed the fix-tutorial-metas-query branch from 884e7ac to 427d0e6CompareMarch 4, 2025 20:10
Comment threadhack/demo/catalogd-metas-demo-script.sh Outdated
@grokspawn
grokspawnforce-pushed the fix-tutorial-metas-query branch from f01f02e to 9f4b2d9CompareMarch 5, 2025 15:45
@perdasilva
perdasilvaforce-pushed the fix-tutorial-metas-query branch from 9f4b2d9 to cb66b49CompareMarch 6, 2025 09:15
@perdasilva

Copy link
Copy Markdown
Contributor

This is not OK. The problem here appears to be that catalogd's deployment conditions are serving := True with progressing := True... but the api is not actually serving.

I need to diagnose this more, but it looks like an architectural communications gap rather than a bug.

should we hold until this is resolved? Or can we still merge and resolve out of band?

@grokspawn

grokspawn commented Mar 6, 2025

Copy link
Copy Markdown
ContributorAuthor

This is not OK. The problem here appears to be that catalogd's deployment conditions are serving := True with progressing := True... but the api is not actually serving.
I need to diagnose this more, but it looks like an architectural communications gap rather than a bug.

should we hold until this is resolved? Or can we still merge and resolve out of band?

IMO we can merge this and then look into what's going on with catd under the hood. It doesn't look like a demo bug, but the demo could be useful in diagnosing what's going on in catd.

[Edit: Dialoguing elsewhere we reached consensus that .status communicates kube status only, and that clients of any endpoint need to handle error conditions on endpoints. I updated the script to retry on 404 and now it runs much more quickly!]

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn
grokspawnforce-pushed the fix-tutorial-metas-query branch from cb66b49 to 0303310CompareMarch 6, 2025 18:00

@perdasilvaperdasilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ^^ thanks for adding the curl retries =D

@perdasilva

Copy link
Copy Markdown
Contributor

we should probably standardize the w:h for the demo window when generating it, if that's possible. Nothing that needs doing in the PR tho...

@perdasilva
perdasilva added this pull request to the merge queue Mar 10, 2025
Merged via the queue into operator-framework:main with commit dbd2bd9Mar 10, 2025
@grokspawn
grokspawn deleted the fix-tutorial-metas-query branch March 31, 2025 19:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@grokspawn@perdasilva@azych@tmshort